All of lore.kernel.org
 help / color / mirror / Atom feed
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] net: stmmac: dwmac-sun8i: fix allwinner,leds-active-low handling
Date: Wed, 29 Nov 2017 16:46:49 +0100	[thread overview]
Message-ID: <20171129154649.GC24881@lunn.ch> (raw)
In-Reply-To: <CAGb2v67hv7ayH=F-MBG-PCCeVt43PH-O-6b3KOyGXSpr2s4DGg@mail.gmail.com>

Hi ChenYu
 
> It worked at one point. During some previous iteration, they lit up as
> they were supposed to.

For a released version of the kernel? Or during development work?  If
they did work, but broken, it would be good to know which commit broke
it. We can then add a fixes: tag to the patch as proposed.

    Andrew

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Corentin Labbe <clabbe.montjoie@gmail.com>,
	Alexandre Torgue <alexandre.torgue@st.com>,
	netdev <netdev@vger.kernel.org>,
	linux-sunxi <linux-sunxi@googlegroups.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Giuseppe Cavallaro <peppe.cavallaro@st.com>,
	Maxime Ripard <maxime.ripard@free-electrons.com>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] net: stmmac: dwmac-sun8i: fix allwinner,leds-active-low handling
Date: Wed, 29 Nov 2017 16:46:49 +0100	[thread overview]
Message-ID: <20171129154649.GC24881@lunn.ch> (raw)
In-Reply-To: <CAGb2v67hv7ayH=F-MBG-PCCeVt43PH-O-6b3KOyGXSpr2s4DGg@mail.gmail.com>

Hi ChenYu
 
> It worked at one point. During some previous iteration, they lit up as
> they were supposed to.

For a released version of the kernel? Or during development work?  If
they did work, but broken, it would be good to know which commit broke
it. We can then add a fixes: tag to the patch as proposed.

    Andrew

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
To: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
Cc: Corentin Labbe
	<clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Alexandre Torgue <alexandre.torgue-qxv4g6HH51o@public.gmane.org>,
	netdev <netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-sunxi <linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>,
	linux-kernel
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Giuseppe Cavallaro <peppe.cavallaro-qxv4g6HH51o@public.gmane.org>,
	Maxime Ripard
	<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
	linux-arm-kernel
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH] net: stmmac: dwmac-sun8i: fix allwinner,leds-active-low handling
Date: Wed, 29 Nov 2017 16:46:49 +0100	[thread overview]
Message-ID: <20171129154649.GC24881@lunn.ch> (raw)
In-Reply-To: <CAGb2v67hv7ayH=F-MBG-PCCeVt43PH-O-6b3KOyGXSpr2s4DGg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

Hi ChenYu
 
> It worked at one point. During some previous iteration, they lit up as
> they were supposed to.

For a released version of the kernel? Or during development work?  If
they did work, but broken, it would be good to know which commit broke
it. We can then add a fixes: tag to the patch as proposed.

    Andrew

  reply	other threads:[~2017-11-29 15:46 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-28 16:48 [PATCH] net: stmmac: dwmac-sun8i: fix allwinner, leds-active-low handling Corentin Labbe
2017-11-28 16:48 ` [PATCH] net: stmmac: dwmac-sun8i: fix allwinner,leds-active-low handling Corentin Labbe
2017-11-28 16:48 ` Corentin Labbe
2017-11-28 17:38 ` Andrew Lunn
2017-11-28 17:38   ` Andrew Lunn
2017-11-28 17:38   ` Andrew Lunn
2017-11-29  9:02   ` Corentin Labbe
2017-11-29  9:02     ` Corentin Labbe
2017-11-29  9:02     ` Corentin Labbe
2017-11-29 15:37     ` Andrew Lunn
2017-11-29 15:37       ` Andrew Lunn
2017-11-29 15:37       ` Andrew Lunn
2017-11-29 15:41       ` [PATCH] net: stmmac: dwmac-sun8i: fix allwinner, leds-active-low handling Chen-Yu Tsai
2017-11-29 15:41         ` [PATCH] net: stmmac: dwmac-sun8i: fix allwinner,leds-active-low handling Chen-Yu Tsai
2017-11-29 15:41         ` Chen-Yu Tsai
2017-11-29 15:46         ` Andrew Lunn [this message]
2017-11-29 15:46           ` Andrew Lunn
2017-11-29 15:46           ` Andrew Lunn
2017-11-29 15:50           ` [PATCH] net: stmmac: dwmac-sun8i: fix allwinner, leds-active-low handling Chen-Yu Tsai
2017-11-29 15:50             ` [PATCH] net: stmmac: dwmac-sun8i: fix allwinner,leds-active-low handling Chen-Yu Tsai
2017-11-29 15:50             ` Chen-Yu Tsai
2017-11-29 15:47       ` Maxime Ripard
2017-11-29 15:47         ` Maxime Ripard
2017-11-29 15:47         ` Maxime Ripard
2017-11-30 14:45 ` David Miller
2017-11-30 14:45   ` David Miller
2017-11-30 14:45   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171129154649.GC24881@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.