All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Norris <briannorris@chromium.org>
To: Nickey Yang <nickey.yang@rock-chips.com>
Cc: mark.rutland@arm.com, Doug Anderson <dianders@chromium.org>,
	airlied@linux.ie, hoegsberg@gmail.com,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	philippe.cornu@st.com, yannick.fertre@st.com,
	linux-rockchip@lists.infradead.org, robh+dt@kernel.org,
	zyw@rock-chips.com, xbl@rock-chips.com, mka@chromium.org,
	hl@rock-chips.com
Subject: Re: [PATCH v3 5/5] arm64: dts: rockchip: update mipi node for RK3399
Date: Wed, 29 Nov 2017 10:37:33 -0800	[thread overview]
Message-ID: <20171129183732.GA74243@google.com> (raw)
In-Reply-To: <1511868006-27130-6-git-send-email-nickey.yang@rock-chips.com>

+ Doug, since he was asking these things elsewhere

On Tue, Nov 28, 2017 at 07:20:06PM +0800, Nickey Yang wrote:
> This patch update mipi node for RK3399 DSI controller
> based on the Synopsys DesignWare MIPI DSI host controller.
> 
> Signed-off-by: Nickey Yang <nickey.yang@rock-chips.com>
> ---
>  arch/arm64/boot/dts/rockchip/rk3399.dtsi | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> index d340b58a..0ac67a9 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> @@ -1652,9 +1652,11 @@
>  		status = "disabled";
>  
>  		ports {
> -			mipi_in: port {
> -				#address-cells = <1>;
> -				#size-cells = <0>;
> +			#address-cells = <1>;
> +			#size-cells = <0>;

^^ It's good to add these here, since child nodes are going to have unit
addresses.

> +
> +			mipi_in: port@0 {
> +				reg = <0>;

^^ But you're removing the #{address,size}-cells from the port, while
still using unit addresses on its subnodes (the endpoint@... nodes). You
should keep *both*, since both the 'ports' node and the 'port@0' node
will have children with addresses.

Brian

>  
>  				mipi_in_vopb: endpoint@0 {
>  					reg = <0>;
> -- 
> 1.9.1
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Brian Norris <briannorris@chromium.org>
To: Nickey Yang <nickey.yang@rock-chips.com>
Cc: robh+dt@kernel.org, heiko@sntech.de, mark.rutland@arm.com,
	airlied@linux.ie, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org,
	linux-rockchip@lists.infradead.org, seanpaul@chromium.org,
	mka@chromium.org, hoegsberg@gmail.com, architt@codeaurora.org,
	philippe.cornu@st.com, yannick.fertre@st.com, hl@rock-chips.com,
	zyw@rock-chips.com, xbl@rock-chips.com,
	Doug Anderson <dianders@chromium.org>
Subject: Re: [PATCH v3 5/5] arm64: dts: rockchip: update mipi node for RK3399
Date: Wed, 29 Nov 2017 10:37:33 -0800	[thread overview]
Message-ID: <20171129183732.GA74243@google.com> (raw)
In-Reply-To: <1511868006-27130-6-git-send-email-nickey.yang@rock-chips.com>

+ Doug, since he was asking these things elsewhere

On Tue, Nov 28, 2017 at 07:20:06PM +0800, Nickey Yang wrote:
> This patch update mipi node for RK3399 DSI controller
> based on the Synopsys DesignWare MIPI DSI host controller.
> 
> Signed-off-by: Nickey Yang <nickey.yang@rock-chips.com>
> ---
>  arch/arm64/boot/dts/rockchip/rk3399.dtsi | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> index d340b58a..0ac67a9 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> @@ -1652,9 +1652,11 @@
>  		status = "disabled";
>  
>  		ports {
> -			mipi_in: port {
> -				#address-cells = <1>;
> -				#size-cells = <0>;
> +			#address-cells = <1>;
> +			#size-cells = <0>;

^^ It's good to add these here, since child nodes are going to have unit
addresses.

> +
> +			mipi_in: port@0 {
> +				reg = <0>;

^^ But you're removing the #{address,size}-cells from the port, while
still using unit addresses on its subnodes (the endpoint@... nodes). You
should keep *both*, since both the 'ports' node and the 'port@0' node
will have children with addresses.

Brian

>  
>  				mipi_in_vopb: endpoint@0 {
>  					reg = <0>;
> -- 
> 1.9.1
> 

  reply	other threads:[~2017-11-29 18:37 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-28 11:20 [PATCH v3 0/5] Update ROCKCHIP DSI driver that uses dw-mipi-dsi bridge Nickey Yang
2017-11-28 11:20 ` Nickey Yang
2017-11-28 11:20 ` [PATCH v3 1/5] drm/bridge/synopsys: stop clobbering drvdata Nickey Yang
2017-11-28 11:20   ` Nickey Yang
2017-11-29  1:52   ` Sean Paul
2017-11-29  1:52     ` Sean Paul
2017-12-01 23:47   ` kbuild test robot
2017-12-01 23:47     ` kbuild test robot
2017-11-28 11:20 ` [PATCH v3 2/5] drm/stm: dsi: Adjust dw_mipi_dsi_probe and remove Nickey Yang
2017-11-28 11:20   ` Nickey Yang
2017-11-28 18:41   ` Brian Norris
2017-11-28 18:41     ` Brian Norris
2017-11-29  2:10     ` Sean Paul
2017-11-28 11:20 ` [PATCH v3 3/5] dt-bindings: display: rockchip: update DSI controller Nickey Yang
2017-11-28 11:20   ` Nickey Yang
2017-11-30 16:58   ` Brian Norris
2017-11-30 16:58     ` Brian Norris
2017-11-28 11:20 ` [PATCH v3 4/5] drm/rockchip: Add ROCKCHIP DW MIPI DSI controller driver Nickey Yang
2017-11-28 11:20   ` Nickey Yang
2017-11-28 20:48   ` Matthias Kaehlcke
2017-11-28 20:48     ` Matthias Kaehlcke
2017-11-28 22:55     ` Brian Norris
2017-11-28 22:55       ` Brian Norris
2017-11-29  2:02       ` Sean Paul
2017-11-29  2:02         ` Sean Paul
2017-11-29 17:09         ` Brian Norris
2017-12-01  6:42     ` Nickey Yang
2017-12-01  6:42       ` Nickey Yang
2017-11-28 11:20 ` [PATCH v3 5/5] arm64: dts: rockchip: update mipi node for RK3399 Nickey Yang
2017-11-28 11:20   ` Nickey Yang
2017-11-29 18:37   ` Brian Norris [this message]
2017-11-29 18:37     ` Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171129183732.GA74243@google.com \
    --to=briannorris@chromium.org \
    --cc=airlied@linux.ie \
    --cc=dianders@chromium.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hl@rock-chips.com \
    --cc=hoegsberg@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=mka@chromium.org \
    --cc=nickey.yang@rock-chips.com \
    --cc=philippe.cornu@st.com \
    --cc=robh+dt@kernel.org \
    --cc=xbl@rock-chips.com \
    --cc=yannick.fertre@st.com \
    --cc=zyw@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.