From: Fam Zheng <famz@redhat.com>
To: Shravan Rajinikanth <shravan2x@utexas.edu>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] qemu-img: Fixed grammatical error in dump_human_image_check
Date: Mon, 4 Dec 2017 23:44:36 +0800 [thread overview]
Message-ID: <20171204154436.GC10628@lemon> (raw)
In-Reply-To: <1512254273-7567-1-git-send-email-shravan2x@utexas.edu>
On Sat, 12/02 14:37, Shravan Rajinikanth wrote:
> Signed-off-by: Shravan Rajinikanth <shravan2x@utexas.edu>
> ---
> qemu-img.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qemu-img.c b/qemu-img.c
> index 68b375f..bea9268 100644
> --- a/qemu-img.c
> +++ b/qemu-img.c
> @@ -580,7 +580,7 @@ static void dump_human_image_check(ImageCheck *check, bool quiet)
> if (check->leaks) {
> qprintf(quiet,
> "\n%" PRId64 " leaked clusters were found on the image.\n"
> - "This means waste of disk space, but no harm to data.\n",
> + "This means disk space is wasted, but data is safe.\n",
To me both versions seem fine, could you explain the grammatical error in the
old message?
Fam
> check->leaks);
> }
>
> --
> 2.7.4
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Fam Zheng <famz@redhat.com>
To: Shravan Rajinikanth <shravan2x@utexas.edu>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qemu-img: Fixed grammatical error in dump_human_image_check
Date: Mon, 4 Dec 2017 23:44:36 +0800 [thread overview]
Message-ID: <20171204154436.GC10628@lemon> (raw)
In-Reply-To: <1512254273-7567-1-git-send-email-shravan2x@utexas.edu>
On Sat, 12/02 14:37, Shravan Rajinikanth wrote:
> Signed-off-by: Shravan Rajinikanth <shravan2x@utexas.edu>
> ---
> qemu-img.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qemu-img.c b/qemu-img.c
> index 68b375f..bea9268 100644
> --- a/qemu-img.c
> +++ b/qemu-img.c
> @@ -580,7 +580,7 @@ static void dump_human_image_check(ImageCheck *check, bool quiet)
> if (check->leaks) {
> qprintf(quiet,
> "\n%" PRId64 " leaked clusters were found on the image.\n"
> - "This means waste of disk space, but no harm to data.\n",
> + "This means disk space is wasted, but data is safe.\n",
To me both versions seem fine, could you explain the grammatical error in the
old message?
Fam
> check->leaks);
> }
>
> --
> 2.7.4
>
>
next prev parent reply other threads:[~2017-12-04 15:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-02 22:37 [Qemu-trivial] [PATCH] qemu-img: Fixed grammatical error in dump_human_image_check Shravan Rajinikanth
2017-12-02 22:37 ` [Qemu-devel] " Shravan Rajinikanth
2017-12-04 15:44 ` Fam Zheng [this message]
2017-12-04 15:44 ` Fam Zheng
2017-12-04 15:51 ` [Qemu-trivial] " Max Reitz
2017-12-04 15:51 ` Max Reitz
2017-12-04 15:57 ` [Qemu-trivial] " Peter Maydell
2017-12-04 15:57 ` Peter Maydell
2017-12-04 20:44 ` [Qemu-trivial] " Shravan Rajinikanth
2017-12-04 20:44 ` Shravan Rajinikanth
2018-02-02 13:37 ` [Qemu-trivial] " Max Reitz
2018-02-02 13:37 ` Max Reitz
2018-02-02 15:36 ` [Qemu-trivial] " Max Reitz
2018-02-02 15:36 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171204154436.GC10628@lemon \
--to=famz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=shravan2x@utexas.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.