* [Qemu-devel] [PATCH] qemu-img: Fixed grammatical error in dump_human_image_check
@ 2017-12-02 22:37 ` Shravan Rajinikanth
0 siblings, 0 replies; 14+ messages in thread
From: Shravan Rajinikanth @ 2017-12-02 22:37 UTC (permalink / raw)
To: qemu-devel; +Cc: Shravan Rajinikanth, qemu-trivial
Signed-off-by: Shravan Rajinikanth <shravan2x@utexas.edu>
---
qemu-img.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qemu-img.c b/qemu-img.c
index 68b375f..bea9268 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -580,7 +580,7 @@ static void dump_human_image_check(ImageCheck *check, bool quiet)
if (check->leaks) {
qprintf(quiet,
"\n%" PRId64 " leaked clusters were found on the image.\n"
- "This means waste of disk space, but no harm to data.\n",
+ "This means disk space is wasted, but data is safe.\n",
check->leaks);
}
--
2.7.4
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [Qemu-trivial] [Qemu-devel] [PATCH] qemu-img: Fixed grammatical error in dump_human_image_check
2017-12-02 22:37 ` [Qemu-devel] " Shravan Rajinikanth
@ 2017-12-04 15:44 ` Fam Zheng
-1 siblings, 0 replies; 14+ messages in thread
From: Fam Zheng @ 2017-12-04 15:44 UTC (permalink / raw)
To: Shravan Rajinikanth; +Cc: qemu-devel, qemu-trivial
On Sat, 12/02 14:37, Shravan Rajinikanth wrote:
> Signed-off-by: Shravan Rajinikanth <shravan2x@utexas.edu>
> ---
> qemu-img.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qemu-img.c b/qemu-img.c
> index 68b375f..bea9268 100644
> --- a/qemu-img.c
> +++ b/qemu-img.c
> @@ -580,7 +580,7 @@ static void dump_human_image_check(ImageCheck *check, bool quiet)
> if (check->leaks) {
> qprintf(quiet,
> "\n%" PRId64 " leaked clusters were found on the image.\n"
> - "This means waste of disk space, but no harm to data.\n",
> + "This means disk space is wasted, but data is safe.\n",
To me both versions seem fine, could you explain the grammatical error in the
old message?
Fam
> check->leaks);
> }
>
> --
> 2.7.4
>
>
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [Qemu-devel] [PATCH] qemu-img: Fixed grammatical error in dump_human_image_check
@ 2017-12-04 15:44 ` Fam Zheng
0 siblings, 0 replies; 14+ messages in thread
From: Fam Zheng @ 2017-12-04 15:44 UTC (permalink / raw)
To: Shravan Rajinikanth; +Cc: qemu-devel, qemu-trivial
On Sat, 12/02 14:37, Shravan Rajinikanth wrote:
> Signed-off-by: Shravan Rajinikanth <shravan2x@utexas.edu>
> ---
> qemu-img.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qemu-img.c b/qemu-img.c
> index 68b375f..bea9268 100644
> --- a/qemu-img.c
> +++ b/qemu-img.c
> @@ -580,7 +580,7 @@ static void dump_human_image_check(ImageCheck *check, bool quiet)
> if (check->leaks) {
> qprintf(quiet,
> "\n%" PRId64 " leaked clusters were found on the image.\n"
> - "This means waste of disk space, but no harm to data.\n",
> + "This means disk space is wasted, but data is safe.\n",
To me both versions seem fine, could you explain the grammatical error in the
old message?
Fam
> check->leaks);
> }
>
> --
> 2.7.4
>
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH] qemu-img: Fixed grammatical error in dump_human_image_check
2017-12-02 22:37 ` [Qemu-devel] " Shravan Rajinikanth
@ 2017-12-04 15:51 ` Max Reitz
-1 siblings, 0 replies; 14+ messages in thread
From: Max Reitz @ 2017-12-04 15:51 UTC (permalink / raw)
To: Shravan Rajinikanth, qemu-devel; +Cc: qemu-trivial, Qemu-block
[-- Attachment #1.1: Type: text/plain, Size: 887 bytes --]
On 2017-12-02 23:37, Shravan Rajinikanth wrote:
> Signed-off-by: Shravan Rajinikanth <shravan2x@utexas.edu>
> ---
> qemu-img.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qemu-img.c b/qemu-img.c
> index 68b375f..bea9268 100644
> --- a/qemu-img.c
> +++ b/qemu-img.c
> @@ -580,7 +580,7 @@ static void dump_human_image_check(ImageCheck *check, bool quiet)
> if (check->leaks) {
> qprintf(quiet,
> "\n%" PRId64 " leaked clusters were found on the image.\n"
> - "This means waste of disk space, but no harm to data.\n",
> + "This means disk space is wasted, but data is safe.\n",
> check->leaks);
> }
How exactly is this a grammatical error? (I'm not a native English
speaker, but it always seemed perfectly OK to me)
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 512 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [Qemu-devel] [PATCH] qemu-img: Fixed grammatical error in dump_human_image_check
@ 2017-12-04 15:51 ` Max Reitz
0 siblings, 0 replies; 14+ messages in thread
From: Max Reitz @ 2017-12-04 15:51 UTC (permalink / raw)
To: Shravan Rajinikanth, qemu-devel; +Cc: qemu-trivial, Qemu-block
[-- Attachment #1: Type: text/plain, Size: 887 bytes --]
On 2017-12-02 23:37, Shravan Rajinikanth wrote:
> Signed-off-by: Shravan Rajinikanth <shravan2x@utexas.edu>
> ---
> qemu-img.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qemu-img.c b/qemu-img.c
> index 68b375f..bea9268 100644
> --- a/qemu-img.c
> +++ b/qemu-img.c
> @@ -580,7 +580,7 @@ static void dump_human_image_check(ImageCheck *check, bool quiet)
> if (check->leaks) {
> qprintf(quiet,
> "\n%" PRId64 " leaked clusters were found on the image.\n"
> - "This means waste of disk space, but no harm to data.\n",
> + "This means disk space is wasted, but data is safe.\n",
> check->leaks);
> }
How exactly is this a grammatical error? (I'm not a native English
speaker, but it always seemed perfectly OK to me)
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 512 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [Qemu-trivial] [Qemu-devel] [PATCH] qemu-img: Fixed grammatical error in dump_human_image_check
2017-12-04 15:51 ` Max Reitz
@ 2017-12-04 15:57 ` Peter Maydell
-1 siblings, 0 replies; 14+ messages in thread
From: Peter Maydell @ 2017-12-04 15:57 UTC (permalink / raw)
To: Max Reitz; +Cc: Shravan Rajinikanth, QEMU Developers, QEMU Trivial, Qemu-block
On 4 December 2017 at 15:51, Max Reitz <mreitz@redhat.com> wrote:
> On 2017-12-02 23:37, Shravan Rajinikanth wrote:
>> Signed-off-by: Shravan Rajinikanth <shravan2x@utexas.edu>
>> ---
>> qemu-img.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/qemu-img.c b/qemu-img.c
>> index 68b375f..bea9268 100644
>> --- a/qemu-img.c
>> +++ b/qemu-img.c
>> @@ -580,7 +580,7 @@ static void dump_human_image_check(ImageCheck *check, bool quiet)
>> if (check->leaks) {
>> qprintf(quiet,
>> "\n%" PRId64 " leaked clusters were found on the image.\n"
>> - "This means waste of disk space, but no harm to data.\n",
>> + "This means disk space is wasted, but data is safe.\n",
>> check->leaks);
>> }
>
> How exactly is this a grammatical error? (I'm not a native English
> speaker, but it always seemed perfectly OK to me)
I think "This means" more naturally takes a verb phrase, not a noun phrase.
I don't know that I'd go so far as to say that the current text is
ungrammatical, but I do think the proposed change sounds more natural to me.
thanks
-- PMM
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [Qemu-devel] [PATCH] qemu-img: Fixed grammatical error in dump_human_image_check
@ 2017-12-04 15:57 ` Peter Maydell
0 siblings, 0 replies; 14+ messages in thread
From: Peter Maydell @ 2017-12-04 15:57 UTC (permalink / raw)
To: Max Reitz; +Cc: Shravan Rajinikanth, QEMU Developers, QEMU Trivial, Qemu-block
On 4 December 2017 at 15:51, Max Reitz <mreitz@redhat.com> wrote:
> On 2017-12-02 23:37, Shravan Rajinikanth wrote:
>> Signed-off-by: Shravan Rajinikanth <shravan2x@utexas.edu>
>> ---
>> qemu-img.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/qemu-img.c b/qemu-img.c
>> index 68b375f..bea9268 100644
>> --- a/qemu-img.c
>> +++ b/qemu-img.c
>> @@ -580,7 +580,7 @@ static void dump_human_image_check(ImageCheck *check, bool quiet)
>> if (check->leaks) {
>> qprintf(quiet,
>> "\n%" PRId64 " leaked clusters were found on the image.\n"
>> - "This means waste of disk space, but no harm to data.\n",
>> + "This means disk space is wasted, but data is safe.\n",
>> check->leaks);
>> }
>
> How exactly is this a grammatical error? (I'm not a native English
> speaker, but it always seemed perfectly OK to me)
I think "This means" more naturally takes a verb phrase, not a noun phrase.
I don't know that I'd go so far as to say that the current text is
ungrammatical, but I do think the proposed change sounds more natural to me.
thanks
-- PMM
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [Qemu-trivial] [Qemu-devel] [PATCH] qemu-img: Fixed grammatical error in dump_human_image_check
2017-12-04 15:57 ` Peter Maydell
@ 2017-12-04 20:44 ` Shravan Rajinikanth
-1 siblings, 0 replies; 14+ messages in thread
From: Shravan Rajinikanth @ 2017-12-04 20:44 UTC (permalink / raw)
To: Peter Maydell; +Cc: Max Reitz, QEMU Developers, QEMU Trivial, Qemu-block
[-- Attachment #1: Type: text/plain, Size: 2170 bytes --]
> To me both versions seem fine, could you explain the grammatical error in
the
> old message?
My opinion aligns with Peter's, in that "This means" followed by "waste of"
is a break in the sentence to a reader. Adding an "a" to change it to "This
means a waste of" also seemed like a possible fix, but I made a call to
change it "This means disk space is wasted" instead. This is mainly because
the first sentence says leaked clusters "were found", which following the
same tense in the next sentence should rather be "is wasted" (since the
scan was only run once in the past, but disk space continues to be wasted
even after the message is displayed).
I'm no expert in the English language myself, so perhaps I was wrong in
calling it a grammatical error. However, I do find the changed version more
natural to read.
Regards,
Shravan
On Mon, Dec 4, 2017 at 9:57 AM, Peter Maydell <peter.maydell@linaro.org>
wrote:
> On 4 December 2017 at 15:51, Max Reitz <mreitz@redhat.com> wrote:
> > On 2017-12-02 23:37, Shravan Rajinikanth wrote:
> >> Signed-off-by: Shravan Rajinikanth <shravan2x@utexas.edu>
> >> ---
> >> qemu-img.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/qemu-img.c b/qemu-img.c
> >> index 68b375f..bea9268 100644
> >> --- a/qemu-img.c
> >> +++ b/qemu-img.c
> >> @@ -580,7 +580,7 @@ static void dump_human_image_check(ImageCheck
> *check, bool quiet)
> >> if (check->leaks) {
> >> qprintf(quiet,
> >> "\n%" PRId64 " leaked clusters were found on the
> image.\n"
> >> - "This means waste of disk space, but no harm to
> data.\n",
> >> + "This means disk space is wasted, but data is
> safe.\n",
> >> check->leaks);
> >> }
> >
> > How exactly is this a grammatical error? (I'm not a native English
> > speaker, but it always seemed perfectly OK to me)
>
> I think "This means" more naturally takes a verb phrase, not a noun phrase.
> I don't know that I'd go so far as to say that the current text is
> ungrammatical, but I do think the proposed change sounds more natural to
> me.
>
> thanks
> -- PMM
>
[-- Attachment #2: Type: text/html, Size: 3318 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [Qemu-devel] [PATCH] qemu-img: Fixed grammatical error in dump_human_image_check
@ 2017-12-04 20:44 ` Shravan Rajinikanth
0 siblings, 0 replies; 14+ messages in thread
From: Shravan Rajinikanth @ 2017-12-04 20:44 UTC (permalink / raw)
To: Peter Maydell; +Cc: Max Reitz, QEMU Developers, QEMU Trivial, Qemu-block
> To me both versions seem fine, could you explain the grammatical error in
the
> old message?
My opinion aligns with Peter's, in that "This means" followed by "waste of"
is a break in the sentence to a reader. Adding an "a" to change it to "This
means a waste of" also seemed like a possible fix, but I made a call to
change it "This means disk space is wasted" instead. This is mainly because
the first sentence says leaked clusters "were found", which following the
same tense in the next sentence should rather be "is wasted" (since the
scan was only run once in the past, but disk space continues to be wasted
even after the message is displayed).
I'm no expert in the English language myself, so perhaps I was wrong in
calling it a grammatical error. However, I do find the changed version more
natural to read.
Regards,
Shravan
On Mon, Dec 4, 2017 at 9:57 AM, Peter Maydell <peter.maydell@linaro.org>
wrote:
> On 4 December 2017 at 15:51, Max Reitz <mreitz@redhat.com> wrote:
> > On 2017-12-02 23:37, Shravan Rajinikanth wrote:
> >> Signed-off-by: Shravan Rajinikanth <shravan2x@utexas.edu>
> >> ---
> >> qemu-img.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/qemu-img.c b/qemu-img.c
> >> index 68b375f..bea9268 100644
> >> --- a/qemu-img.c
> >> +++ b/qemu-img.c
> >> @@ -580,7 +580,7 @@ static void dump_human_image_check(ImageCheck
> *check, bool quiet)
> >> if (check->leaks) {
> >> qprintf(quiet,
> >> "\n%" PRId64 " leaked clusters were found on the
> image.\n"
> >> - "This means waste of disk space, but no harm to
> data.\n",
> >> + "This means disk space is wasted, but data is
> safe.\n",
> >> check->leaks);
> >> }
> >
> > How exactly is this a grammatical error? (I'm not a native English
> > speaker, but it always seemed perfectly OK to me)
>
> I think "This means" more naturally takes a verb phrase, not a noun phrase.
> I don't know that I'd go so far as to say that the current text is
> ungrammatical, but I do think the proposed change sounds more natural to
> me.
>
> thanks
> -- PMM
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH] qemu-img: Fixed grammatical error in dump_human_image_check
2017-12-02 22:37 ` [Qemu-devel] " Shravan Rajinikanth
@ 2018-02-02 13:37 ` Max Reitz
-1 siblings, 0 replies; 14+ messages in thread
From: Max Reitz @ 2018-02-02 13:37 UTC (permalink / raw)
To: Shravan Rajinikanth, qemu-devel; +Cc: qemu-trivial
[-- Attachment #1.1: Type: text/plain, Size: 934 bytes --]
On 2017-12-02 23:37, Shravan Rajinikanth wrote:
> Signed-off-by: Shravan Rajinikanth <shravan2x@utexas.edu>
> ---
> qemu-img.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qemu-img.c b/qemu-img.c
> index 68b375f..bea9268 100644
> --- a/qemu-img.c
> +++ b/qemu-img.c
> @@ -580,7 +580,7 @@ static void dump_human_image_check(ImageCheck *check, bool quiet)
> if (check->leaks) {
> qprintf(quiet,
> "\n%" PRId64 " leaked clusters were found on the image.\n"
> - "This means waste of disk space, but no harm to data.\n",
> + "This means disk space is wasted, but data is safe.\n",
> check->leaks);
> }
Sorry, somehow I never applied this. (Maybe I thought it would go
through trivial...)
Applied to my block tree:
https://github.com/XanClic/qemu/commits/block
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 512 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [Qemu-devel] [PATCH] qemu-img: Fixed grammatical error in dump_human_image_check
@ 2018-02-02 13:37 ` Max Reitz
0 siblings, 0 replies; 14+ messages in thread
From: Max Reitz @ 2018-02-02 13:37 UTC (permalink / raw)
To: Shravan Rajinikanth, qemu-devel; +Cc: qemu-trivial
[-- Attachment #1: Type: text/plain, Size: 934 bytes --]
On 2017-12-02 23:37, Shravan Rajinikanth wrote:
> Signed-off-by: Shravan Rajinikanth <shravan2x@utexas.edu>
> ---
> qemu-img.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qemu-img.c b/qemu-img.c
> index 68b375f..bea9268 100644
> --- a/qemu-img.c
> +++ b/qemu-img.c
> @@ -580,7 +580,7 @@ static void dump_human_image_check(ImageCheck *check, bool quiet)
> if (check->leaks) {
> qprintf(quiet,
> "\n%" PRId64 " leaked clusters were found on the image.\n"
> - "This means waste of disk space, but no harm to data.\n",
> + "This means disk space is wasted, but data is safe.\n",
> check->leaks);
> }
Sorry, somehow I never applied this. (Maybe I thought it would go
through trivial...)
Applied to my block tree:
https://github.com/XanClic/qemu/commits/block
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 512 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [Qemu-trivial] [Qemu-devel] [PATCH] qemu-img: Fixed grammatical error in dump_human_image_check
2018-02-02 13:37 ` Max Reitz
@ 2018-02-02 15:36 ` Max Reitz
-1 siblings, 0 replies; 14+ messages in thread
From: Max Reitz @ 2018-02-02 15:36 UTC (permalink / raw)
To: Shravan Rajinikanth, qemu-devel; +Cc: qemu-trivial
[-- Attachment #1.1: Type: text/plain, Size: 1098 bytes --]
On 2018-02-02 14:37, Max Reitz wrote:
> On 2017-12-02 23:37, Shravan Rajinikanth wrote:
>> Signed-off-by: Shravan Rajinikanth <shravan2x@utexas.edu>
>> ---
>> qemu-img.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/qemu-img.c b/qemu-img.c
>> index 68b375f..bea9268 100644
>> --- a/qemu-img.c
>> +++ b/qemu-img.c
>> @@ -580,7 +580,7 @@ static void dump_human_image_check(ImageCheck *check, bool quiet)
>> if (check->leaks) {
>> qprintf(quiet,
>> "\n%" PRId64 " leaked clusters were found on the image.\n"
>> - "This means waste of disk space, but no harm to data.\n",
>> + "This means disk space is wasted, but data is safe.\n",
>> check->leaks);
>> }
>
> Sorry, somehow I never applied this. (Maybe I thought it would go
> through trivial...)
>
> Applied to my block tree:
>
> https://github.com/XanClic/qemu/commits/block
I'll have to unstage it again because it breaks some iotests (026, 060,
and 112), sorry.
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 512 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [Qemu-devel] [PATCH] qemu-img: Fixed grammatical error in dump_human_image_check
@ 2018-02-02 15:36 ` Max Reitz
0 siblings, 0 replies; 14+ messages in thread
From: Max Reitz @ 2018-02-02 15:36 UTC (permalink / raw)
To: Shravan Rajinikanth, qemu-devel; +Cc: qemu-trivial
[-- Attachment #1: Type: text/plain, Size: 1098 bytes --]
On 2018-02-02 14:37, Max Reitz wrote:
> On 2017-12-02 23:37, Shravan Rajinikanth wrote:
>> Signed-off-by: Shravan Rajinikanth <shravan2x@utexas.edu>
>> ---
>> qemu-img.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/qemu-img.c b/qemu-img.c
>> index 68b375f..bea9268 100644
>> --- a/qemu-img.c
>> +++ b/qemu-img.c
>> @@ -580,7 +580,7 @@ static void dump_human_image_check(ImageCheck *check, bool quiet)
>> if (check->leaks) {
>> qprintf(quiet,
>> "\n%" PRId64 " leaked clusters were found on the image.\n"
>> - "This means waste of disk space, but no harm to data.\n",
>> + "This means disk space is wasted, but data is safe.\n",
>> check->leaks);
>> }
>
> Sorry, somehow I never applied this. (Maybe I thought it would go
> through trivial...)
>
> Applied to my block tree:
>
> https://github.com/XanClic/qemu/commits/block
I'll have to unstage it again because it breaks some iotests (026, 060,
and 112), sorry.
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 512 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread