From: "Bruno E. O. Meneguele" <brdeoliv@redhat.com>
To: "Bruno E. O. Meneguele" <bmeneguele@gmail.com>
Cc: Mimi Zohar <zohar@linux.vnet.ibm.com>,
Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
linux-integrity@vger.kernel.org,
linux-ima-devel@lists.sourceforge.net,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ima: log message to module appraisal error
Date: Mon, 4 Dec 2017 18:17:25 -0200 [thread overview]
Message-ID: <20171204201725.GA17252@glitch> (raw)
In-Reply-To: <20171204195456.17193-1-bmeneguele@gmail.com>
[-- Attachment #1: Type: multipart/signed, Size: 1708 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: "Bruno E. O. Meneguele" <brdeoliv@redhat.com>
To: "Bruno E. O. Meneguele" <bmeneguele@gmail.com>
Cc: Mimi Zohar <zohar@linux.vnet.ibm.com>,
Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
linux-integrity@vger.kernel.org,
linux-ima-devel@lists.sourceforge.net,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ima: log message to module appraisal error
Date: Mon, 4 Dec 2017 18:17:25 -0200 [thread overview]
Message-ID: <20171204201725.GA17252@glitch> (raw)
In-Reply-To: <20171204195456.17193-1-bmeneguele@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1638 bytes --]
On 04-12, Bruno E. O. Meneguele wrote:
> Simple but useful message log to the user in case of module appraise is
> forced and fails due to the lack of file descriptor, that might be
> caused by kmod calls to compressed modules.
>
> Signed-off-by: Bruno E. O. Meneguele <bmeneguele@gmail.com>
> ---
Oh sorry, I sent through my personal email configuration! Sorry for
that.
Self NACK here, I'll repost a v2 with the correct signed-off and From
fields.
Thanks!
> security/integrity/ima/ima_main.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/security/integrity/ima/ima_main.c b/security/integrity/ima/ima_main.c
> index 770654694efc..95ec39910058 100644
> --- a/security/integrity/ima/ima_main.c
> +++ b/security/integrity/ima/ima_main.c
> @@ -366,8 +366,12 @@ int ima_read_file(struct file *file, enum kernel_read_file_id read_id)
>
> if (!file && read_id == READING_MODULE) {
> if (!sig_enforce && (ima_appraise & IMA_APPRAISE_MODULES) &&
> - (ima_appraise & IMA_APPRAISE_ENFORCE))
> + (ima_appraise & IMA_APPRAISE_ENFORCE)) {
> + pr_err("impossible to appraise a module without a file \
> + descriptor. sig_enforce kernel parameter might \
> + help\n");
> return -EACCES; /* INTEGRITY_UNKNOWN */
> + }
> return 0; /* We rely on module signature checking */
> }
> return 0;
> --
> 2.14.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2017-12-04 20:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-04 19:54 [PATCH] ima: log message to module appraisal error Bruno E. O. Meneguele
2017-12-04 19:54 ` Bruno E. O. Meneguele
2017-12-04 20:17 ` Bruno E. O. Meneguele [this message]
2017-12-04 20:17 ` Bruno E. O. Meneguele
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171204201725.GA17252@glitch \
--to=brdeoliv@redhat.com \
--cc=bmeneguele@gmail.com \
--cc=dmitry.kasatkin@gmail.com \
--cc=linux-ima-devel@lists.sourceforge.net \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.