* [PATCH] ima: log message to module appraisal error
@ 2017-12-04 19:54 ` Bruno E. O. Meneguele
0 siblings, 0 replies; 4+ messages in thread
From: Bruno E. O. Meneguele @ 2017-12-04 19:54 UTC (permalink / raw)
To: Mimi Zohar, Dmitry Kasatkin
Cc: linux-integrity, linux-ima-devel, linux-security-module,
linux-kernel
Simple but useful message log to the user in case of module appraise is
forced and fails due to the lack of file descriptor, that might be
caused by kmod calls to compressed modules.
Signed-off-by: Bruno E. O. Meneguele <bmeneguele@gmail.com>
---
security/integrity/ima/ima_main.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/security/integrity/ima/ima_main.c b/security/integrity/ima/ima_main.c
index 770654694efc..95ec39910058 100644
--- a/security/integrity/ima/ima_main.c
+++ b/security/integrity/ima/ima_main.c
@@ -366,8 +366,12 @@ int ima_read_file(struct file *file, enum kernel_read_file_id read_id)
if (!file && read_id == READING_MODULE) {
if (!sig_enforce && (ima_appraise & IMA_APPRAISE_MODULES) &&
- (ima_appraise & IMA_APPRAISE_ENFORCE))
+ (ima_appraise & IMA_APPRAISE_ENFORCE)) {
+ pr_err("impossible to appraise a module without a file \
+ descriptor. sig_enforce kernel parameter might \
+ help\n");
return -EACCES; /* INTEGRITY_UNKNOWN */
+ }
return 0; /* We rely on module signature checking */
}
return 0;
--
2.14.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] ima: log message to module appraisal error
@ 2017-12-04 19:54 ` Bruno E. O. Meneguele
0 siblings, 0 replies; 4+ messages in thread
From: Bruno E. O. Meneguele @ 2017-12-04 19:54 UTC (permalink / raw)
To: linux-security-module
Simple but useful message log to the user in case of module appraise is
forced and fails due to the lack of file descriptor, that might be
caused by kmod calls to compressed modules.
Signed-off-by: Bruno E. O. Meneguele <bmeneguele@gmail.com>
---
security/integrity/ima/ima_main.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/security/integrity/ima/ima_main.c b/security/integrity/ima/ima_main.c
index 770654694efc..95ec39910058 100644
--- a/security/integrity/ima/ima_main.c
+++ b/security/integrity/ima/ima_main.c
@@ -366,8 +366,12 @@ int ima_read_file(struct file *file, enum kernel_read_file_id read_id)
if (!file && read_id == READING_MODULE) {
if (!sig_enforce && (ima_appraise & IMA_APPRAISE_MODULES) &&
- (ima_appraise & IMA_APPRAISE_ENFORCE))
+ (ima_appraise & IMA_APPRAISE_ENFORCE)) {
+ pr_err("impossible to appraise a module without a file \
+ descriptor. sig_enforce kernel parameter might \
+ help\n");
return -EACCES; /* INTEGRITY_UNKNOWN */
+ }
return 0; /* We rely on module signature checking */
}
return 0;
--
2.14.3
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ima: log message to module appraisal error
2017-12-04 19:54 ` Bruno E. O. Meneguele
@ 2017-12-04 20:17 ` Bruno E. O. Meneguele
-1 siblings, 0 replies; 4+ messages in thread
From: Bruno E. O. Meneguele @ 2017-12-04 20:17 UTC (permalink / raw)
To: Bruno E. O. Meneguele
Cc: Mimi Zohar, Dmitry Kasatkin, linux-integrity, linux-ima-devel,
linux-security-module, linux-kernel
[-- Attachment #1: Type: multipart/signed, Size: 1708 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ima: log message to module appraisal error
@ 2017-12-04 20:17 ` Bruno E. O. Meneguele
0 siblings, 0 replies; 4+ messages in thread
From: Bruno E. O. Meneguele @ 2017-12-04 20:17 UTC (permalink / raw)
To: Bruno E. O. Meneguele
Cc: Mimi Zohar, Dmitry Kasatkin, linux-integrity, linux-ima-devel,
linux-security-module, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1638 bytes --]
On 04-12, Bruno E. O. Meneguele wrote:
> Simple but useful message log to the user in case of module appraise is
> forced and fails due to the lack of file descriptor, that might be
> caused by kmod calls to compressed modules.
>
> Signed-off-by: Bruno E. O. Meneguele <bmeneguele@gmail.com>
> ---
Oh sorry, I sent through my personal email configuration! Sorry for
that.
Self NACK here, I'll repost a v2 with the correct signed-off and From
fields.
Thanks!
> security/integrity/ima/ima_main.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/security/integrity/ima/ima_main.c b/security/integrity/ima/ima_main.c
> index 770654694efc..95ec39910058 100644
> --- a/security/integrity/ima/ima_main.c
> +++ b/security/integrity/ima/ima_main.c
> @@ -366,8 +366,12 @@ int ima_read_file(struct file *file, enum kernel_read_file_id read_id)
>
> if (!file && read_id == READING_MODULE) {
> if (!sig_enforce && (ima_appraise & IMA_APPRAISE_MODULES) &&
> - (ima_appraise & IMA_APPRAISE_ENFORCE))
> + (ima_appraise & IMA_APPRAISE_ENFORCE)) {
> + pr_err("impossible to appraise a module without a file \
> + descriptor. sig_enforce kernel parameter might \
> + help\n");
> return -EACCES; /* INTEGRITY_UNKNOWN */
> + }
> return 0; /* We rely on module signature checking */
> }
> return 0;
> --
> 2.14.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-12-04 20:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-04 19:54 [PATCH] ima: log message to module appraisal error Bruno E. O. Meneguele
2017-12-04 19:54 ` Bruno E. O. Meneguele
2017-12-04 20:17 ` Bruno E. O. Meneguele
2017-12-04 20:17 ` Bruno E. O. Meneguele
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.