From: andrew@lunn.ch (Andrew Lunn)
To: linus-amlogic@lists.infradead.org
Subject: [RFC PATCH] net: stmmac: enable EEE in MII, GMII or RGMII only
Date: Tue, 5 Dec 2017 19:03:51 +0100 [thread overview]
Message-ID: <20171205180351.GT12805@lunn.ch> (raw)
In-Reply-To: <20171205102809.4347-1-jbrunet@baylibre.com>
> bool stmmac_eee_init(struct stmmac_priv *priv)
> {
> struct net_device *ndev = priv->dev;
> + int interface = priv->plat->interface;
> unsigned long flags;
> bool ret = false;
>
> + if ((interface != PHY_INTERFACE_MODE_MII) &&
> + (interface != PHY_INTERFACE_MODE_GMII) &&
> + (interface != PHY_INTERFACE_MODE_RGMII) &&
> + (interface != PHY_INTERFACE_MODE_RGMII_ID) &&
> + (interface != PHY_INTERFACE_MODE_RGMII_TXID) &&
> + (interface != PHY_INTERFACE_MODE_RGMII_RXID))
> + goto out;
phy_interface_mode_is_rgmii() will make this smaller.
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Jerome Brunet <jbrunet@baylibre.com>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
netdev@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] net: stmmac: enable EEE in MII, GMII or RGMII only
Date: Tue, 5 Dec 2017 19:03:51 +0100 [thread overview]
Message-ID: <20171205180351.GT12805@lunn.ch> (raw)
In-Reply-To: <20171205102809.4347-1-jbrunet@baylibre.com>
> bool stmmac_eee_init(struct stmmac_priv *priv)
> {
> struct net_device *ndev = priv->dev;
> + int interface = priv->plat->interface;
> unsigned long flags;
> bool ret = false;
>
> + if ((interface != PHY_INTERFACE_MODE_MII) &&
> + (interface != PHY_INTERFACE_MODE_GMII) &&
> + (interface != PHY_INTERFACE_MODE_RGMII) &&
> + (interface != PHY_INTERFACE_MODE_RGMII_ID) &&
> + (interface != PHY_INTERFACE_MODE_RGMII_TXID) &&
> + (interface != PHY_INTERFACE_MODE_RGMII_RXID))
> + goto out;
phy_interface_mode_is_rgmii() will make this smaller.
Andrew
next prev parent reply other threads:[~2017-12-05 18:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-05 10:28 [RFC PATCH] net: stmmac: enable EEE in MII, GMII or RGMII only Jerome Brunet
2017-12-05 10:28 ` Jerome Brunet
2017-12-05 18:03 ` Andrew Lunn [this message]
2017-12-05 18:03 ` Andrew Lunn
2017-12-14 12:41 ` Arnaud Patard (Rtp)
2017-12-14 12:41 ` Arnaud Patard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171205180351.GT12805@lunn.ch \
--to=andrew@lunn.ch \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.