All of lore.kernel.org
 help / color / mirror / Atom feed
From: arnaud.patard@rtp-net.org (Arnaud Patard (Rtp))
To: linus-amlogic@lists.infradead.org
Subject: [RFC PATCH] net: stmmac: enable EEE in MII, GMII or RGMII only
Date: Thu, 14 Dec 2017 13:41:11 +0100	[thread overview]
Message-ID: <87ind9fpnc.fsf@lechat.rtp-net.org> (raw)
In-Reply-To: <20171205102809.4347-1-jbrunet@baylibre.com> (Jerome Brunet's message of "Tue, 5 Dec 2017 11:28:09 +0100")

Jerome Brunet <jbrunet@baylibre.com> writes:

> Note in the databook - Section 4.4 - EEE :
> " The EEE feature is not supported when the MAC is configured to use the
> TBI, RTBI, SMII, RMII or SGMII single PHY interface. Even if the MAC
> supports multiple PHY interfaces, you should activate the EEE mode only
> when the MAC is operating with GMII, MII, or RGMII interface."
>
> Applying this restriction solves a stability issue observed on Amlogic
> gxl platforms operating with RMII interface and the internal PHY.

I was having the issue on my libretech AML-S905X-CC / potato board. With
this patch, I've not been able to trigger it at all. Without it and with
my test case, I was able to trigger the hang several times reliably.

Any hope to see this merged ?

>
> Fixes: 83bf79b6bb64 ("stmmac: disable at run-time the EEE if not supported")
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>

Tested-by: Arnaud Patard <arnaud.patard@rtp-net.org>

WARNING: multiple messages have this Message-ID (diff)
From: Arnaud Patard (Rtp) <arnaud.patard@rtp-net.org>
To: Jerome Brunet <jbrunet@baylibre.com>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>,
	Alexandre Torgue <alexandre.torgue@st.com>,
	netdev@vger.kernel.org, linux-amlogic@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] net: stmmac: enable EEE in MII, GMII or RGMII only
Date: Thu, 14 Dec 2017 13:41:11 +0100	[thread overview]
Message-ID: <87ind9fpnc.fsf@lechat.rtp-net.org> (raw)
In-Reply-To: <20171205102809.4347-1-jbrunet@baylibre.com> (Jerome Brunet's message of "Tue, 5 Dec 2017 11:28:09 +0100")

Jerome Brunet <jbrunet@baylibre.com> writes:

> Note in the databook - Section 4.4 - EEE :
> " The EEE feature is not supported when the MAC is configured to use the
> TBI, RTBI, SMII, RMII or SGMII single PHY interface. Even if the MAC
> supports multiple PHY interfaces, you should activate the EEE mode only
> when the MAC is operating with GMII, MII, or RGMII interface."
>
> Applying this restriction solves a stability issue observed on Amlogic
> gxl platforms operating with RMII interface and the internal PHY.

I was having the issue on my libretech AML-S905X-CC / potato board. With
this patch, I've not been able to trigger it at all. Without it and with
my test case, I was able to trigger the hang several times reliably.

Any hope to see this merged ?

>
> Fixes: 83bf79b6bb64 ("stmmac: disable at run-time the EEE if not supported")
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>

Tested-by: Arnaud Patard <arnaud.patard@rtp-net.org>

  parent reply	other threads:[~2017-12-14 12:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-05 10:28 [RFC PATCH] net: stmmac: enable EEE in MII, GMII or RGMII only Jerome Brunet
2017-12-05 10:28 ` Jerome Brunet
2017-12-05 18:03 ` Andrew Lunn
2017-12-05 18:03   ` Andrew Lunn
2017-12-14 12:41 ` Arnaud Patard (Rtp) [this message]
2017-12-14 12:41   ` Arnaud Patard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ind9fpnc.fsf@lechat.rtp-net.org \
    --to=arnaud.patard@rtp-net.org \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.