From: Thierry Reding <thierry.reding@gmail.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Felipe Balbi <balbi@kernel.org>,
Alan Stern <stern@rowland.harvard.edu>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
Peter Chen <Peter.Chen@nxp.com>,
linux-usb@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/2] usb: chipidea: tegra: Select Tegra's PHY in Kconfig
Date: Mon, 11 Dec 2017 11:04:00 +0100 [thread overview]
Message-ID: <20171211100400.GE10671@ulmo> (raw)
In-Reply-To: <d6b64530412955aba1284886b3f5f74e42d776da.1512947332.git.digetx@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 892 bytes --]
On Mon, Dec 11, 2017 at 02:10:00AM +0300, Dmitry Osipenko wrote:
> UDC driver won't probe without Tegra's PHY, hence select it in the
> Kconfig.
>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
> drivers/usb/chipidea/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/chipidea/Kconfig b/drivers/usb/chipidea/Kconfig
> index 785f0ed037f7..2ef3b27ea72b 100644
> --- a/drivers/usb/chipidea/Kconfig
> +++ b/drivers/usb/chipidea/Kconfig
> @@ -27,6 +27,7 @@ config USB_CHIPIDEA_PCI
> config USB_CHIPIDEA_UDC
> bool "ChipIdea device controller"
> depends on USB_GADGET
> + select USB_TEGRA_PHY if ARCH_TEGRA
This is kind of pointless given that USB_TEGRA_PHY originally was
automatically enabled if ARCH_TEGRA was enabled.
What do we gain by these two patches, other than maybe make the driver
buildable as a module?
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Felipe Balbi <balbi@kernel.org>,
Alan Stern <stern@rowland.harvard.edu>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
Peter Chen <Peter.Chen@nxp.com>,
linux-usb@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [v1,2/2] usb: chipidea: tegra: Select Tegra's PHY in Kconfig
Date: Mon, 11 Dec 2017 11:04:00 +0100 [thread overview]
Message-ID: <20171211100400.GE10671@ulmo> (raw)
On Mon, Dec 11, 2017 at 02:10:00AM +0300, Dmitry Osipenko wrote:
> UDC driver won't probe without Tegra's PHY, hence select it in the
> Kconfig.
>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
> drivers/usb/chipidea/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/chipidea/Kconfig b/drivers/usb/chipidea/Kconfig
> index 785f0ed037f7..2ef3b27ea72b 100644
> --- a/drivers/usb/chipidea/Kconfig
> +++ b/drivers/usb/chipidea/Kconfig
> @@ -27,6 +27,7 @@ config USB_CHIPIDEA_PCI
> config USB_CHIPIDEA_UDC
> bool "ChipIdea device controller"
> depends on USB_GADGET
> + select USB_TEGRA_PHY if ARCH_TEGRA
This is kind of pointless given that USB_TEGRA_PHY originally was
automatically enabled if ARCH_TEGRA was enabled.
What do we gain by these two patches, other than maybe make the driver
buildable as a module?
Thierry
next prev parent reply other threads:[~2017-12-11 10:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-10 23:09 [PATCH v1 1/2] usb: phy: Add Kconfig entry for Tegra's PHY driver Dmitry Osipenko
2017-12-10 23:09 ` Dmitry Osipenko
2017-12-10 23:09 ` [v1,1/2] " Dmitry Osipenko
[not found] ` <b820f290730e57c999c211e5f82cf833755c299f.1512947332.git.digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-12-10 23:10 ` [PATCH v1 2/2] usb: chipidea: tegra: Select Tegra's PHY in Kconfig Dmitry Osipenko
2017-12-10 23:10 ` Dmitry Osipenko
2017-12-10 23:10 ` [v1,2/2] " Dmitry Osipenko
2017-12-11 10:04 ` Thierry Reding [this message]
2017-12-11 10:04 ` Thierry Reding
2017-12-11 13:09 ` [PATCH v1 2/2] " Dmitry Osipenko
2017-12-11 13:09 ` Dmitry Osipenko
2017-12-11 13:09 ` [v1,2/2] " Dmitry Osipenko
[not found] ` <6dddb581-e708-b96e-cf56-f3bf106117e2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-12-12 2:54 ` [PATCH v1 2/2] " Peter Chen
2017-12-12 2:54 ` Peter Chen
2017-12-12 2:54 ` [v1,2/2] " Peter Chen
2017-12-12 11:39 ` [PATCH v1 2/2] " Dmitry Osipenko
2017-12-12 11:39 ` [v1,2/2] " Dmitry Osipenko
2017-12-11 10:02 ` [PATCH v1 1/2] usb: phy: Add Kconfig entry for Tegra's PHY driver Thierry Reding
2017-12-11 10:02 ` Thierry Reding
2017-12-11 10:02 ` [v1,1/2] " Thierry Reding
2017-12-11 13:03 ` [PATCH v1 1/2] " Dmitry Osipenko
2017-12-11 13:03 ` Dmitry Osipenko
2017-12-11 13:03 ` [v1,1/2] " Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171211100400.GE10671@ulmo \
--to=thierry.reding@gmail.com \
--cc=Peter.Chen@nxp.com \
--cc=balbi@kernel.org \
--cc=digetx@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.