From: Vinod Koul <vinod.koul@intel.com>
To: venkat.prashanth2498@gmail.com, Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: dan.j.williams@intel.com, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [v1] DMA:omap-dma:Avoid build error by changing the function name
Date: Mon, 18 Dec 2017 10:59:25 +0530 [thread overview]
Message-ID: <20171218052925.GP18649@localhost> (raw)
On Tue, Dec 12, 2017 at 12:58:41PM +0530, venkat.prashanth2498@gmail.com wrote:
> From: Venkat Prashanth B U <venkat.prashanth2498@gmail.com>
>
> Change the name of the function omap_dma_filter_fn to avoid
> the following build error in linux kernel version 4.4 :
>
> drivers/dma/dma-omap.c:1273:6: error:
> redefinition of 'omap_dma_filter_fn'
Okay I do not see this error, which tree are you running?
In code is see omap_dma_filter_fn is used everywhere and no reference to
omap_dma_filter_func
Adding peter too..
>
> Signed-off-by: Venkat Prashanth B U <venkat.prashanth2498@gmail.com>
> Changes for v1:
> - Edited subject and description of the patch to fit with the change
> done in the code base, as suggested by Vinod Koul.
>
> - In order to avoid issues like backporting on stable the
> checkpatch.pl issues are dropped as suggested by Vinod Koul.
> ---
> drivers/dma/omap-dma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/omap-dma.c b/drivers/dma/omap-dma.c
> index 1dfc71c..8545dda 100644
> --- a/drivers/dma/omap-dma.c
> +++ b/drivers/dma/omap-dma.c
> @@ -1269,7 +1269,7 @@ static struct platform_driver omap_dma_driver = {
> },
> };
>
> -bool omap_dma_filter_fn(struct dma_chan *chan, void *param)
> +bool omap_dma_filter_func(struct dma_chan *chan, void *param)
> {
> if (chan->device->dev->driver == &omap_dma_driver.driver) {
> struct omap_dmadev *od = to_omap_dma_dev(chan->device);
> --
> 1.9.1
> --
> To unsubscribe from this list: send the line "unsubscribe dmaengine" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vinod.koul@intel.com>
To: venkat.prashanth2498@gmail.com, Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: dan.j.williams@intel.com, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] DMA:omap-dma:Avoid build error by changing the function name
Date: Mon, 18 Dec 2017 10:59:25 +0530 [thread overview]
Message-ID: <20171218052925.GP18649@localhost> (raw)
In-Reply-To: <1513063721-13688-1-git-send-email-venkat.prashanth2498@gmail.com>
On Tue, Dec 12, 2017 at 12:58:41PM +0530, venkat.prashanth2498@gmail.com wrote:
> From: Venkat Prashanth B U <venkat.prashanth2498@gmail.com>
>
> Change the name of the function omap_dma_filter_fn to avoid
> the following build error in linux kernel version 4.4 :
>
> drivers/dma/dma-omap.c:1273:6: error:
> redefinition of 'omap_dma_filter_fn'
Okay I do not see this error, which tree are you running?
In code is see omap_dma_filter_fn is used everywhere and no reference to
omap_dma_filter_func
Adding peter too..
>
> Signed-off-by: Venkat Prashanth B U <venkat.prashanth2498@gmail.com>
> Changes for v1:
> - Edited subject and description of the patch to fit with the change
> done in the code base, as suggested by Vinod Koul.
>
> - In order to avoid issues like backporting on stable the
> checkpatch.pl issues are dropped as suggested by Vinod Koul.
> ---
> drivers/dma/omap-dma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/omap-dma.c b/drivers/dma/omap-dma.c
> index 1dfc71c..8545dda 100644
> --- a/drivers/dma/omap-dma.c
> +++ b/drivers/dma/omap-dma.c
> @@ -1269,7 +1269,7 @@ static struct platform_driver omap_dma_driver = {
> },
> };
>
> -bool omap_dma_filter_fn(struct dma_chan *chan, void *param)
> +bool omap_dma_filter_func(struct dma_chan *chan, void *param)
> {
> if (chan->device->dev->driver == &omap_dma_driver.driver) {
> struct omap_dmadev *od = to_omap_dma_dev(chan->device);
> --
> 1.9.1
> --
> To unsubscribe from this list: send the line "unsubscribe dmaengine" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
~Vinod
next reply other threads:[~2017-12-18 5:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-18 5:29 Vinod Koul [this message]
2017-12-18 5:29 ` [PATCH v1] DMA:omap-dma:Avoid build error by changing the function name Vinod Koul
-- strict thread matches above, loose matches on Subject: below --
2017-12-18 7:52 [v1] " Peter Ujfalusi
2017-12-18 7:52 ` [PATCH v1] " Peter Ujfalusi
2017-12-12 7:28 [v1] " venkat.prashanth2498
2017-12-12 7:28 ` [PATCH v1] " venkat.prashanth2498
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171218052925.GP18649@localhost \
--to=vinod.koul@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=venkat.prashanth2498@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.