From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Xin Long <lucien.xin@gmail.com>
Cc: network dev <netdev@vger.kernel.org>,
linux-sctp@vger.kernel.org, davem@davemloft.net,
Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [PATCH net] sctp: add SCTP_CID_RECONF conversion in sctp_cname
Date: Mon, 18 Dec 2017 13:08:10 +0000 [thread overview]
Message-ID: <20171218130810.GA6123@localhost.localdomain> (raw)
In-Reply-To: <ae9172b7dc432d6092ab2bc061a0cf322a3939b5.1513577597.git.lucien.xin@gmail.com>
On Mon, Dec 18, 2017 at 02:13:17PM +0800, Xin Long wrote:
> Whenever a new type of chunk is added, the corresp conversion in
> sctp_cname should be added. Otherwise, in some places, pr_debug
> will print it as "unknown chunk".
>
> Fixes: cc16f00f6529 ("sctp: add support for generating stream reconf ssn reset request chunk")
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Marcelo R. Leitner <marcelo.leitner@gmail.com>
...
> case SCTP_CID_AUTH:
> return "AUTH";
>
> + case SCTP_CID_RECONF:
> + return "RECONF";
> +
> default:
> break;
Now we also need idata and ifwdtsn in there too, btw.
Marcelo
WARNING: multiple messages have this Message-ID (diff)
From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Xin Long <lucien.xin@gmail.com>
Cc: network dev <netdev@vger.kernel.org>,
linux-sctp@vger.kernel.org, davem@davemloft.net,
Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [PATCH net] sctp: add SCTP_CID_RECONF conversion in sctp_cname
Date: Mon, 18 Dec 2017 11:08:10 -0200 [thread overview]
Message-ID: <20171218130810.GA6123@localhost.localdomain> (raw)
In-Reply-To: <ae9172b7dc432d6092ab2bc061a0cf322a3939b5.1513577597.git.lucien.xin@gmail.com>
On Mon, Dec 18, 2017 at 02:13:17PM +0800, Xin Long wrote:
> Whenever a new type of chunk is added, the corresp conversion in
> sctp_cname should be added. Otherwise, in some places, pr_debug
> will print it as "unknown chunk".
>
> Fixes: cc16f00f6529 ("sctp: add support for generating stream reconf ssn reset request chunk")
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Marcelo R. Leitner <marcelo.leitner@gmail.com>
...
> case SCTP_CID_AUTH:
> return "AUTH";
>
> + case SCTP_CID_RECONF:
> + return "RECONF";
> +
> default:
> break;
Now we also need idata and ifwdtsn in there too, btw.
Marcelo
next prev parent reply other threads:[~2017-12-18 13:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-18 6:13 [PATCH net] sctp: add SCTP_CID_RECONF conversion in sctp_cname Xin Long
2017-12-18 6:13 ` Xin Long
2017-12-18 13:08 ` Marcelo Ricardo Leitner [this message]
2017-12-18 13:08 ` Marcelo Ricardo Leitner
2017-12-19 4:07 ` Xin Long
2017-12-19 4:07 ` Xin Long
2017-12-18 14:37 ` Neil Horman
2017-12-18 14:37 ` Neil Horman
2017-12-18 18:22 ` David Miller
2017-12-18 18:22 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171218130810.GA6123@localhost.localdomain \
--to=marcelo.leitner@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-sctp@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.