* [PATCH net] sctp: add SCTP_CID_RECONF conversion in sctp_cname
@ 2017-12-18 6:13 ` Xin Long
0 siblings, 0 replies; 10+ messages in thread
From: Xin Long @ 2017-12-18 6:13 UTC (permalink / raw)
To: network dev, linux-sctp; +Cc: davem, Marcelo Ricardo Leitner, Neil Horman
Whenever a new type of chunk is added, the corresp conversion in
sctp_cname should be added. Otherwise, in some places, pr_debug
will print it as "unknown chunk".
Fixes: cc16f00f6529 ("sctp: add support for generating stream reconf ssn reset request chunk")
Signed-off-by: Xin Long <lucien.xin@gmail.com>
---
net/sctp/debug.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/net/sctp/debug.c b/net/sctp/debug.c
index 3f619fd..291c97b 100644
--- a/net/sctp/debug.c
+++ b/net/sctp/debug.c
@@ -78,6 +78,9 @@ const char *sctp_cname(const union sctp_subtype cid)
case SCTP_CID_AUTH:
return "AUTH";
+ case SCTP_CID_RECONF:
+ return "RECONF";
+
default:
break;
}
--
2.1.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH net] sctp: add SCTP_CID_RECONF conversion in sctp_cname
2017-12-18 6:13 ` Xin Long
@ 2017-12-18 13:08 ` Marcelo Ricardo Leitner
-1 siblings, 0 replies; 10+ messages in thread
From: Marcelo Ricardo Leitner @ 2017-12-18 13:08 UTC (permalink / raw)
To: Xin Long; +Cc: network dev, linux-sctp, davem, Neil Horman
On Mon, Dec 18, 2017 at 02:13:17PM +0800, Xin Long wrote:
> Whenever a new type of chunk is added, the corresp conversion in
> sctp_cname should be added. Otherwise, in some places, pr_debug
> will print it as "unknown chunk".
>
> Fixes: cc16f00f6529 ("sctp: add support for generating stream reconf ssn reset request chunk")
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Marcelo R. Leitner <marcelo.leitner@gmail.com>
...
> case SCTP_CID_AUTH:
> return "AUTH";
>
> + case SCTP_CID_RECONF:
> + return "RECONF";
> +
> default:
> break;
Now we also need idata and ifwdtsn in there too, btw.
Marcelo
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH net] sctp: add SCTP_CID_RECONF conversion in sctp_cname
@ 2017-12-18 13:08 ` Marcelo Ricardo Leitner
0 siblings, 0 replies; 10+ messages in thread
From: Marcelo Ricardo Leitner @ 2017-12-18 13:08 UTC (permalink / raw)
To: Xin Long; +Cc: network dev, linux-sctp, davem, Neil Horman
On Mon, Dec 18, 2017 at 02:13:17PM +0800, Xin Long wrote:
> Whenever a new type of chunk is added, the corresp conversion in
> sctp_cname should be added. Otherwise, in some places, pr_debug
> will print it as "unknown chunk".
>
> Fixes: cc16f00f6529 ("sctp: add support for generating stream reconf ssn reset request chunk")
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Marcelo R. Leitner <marcelo.leitner@gmail.com>
...
> case SCTP_CID_AUTH:
> return "AUTH";
>
> + case SCTP_CID_RECONF:
> + return "RECONF";
> +
> default:
> break;
Now we also need idata and ifwdtsn in there too, btw.
Marcelo
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH net] sctp: add SCTP_CID_RECONF conversion in sctp_cname
2017-12-18 13:08 ` Marcelo Ricardo Leitner
@ 2017-12-19 4:07 ` Xin Long
-1 siblings, 0 replies; 10+ messages in thread
From: Xin Long @ 2017-12-19 4:07 UTC (permalink / raw)
To: Marcelo Ricardo Leitner; +Cc: network dev, linux-sctp, davem, Neil Horman
On Mon, Dec 18, 2017 at 9:08 PM, Marcelo Ricardo Leitner
<marcelo.leitner@gmail.com> wrote:
> On Mon, Dec 18, 2017 at 02:13:17PM +0800, Xin Long wrote:
>> Whenever a new type of chunk is added, the corresp conversion in
>> sctp_cname should be added. Otherwise, in some places, pr_debug
>> will print it as "unknown chunk".
>>
>> Fixes: cc16f00f6529 ("sctp: add support for generating stream reconf ssn reset request chunk")
>> Signed-off-by: Xin Long <lucien.xin@gmail.com>
>
> Acked-by: Marcelo R. Leitner <marcelo.leitner@gmail.com>
>
> ...
>> case SCTP_CID_AUTH:
>> return "AUTH";
>>
>> + case SCTP_CID_RECONF:
>> + return "RECONF";
>> +
>> default:
>> break;
>
> Now we also need idata and ifwdtsn in there too, btw.
Yes, waiting for the merge from net-next to net.
>
> Marcelo
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH net] sctp: add SCTP_CID_RECONF conversion in sctp_cname
@ 2017-12-19 4:07 ` Xin Long
0 siblings, 0 replies; 10+ messages in thread
From: Xin Long @ 2017-12-19 4:07 UTC (permalink / raw)
To: Marcelo Ricardo Leitner; +Cc: network dev, linux-sctp, davem, Neil Horman
On Mon, Dec 18, 2017 at 9:08 PM, Marcelo Ricardo Leitner
<marcelo.leitner@gmail.com> wrote:
> On Mon, Dec 18, 2017 at 02:13:17PM +0800, Xin Long wrote:
>> Whenever a new type of chunk is added, the corresp conversion in
>> sctp_cname should be added. Otherwise, in some places, pr_debug
>> will print it as "unknown chunk".
>>
>> Fixes: cc16f00f6529 ("sctp: add support for generating stream reconf ssn reset request chunk")
>> Signed-off-by: Xin Long <lucien.xin@gmail.com>
>
> Acked-by: Marcelo R. Leitner <marcelo.leitner@gmail.com>
>
> ...
>> case SCTP_CID_AUTH:
>> return "AUTH";
>>
>> + case SCTP_CID_RECONF:
>> + return "RECONF";
>> +
>> default:
>> break;
>
> Now we also need idata and ifwdtsn in there too, btw.
Yes, waiting for the merge from net-next to net.
>
> Marcelo
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH net] sctp: add SCTP_CID_RECONF conversion in sctp_cname
2017-12-18 6:13 ` Xin Long
@ 2017-12-18 14:37 ` Neil Horman
-1 siblings, 0 replies; 10+ messages in thread
From: Neil Horman @ 2017-12-18 14:37 UTC (permalink / raw)
To: Xin Long; +Cc: network dev, linux-sctp, davem, Marcelo Ricardo Leitner
On Mon, Dec 18, 2017 at 02:13:17PM +0800, Xin Long wrote:
> Whenever a new type of chunk is added, the corresp conversion in
> sctp_cname should be added. Otherwise, in some places, pr_debug
> will print it as "unknown chunk".
>
> Fixes: cc16f00f6529 ("sctp: add support for generating stream reconf ssn reset request chunk")
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
> ---
> net/sctp/debug.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/net/sctp/debug.c b/net/sctp/debug.c
> index 3f619fd..291c97b 100644
> --- a/net/sctp/debug.c
> +++ b/net/sctp/debug.c
> @@ -78,6 +78,9 @@ const char *sctp_cname(const union sctp_subtype cid)
> case SCTP_CID_AUTH:
> return "AUTH";
>
> + case SCTP_CID_RECONF:
> + return "RECONF";
> +
> default:
> break;
> }
> --
> 2.1.0
>
>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH net] sctp: add SCTP_CID_RECONF conversion in sctp_cname
@ 2017-12-18 14:37 ` Neil Horman
0 siblings, 0 replies; 10+ messages in thread
From: Neil Horman @ 2017-12-18 14:37 UTC (permalink / raw)
To: Xin Long; +Cc: network dev, linux-sctp, davem, Marcelo Ricardo Leitner
On Mon, Dec 18, 2017 at 02:13:17PM +0800, Xin Long wrote:
> Whenever a new type of chunk is added, the corresp conversion in
> sctp_cname should be added. Otherwise, in some places, pr_debug
> will print it as "unknown chunk".
>
> Fixes: cc16f00f6529 ("sctp: add support for generating stream reconf ssn reset request chunk")
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
> ---
> net/sctp/debug.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/net/sctp/debug.c b/net/sctp/debug.c
> index 3f619fd..291c97b 100644
> --- a/net/sctp/debug.c
> +++ b/net/sctp/debug.c
> @@ -78,6 +78,9 @@ const char *sctp_cname(const union sctp_subtype cid)
> case SCTP_CID_AUTH:
> return "AUTH";
>
> + case SCTP_CID_RECONF:
> + return "RECONF";
> +
> default:
> break;
> }
> --
> 2.1.0
>
>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH net] sctp: add SCTP_CID_RECONF conversion in sctp_cname
2017-12-18 6:13 ` Xin Long
@ 2017-12-18 18:22 ` David Miller
-1 siblings, 0 replies; 10+ messages in thread
From: David Miller @ 2017-12-18 18:22 UTC (permalink / raw)
To: lucien.xin; +Cc: netdev, linux-sctp, marcelo.leitner, nhorman
From: Xin Long <lucien.xin@gmail.com>
Date: Mon, 18 Dec 2017 14:13:17 +0800
> Whenever a new type of chunk is added, the corresp conversion in
> sctp_cname should be added. Otherwise, in some places, pr_debug
> will print it as "unknown chunk".
>
> Fixes: cc16f00f6529 ("sctp: add support for generating stream reconf ssn reset request chunk")
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH net] sctp: add SCTP_CID_RECONF conversion in sctp_cname
@ 2017-12-18 18:22 ` David Miller
0 siblings, 0 replies; 10+ messages in thread
From: David Miller @ 2017-12-18 18:22 UTC (permalink / raw)
To: lucien.xin; +Cc: netdev, linux-sctp, marcelo.leitner, nhorman
From: Xin Long <lucien.xin@gmail.com>
Date: Mon, 18 Dec 2017 14:13:17 +0800
> Whenever a new type of chunk is added, the corresp conversion in
> sctp_cname should be added. Otherwise, in some places, pr_debug
> will print it as "unknown chunk".
>
> Fixes: cc16f00f6529 ("sctp: add support for generating stream reconf ssn reset request chunk")
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 10+ messages in thread