From: Miquel RAYNAL <miquel.raynal@free-electrons.com>
To: Willy Tarreau <w@1wt.eu>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
Robert Jarzmik <robert.jarzmik@free.fr>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: pxa3xx_nand times out in 4.14 with JFFS2
Date: Tue, 19 Dec 2017 01:13:15 +0100 [thread overview]
Message-ID: <20171219011315.2fa0f9d1@xps13> (raw)
In-Reply-To: <20171218215217.GA17755@1wt.eu>
Hi Willy,
On Mon, 18 Dec 2017 22:52:17 +0100
Willy Tarreau <w@1wt.eu> wrote:
> Hi Miquel,
>
> On Mon, Dec 18, 2017 at 11:22:08AM +0100, Miquel RAYNAL wrote:
> > I fixed two problems happening during read/write of 2kiB page NAND
> > chips, I am quite confident this would solve the issues you report
> > here. Could you please give it a try?
>
> So I just tested right now, and good news, it now works pretty fine
> here, and my jffs2 properly mounted (without requiring Boris' fix
> for oob)
Great! Thanks for testing.
Boris' fix wouldn't apply anyway as it was written for pxa3xx_nand.c
and here you are using marvell_nand.c and the code is really different.
>
> # dmesg|grep -i nand
> [ 0.770395] nand: device found, Manufacturer ID: 0x01, Chip ID:
> 0xf1 [ 0.775474] nand: AMD/Spansion S34ML01G2
> [ 0.778103] nand: 128 MiB, SLC, erase size: 128 KiB, page size:
> 2048, OOB size: 64 [ 0.794080] 10 ofpart partitions found on MTD
> device pxa3xx_nand-0 [ 0.798975] Creating 10 MTD partitions on
> "pxa3xx_nand-0": [ 3.245034] jffs2: version 2.2. (NAND) (SUMMARY)
> \xffffffc2\xffffffa9 2001-2006 Red Hat, Inc.
>
> I was first surprized seeing this "pxa3xx_nand-0" still appearing
> until I realized that it's how it's called in the device tree :-)
That is right, but if you create a DTS for your own board feel free to
change it, this is just a default name. Giving it some meaning (like
"main-storage" or "backup-storage") is how you could use this label.
Thanks again for your help, reviews or tested-by's are welcome for this
driver ;)
Miquèl
WARNING: multiple messages have this Message-ID (diff)
From: miquel.raynal@free-electrons.com (Miquel RAYNAL)
To: linux-arm-kernel@lists.infradead.org
Subject: pxa3xx_nand times out in 4.14 with JFFS2
Date: Tue, 19 Dec 2017 01:13:15 +0100 [thread overview]
Message-ID: <20171219011315.2fa0f9d1@xps13> (raw)
In-Reply-To: <20171218215217.GA17755@1wt.eu>
Hi Willy,
On Mon, 18 Dec 2017 22:52:17 +0100
Willy Tarreau <w@1wt.eu> wrote:
> Hi Miquel,
>
> On Mon, Dec 18, 2017 at 11:22:08AM +0100, Miquel RAYNAL wrote:
> > I fixed two problems happening during read/write of 2kiB page NAND
> > chips, I am quite confident this would solve the issues you report
> > here. Could you please give it a try?
>
> So I just tested right now, and good news, it now works pretty fine
> here, and my jffs2 properly mounted (without requiring Boris' fix
> for oob)
Great! Thanks for testing.
Boris' fix wouldn't apply anyway as it was written for pxa3xx_nand.c
and here you are using marvell_nand.c and the code is really different.
>
> # dmesg|grep -i nand
> [ 0.770395] nand: device found, Manufacturer ID: 0x01, Chip ID:
> 0xf1 [ 0.775474] nand: AMD/Spansion S34ML01G2
> [ 0.778103] nand: 128 MiB, SLC, erase size: 128 KiB, page size:
> 2048, OOB size: 64 [ 0.794080] 10 ofpart partitions found on MTD
> device pxa3xx_nand-0 [ 0.798975] Creating 10 MTD partitions on
> "pxa3xx_nand-0": [ 3.245034] jffs2: version 2.2. (NAND) (SUMMARY)
> \xffffffc2\xffffffa9 2001-2006 Red Hat, Inc.
>
> I was first surprized seeing this "pxa3xx_nand-0" still appearing
> until I realized that it's how it's called in the device tree :-)
That is right, but if you create a DTS for your own board feel free to
change it, this is just a default name. Giving it some meaning (like
"main-storage" or "backup-storage") is how you could use this label.
Thanks again for your help, reviews or tested-by's are welcome for this
driver ;)
Miqu?l
next prev parent reply other threads:[~2017-12-19 0:13 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-17 12:05 pxa3xx_nand times out in 4.14 with JFFS2 Willy Tarreau
2017-12-17 12:05 ` Willy Tarreau
2017-12-17 12:33 ` Boris Brezillon
2017-12-17 12:33 ` Boris Brezillon
2017-12-17 13:17 ` Willy Tarreau
2017-12-17 13:17 ` Willy Tarreau
2017-12-17 14:25 ` Ezequiel Garcia
2017-12-17 14:25 ` Ezequiel Garcia
2017-12-17 14:27 ` Ezequiel Garcia
2017-12-17 14:27 ` Ezequiel Garcia
2017-12-17 14:53 ` Boris Brezillon
2017-12-17 14:53 ` Boris Brezillon
2017-12-17 15:00 ` Willy Tarreau
2017-12-17 15:00 ` Willy Tarreau
2017-12-17 15:09 ` Willy Tarreau
2017-12-17 15:09 ` Willy Tarreau
2017-12-17 15:53 ` Ezequiel Garcia
2017-12-17 15:53 ` Ezequiel Garcia
2017-12-17 16:23 ` Willy Tarreau
2017-12-17 16:23 ` Willy Tarreau
2017-12-17 18:07 ` Boris Brezillon
2017-12-17 18:07 ` Boris Brezillon
2017-12-17 19:00 ` Willy Tarreau
2017-12-17 19:00 ` Willy Tarreau
2017-12-17 21:01 ` Ezequiel Garcia
2017-12-17 21:01 ` Ezequiel Garcia
2017-12-17 21:16 ` Willy Tarreau
2017-12-17 21:16 ` Willy Tarreau
2017-12-17 21:26 ` Boris Brezillon
2017-12-17 21:26 ` Boris Brezillon
2017-12-17 21:46 ` Miquel RAYNAL
2017-12-17 21:46 ` Miquel RAYNAL
2017-12-18 6:37 ` Willy Tarreau
2017-12-18 6:37 ` Willy Tarreau
2017-12-18 7:06 ` Willy Tarreau
2017-12-18 7:06 ` Willy Tarreau
2017-12-18 10:22 ` Miquel RAYNAL
2017-12-18 10:22 ` Miquel RAYNAL
2017-12-18 21:52 ` Willy Tarreau
2017-12-18 21:52 ` Willy Tarreau
2017-12-19 0:13 ` Miquel RAYNAL [this message]
2017-12-19 0:13 ` Miquel RAYNAL
2017-12-19 5:34 ` Willy Tarreau
2017-12-19 5:34 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171219011315.2fa0f9d1@xps13 \
--to=miquel.raynal@free-electrons.com \
--cc=boris.brezillon@free-electrons.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=robert.jarzmik@free.fr \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.