From: Stephen Hemminger <stephen@networkplumber.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Bridge] [PATCH v1] bridge: Use helpers to handle MAC address
Date: Tue, 19 Dec 2017 10:32:56 -0800 [thread overview]
Message-ID: <20171219103256.07405db1@xeon-e3> (raw)
In-Reply-To: <20171219181053.86320-1-andriy.shevchenko@linux.intel.com>
On Tue, 19 Dec 2017 20:10:53 +0200
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> Use
> %pM to print MAC
> mac_pton() to convert it from ASCII to binary format, and
> ether_addr_copy() to copy.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Looks good
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Hemminger <stephen@networkplumber.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "David S. Miller" <davem@davemloft.net>,
bridge@lists.linux-foundation.org, netdev@vger.kernel.org
Subject: Re: [PATCH v1] bridge: Use helpers to handle MAC address
Date: Tue, 19 Dec 2017 10:32:56 -0800 [thread overview]
Message-ID: <20171219103256.07405db1@xeon-e3> (raw)
In-Reply-To: <20171219181053.86320-1-andriy.shevchenko@linux.intel.com>
On Tue, 19 Dec 2017 20:10:53 +0200
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> Use
> %pM to print MAC
> mac_pton() to convert it from ASCII to binary format, and
> ether_addr_copy() to copy.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Looks good
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
next prev parent reply other threads:[~2017-12-19 18:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 18:10 [Bridge] [PATCH v1] bridge: Use helpers to handle MAC address Andy Shevchenko
2017-12-19 18:10 ` Andy Shevchenko
2017-12-19 18:32 ` Stephen Hemminger [this message]
2017-12-19 18:32 ` Stephen Hemminger
2017-12-19 19:21 ` [Bridge] " Randy Dunlap
2017-12-19 19:21 ` Randy Dunlap
2017-12-19 19:33 ` [Bridge] " Andy Shevchenko
2017-12-19 19:33 ` Andy Shevchenko
2017-12-20 17:46 ` [Bridge] " David Miller
2017-12-20 17:46 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171219103256.07405db1@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.