From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Arnaud Mouiche <arnaud.mouiche@invoxia.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
Timur Tabi <timur@tabi.org>, Caleb Crome <caleb@crome.org>,
linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>,
Sascha Hauer <kernel@pengutronix.de>,
lukma@denx.de, Fabio Estevam <fabio.estevam@nxp.com>,
mail@maciej.szmigiero.name, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v4 00/11] ASoC: fsl_ssi: Clean up - coding style level
Date: Wed, 20 Dec 2017 09:26:33 -0800 [thread overview]
Message-ID: <20171220172632.GA19904@Asurada-Nvidia> (raw)
In-Reply-To: <4c727cc2-2338-4e99-df09-a088a72cfd61@invoxia.com>
On Wed, Dec 20, 2017 at 12:40:37PM +0100, Arnaud Mouiche wrote:
> >>>Ugh, so it's basically quite broken again -- before these patches.
> >>I remember Arnaud reviewed one of my changes back to September.
> >>So I suppose the test should be fine at that time -- so a change
> >>being merged recently might have impacted the test result.
> Sorry but I will be busy until mid January, I could help testing and
> fixing broken multi channel after.
> Anyway, I don't see specific issues with Nicolin patches.
> We can take time to fix what was broken before this patch set... after.
I won't be able to fix and re-submit patches either during the
holidays. So let's discuss this in earlier January. Thanks for
joining.
Nicolin
WARNING: multiple messages have this Message-ID (diff)
From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Arnaud Mouiche <arnaud.mouiche@invoxia.com>
Cc: Caleb Crome <caleb@crome.org>, Mark Brown <broonie@kernel.org>,
Timur Tabi <timur@tabi.org>,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
Fabio Estevam <fabio.estevam@nxp.com>,
mail@maciej.szmigiero.name, lukma@denx.de,
Sascha Hauer <kernel@pengutronix.de>
Subject: Re: [PATCH v4 00/11] ASoC: fsl_ssi: Clean up - coding style level
Date: Wed, 20 Dec 2017 09:26:33 -0800 [thread overview]
Message-ID: <20171220172632.GA19904@Asurada-Nvidia> (raw)
In-Reply-To: <4c727cc2-2338-4e99-df09-a088a72cfd61@invoxia.com>
On Wed, Dec 20, 2017 at 12:40:37PM +0100, Arnaud Mouiche wrote:
> >>>Ugh, so it's basically quite broken again -- before these patches.
> >>I remember Arnaud reviewed one of my changes back to September.
> >>So I suppose the test should be fine at that time -- so a change
> >>being merged recently might have impacted the test result.
> Sorry but I will be busy until mid January, I could help testing and
> fixing broken multi channel after.
> Anyway, I don't see specific issues with Nicolin patches.
> We can take time to fix what was broken before this patch set... after.
I won't be able to fix and re-submit patches either during the
holidays. So let's discuss this in earlier January. Thanks for
joining.
Nicolin
next prev parent reply other threads:[~2017-12-20 17:26 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-18 2:51 [PATCH v4 00/11] ASoC: fsl_ssi: Clean up - coding style level Nicolin Chen
2017-12-18 2:52 ` [PATCH v4 01/11] ASoC: fsl_ssi: Rename fsl_ssi_private to fsl_ssi Nicolin Chen
2017-12-18 2:52 ` [PATCH v4 02/11] ASoC: fsl_ssi: Cache pdev->dev pointer Nicolin Chen
2017-12-18 2:52 ` Nicolin Chen
2017-12-18 2:52 ` [PATCH v4 03/11] ASoC: fsl_ssi: Refine all comments Nicolin Chen
2017-12-18 2:52 ` Nicolin Chen
2017-12-19 11:00 ` Applied "ASoC: fsl_ssi: Refine all comments" to the asoc tree Mark Brown
2017-12-19 11:00 ` Mark Brown
2017-12-18 2:52 ` [PATCH v4 04/11] ASoC: fsl_ssi: Rename registers and fields macros Nicolin Chen
2017-12-19 11:00 ` Applied "ASoC: fsl_ssi: Rename registers and fields macros" to the asoc tree Mark Brown
2017-12-19 11:00 ` Mark Brown
2017-12-18 2:52 ` [PATCH v4 05/11] ASoC: fsl_ssi: Refine indentations and wrappings Nicolin Chen
2017-12-19 11:00 ` Applied "ASoC: fsl_ssi: Refine indentations and wrappings" to the asoc tree Mark Brown
2017-12-19 11:00 ` Mark Brown
2017-12-18 2:52 ` [PATCH v4 06/11] ASoC: fsl_ssi: Refine printk outputs Nicolin Chen
2017-12-18 2:52 ` [PATCH v4 07/11] ASoC: fsl_ssi: Rename cpu_dai parameter to dai Nicolin Chen
2017-12-18 2:52 ` [PATCH v4 08/11] ASoC: fsl_ssi: Rename scr_val to scr Nicolin Chen
2017-12-18 2:52 ` [PATCH v4 09/11] ASoC: fsl_ssi: Replace fsl_ssi_rxtx_reg_val with fsl_ssi_regvals Nicolin Chen
2017-12-19 10:59 ` Applied "ASoC: fsl_ssi: Replace fsl_ssi_rxtx_reg_val with fsl_ssi_regvals" to the asoc tree Mark Brown
2017-12-19 10:59 ` Mark Brown
2017-12-18 2:52 ` [PATCH v4 10/11] ASoC: fsl_ssi: Rename i2smode to i2s_net Nicolin Chen
2017-12-18 2:52 ` [PATCH v4 11/11] ASoC: fsl_ssi: Define ternary macros to simplify code Nicolin Chen
2017-12-18 3:13 ` [PATCH v4 00/11] ASoC: fsl_ssi: Clean up - coding style level Timur Tabi
2017-12-18 22:19 ` Caleb Crome
2017-12-18 22:19 ` Caleb Crome
2017-12-18 23:02 ` Nicolin Chen
2017-12-18 23:02 ` Nicolin Chen
2017-12-19 0:25 ` Caleb Crome
2017-12-20 11:40 ` Arnaud Mouiche
2017-12-20 11:40 ` Arnaud Mouiche
2017-12-20 17:26 ` Nicolin Chen [this message]
2017-12-20 17:26 ` Nicolin Chen
2017-12-21 16:08 ` Caleb Crome
2017-12-21 16:08 ` Caleb Crome
2017-12-21 16:10 ` Caleb Crome
2017-12-21 16:21 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171220172632.GA19904@Asurada-Nvidia \
--to=nicoleotsuka@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnaud.mouiche@invoxia.com \
--cc=broonie@kernel.org \
--cc=caleb@crome.org \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lukma@denx.de \
--cc=mail@maciej.szmigiero.name \
--cc=timur@tabi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.