All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Busch <keith.busch@intel.com>
To: linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
	Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
	Sagi Grimberg <sagi@grimberg.me>
Cc: Keith Busch <keith.busch@intel.com>
Subject: [PATCH 0/3] Performance enhancements
Date: Thu, 21 Dec 2017 13:46:33 -0700	[thread overview]
Message-ID: <20171221204636.2924-1-keith.busch@intel.com> (raw)

A few IO micro-optimizations for IO polling and NVMe. I'm really working
to close the performance gap with userspace drivers, and this gets me
halfway there on latency. The fastest hardware I could get measured
roundtrip read latency at 5usec with this series that was previously
measuring 5.7usec.

Note with NVMe, you really need to crank up the interrupt coalescing to
see the completion polling benefit.

Test pre-setup:

  echo performance | tee /sys/devices/system/cpu/cpufreq/policy*/scaling_governor
  echo 0 > /sys/block/nvme0n1/queue/iostats
  echo -1 > /sys/block/nvme0n1/queue/io_poll_delay
  nvme set-feature /dev/nvme0 -f 8 -v 0x4ff

fio profile:

  [global]
  ioengine=pvsync2
  rw=randread
  norandommap
  direct=1
  bs=4k
  hipri

  [hi-pri]
  filename=/dev/nvme0n1
  cpus_allowed=2

Keith Busch (3):
  nvme/pci: Start request after doorbell ring
  nvme/pci: Remove cq_vector check in IO path
  block: Polling completion performance optimization

 drivers/nvme/host/pci.c | 14 +++-----------
 fs/block_dev.c          |  5 ++++-
 2 files changed, 7 insertions(+), 12 deletions(-)

-- 
2.13.6

WARNING: multiple messages have this Message-ID (diff)
From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH 0/3] Performance enhancements
Date: Thu, 21 Dec 2017 13:46:33 -0700	[thread overview]
Message-ID: <20171221204636.2924-1-keith.busch@intel.com> (raw)

A few IO micro-optimizations for IO polling and NVMe. I'm really working
to close the performance gap with userspace drivers, and this gets me
halfway there on latency. The fastest hardware I could get measured
roundtrip read latency at 5usec with this series that was previously
measuring 5.7usec.

Note with NVMe, you really need to crank up the interrupt coalescing to
see the completion polling benefit.

Test pre-setup:

  echo performance | tee /sys/devices/system/cpu/cpufreq/policy*/scaling_governor
  echo 0 > /sys/block/nvme0n1/queue/iostats
  echo -1 > /sys/block/nvme0n1/queue/io_poll_delay
  nvme set-feature /dev/nvme0 -f 8 -v 0x4ff

fio profile:

  [global]
  ioengine=pvsync2
  rw=randread
  norandommap
  direct=1
  bs=4k
  hipri

  [hi-pri]
  filename=/dev/nvme0n1
  cpus_allowed=2

Keith Busch (3):
  nvme/pci: Start request after doorbell ring
  nvme/pci: Remove cq_vector check in IO path
  block: Polling completion performance optimization

 drivers/nvme/host/pci.c | 14 +++-----------
 fs/block_dev.c          |  5 ++++-
 2 files changed, 7 insertions(+), 12 deletions(-)

-- 
2.13.6

             reply	other threads:[~2017-12-21 20:46 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-21 20:46 Keith Busch [this message]
2017-12-21 20:46 ` [PATCH 0/3] Performance enhancements Keith Busch
2017-12-21 20:46 ` [PATCH 1/3] nvme/pci: Start request after doorbell ring Keith Busch
2017-12-21 20:46   ` Keith Busch
2017-12-21 20:49   ` Jens Axboe
2017-12-21 20:49     ` Jens Axboe
2017-12-21 20:53     ` Jens Axboe
2017-12-21 20:53       ` Jens Axboe
2017-12-21 21:02       ` Keith Busch
2017-12-21 21:02         ` Keith Busch
2017-12-21 21:01         ` Jens Axboe
2017-12-21 21:01           ` Jens Axboe
2018-01-03 20:21           ` Keith Busch
2018-01-03 20:21             ` Keith Busch
2018-01-23  0:16             ` Keith Busch
2018-01-23  0:16               ` Keith Busch
2017-12-25 10:12         ` Sagi Grimberg
2017-12-25 10:12           ` Sagi Grimberg
2017-12-29  9:44           ` Christoph Hellwig
2017-12-29  9:44             ` Christoph Hellwig
2017-12-25 10:11   ` Sagi Grimberg
2017-12-25 10:11     ` Sagi Grimberg
2017-12-26 20:35     ` Keith Busch
2017-12-26 20:35       ` Keith Busch
2017-12-27  9:02       ` Sagi Grimberg
2017-12-27  9:02         ` Sagi Grimberg
2017-12-29  9:44   ` Christoph Hellwig
2017-12-29  9:44     ` Christoph Hellwig
2017-12-21 20:46 ` [PATCH 2/3] nvme/pci: Remove cq_vector check in IO path Keith Busch
2017-12-21 20:46   ` Keith Busch
2017-12-21 20:54   ` Jens Axboe
2017-12-21 20:54     ` Jens Axboe
2017-12-25 10:10   ` Sagi Grimberg
2017-12-25 10:10     ` Sagi Grimberg
2017-12-27 21:01     ` Sagi Grimberg
2017-12-27 21:01       ` Sagi Grimberg
2017-12-29  9:48       ` Christoph Hellwig
2017-12-29  9:48         ` Christoph Hellwig
2017-12-29 15:39         ` Keith Busch
2017-12-29 15:39           ` Keith Busch
2017-12-31 12:30           ` Sagi Grimberg
2017-12-31 12:30             ` Sagi Grimberg
2018-01-02 16:50             ` Keith Busch
2018-01-02 16:50               ` Keith Busch
2017-12-21 20:46 ` [PATCH 3/3] block: Polling completion performance optimization Keith Busch
2017-12-21 20:46   ` Keith Busch
2017-12-21 20:56   ` Scott Bauer
2017-12-21 20:56     ` Scott Bauer
2017-12-21 21:00     ` Jens Axboe
2017-12-21 21:00       ` Jens Axboe
2017-12-21 21:34       ` Keith Busch
2017-12-21 21:34         ` Keith Busch
2017-12-21 22:17         ` Jens Axboe
2017-12-21 22:17           ` Jens Axboe
2017-12-21 23:10           ` Keith Busch
2017-12-21 23:10             ` Keith Busch
2017-12-22 15:40             ` Jens Axboe
2017-12-22 15:40               ` Jens Axboe
2017-12-29  9:50         ` Christoph Hellwig
2017-12-29  9:50           ` Christoph Hellwig
2017-12-29 15:51           ` Keith Busch
2017-12-29 15:51             ` Keith Busch
2017-12-31 12:48           ` Sagi Grimberg
2017-12-31 12:48             ` Sagi Grimberg
2017-12-21 20:57   ` Jens Axboe
2017-12-21 20:57     ` Jens Axboe
2017-12-29  9:51   ` Christoph Hellwig
2017-12-29  9:51     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171221204636.2924-1-keith.busch@intel.com \
    --to=keith.busch@intel.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.