All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Busch <keith.busch@intel.com>
To: linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
	Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
	Sagi Grimberg <sagi@grimberg.me>
Cc: Keith Busch <keith.busch@intel.com>
Subject: [PATCH 3/3] block: Polling completion performance optimization
Date: Thu, 21 Dec 2017 13:46:36 -0700	[thread overview]
Message-ID: <20171221204636.2924-4-keith.busch@intel.com> (raw)
In-Reply-To: <20171221204636.2924-1-keith.busch@intel.com>

When a request completion is polled, the completion task wakes itself
up. This is unnecessary, as the task can just set itself back to
running.

Signed-off-by: Keith Busch <keith.busch@intel.com>
---
 fs/block_dev.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/fs/block_dev.c b/fs/block_dev.c
index 4a181fcb5175..ce67ffe73430 100644
--- a/fs/block_dev.c
+++ b/fs/block_dev.c
@@ -181,7 +181,10 @@ static void blkdev_bio_end_io_simple(struct bio *bio)
 	struct task_struct *waiter = bio->bi_private;
 
 	WRITE_ONCE(bio->bi_private, NULL);
-	wake_up_process(waiter);
+	if (current != waiter)
+		wake_up_process(waiter);
+	else
+		__set_current_state(TASK_RUNNING);
 }
 
 static ssize_t
-- 
2.13.6

WARNING: multiple messages have this Message-ID (diff)
From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH 3/3] block: Polling completion performance optimization
Date: Thu, 21 Dec 2017 13:46:36 -0700	[thread overview]
Message-ID: <20171221204636.2924-4-keith.busch@intel.com> (raw)
In-Reply-To: <20171221204636.2924-1-keith.busch@intel.com>

When a request completion is polled, the completion task wakes itself
up. This is unnecessary, as the task can just set itself back to
running.

Signed-off-by: Keith Busch <keith.busch at intel.com>
---
 fs/block_dev.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/fs/block_dev.c b/fs/block_dev.c
index 4a181fcb5175..ce67ffe73430 100644
--- a/fs/block_dev.c
+++ b/fs/block_dev.c
@@ -181,7 +181,10 @@ static void blkdev_bio_end_io_simple(struct bio *bio)
 	struct task_struct *waiter = bio->bi_private;
 
 	WRITE_ONCE(bio->bi_private, NULL);
-	wake_up_process(waiter);
+	if (current != waiter)
+		wake_up_process(waiter);
+	else
+		__set_current_state(TASK_RUNNING);
 }
 
 static ssize_t
-- 
2.13.6

  parent reply	other threads:[~2017-12-21 20:46 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-21 20:46 [PATCH 0/3] Performance enhancements Keith Busch
2017-12-21 20:46 ` Keith Busch
2017-12-21 20:46 ` [PATCH 1/3] nvme/pci: Start request after doorbell ring Keith Busch
2017-12-21 20:46   ` Keith Busch
2017-12-21 20:49   ` Jens Axboe
2017-12-21 20:49     ` Jens Axboe
2017-12-21 20:53     ` Jens Axboe
2017-12-21 20:53       ` Jens Axboe
2017-12-21 21:02       ` Keith Busch
2017-12-21 21:02         ` Keith Busch
2017-12-21 21:01         ` Jens Axboe
2017-12-21 21:01           ` Jens Axboe
2018-01-03 20:21           ` Keith Busch
2018-01-03 20:21             ` Keith Busch
2018-01-23  0:16             ` Keith Busch
2018-01-23  0:16               ` Keith Busch
2017-12-25 10:12         ` Sagi Grimberg
2017-12-25 10:12           ` Sagi Grimberg
2017-12-29  9:44           ` Christoph Hellwig
2017-12-29  9:44             ` Christoph Hellwig
2017-12-25 10:11   ` Sagi Grimberg
2017-12-25 10:11     ` Sagi Grimberg
2017-12-26 20:35     ` Keith Busch
2017-12-26 20:35       ` Keith Busch
2017-12-27  9:02       ` Sagi Grimberg
2017-12-27  9:02         ` Sagi Grimberg
2017-12-29  9:44   ` Christoph Hellwig
2017-12-29  9:44     ` Christoph Hellwig
2017-12-21 20:46 ` [PATCH 2/3] nvme/pci: Remove cq_vector check in IO path Keith Busch
2017-12-21 20:46   ` Keith Busch
2017-12-21 20:54   ` Jens Axboe
2017-12-21 20:54     ` Jens Axboe
2017-12-25 10:10   ` Sagi Grimberg
2017-12-25 10:10     ` Sagi Grimberg
2017-12-27 21:01     ` Sagi Grimberg
2017-12-27 21:01       ` Sagi Grimberg
2017-12-29  9:48       ` Christoph Hellwig
2017-12-29  9:48         ` Christoph Hellwig
2017-12-29 15:39         ` Keith Busch
2017-12-29 15:39           ` Keith Busch
2017-12-31 12:30           ` Sagi Grimberg
2017-12-31 12:30             ` Sagi Grimberg
2018-01-02 16:50             ` Keith Busch
2018-01-02 16:50               ` Keith Busch
2017-12-21 20:46 ` Keith Busch [this message]
2017-12-21 20:46   ` [PATCH 3/3] block: Polling completion performance optimization Keith Busch
2017-12-21 20:56   ` Scott Bauer
2017-12-21 20:56     ` Scott Bauer
2017-12-21 21:00     ` Jens Axboe
2017-12-21 21:00       ` Jens Axboe
2017-12-21 21:34       ` Keith Busch
2017-12-21 21:34         ` Keith Busch
2017-12-21 22:17         ` Jens Axboe
2017-12-21 22:17           ` Jens Axboe
2017-12-21 23:10           ` Keith Busch
2017-12-21 23:10             ` Keith Busch
2017-12-22 15:40             ` Jens Axboe
2017-12-22 15:40               ` Jens Axboe
2017-12-29  9:50         ` Christoph Hellwig
2017-12-29  9:50           ` Christoph Hellwig
2017-12-29 15:51           ` Keith Busch
2017-12-29 15:51             ` Keith Busch
2017-12-31 12:48           ` Sagi Grimberg
2017-12-31 12:48             ` Sagi Grimberg
2017-12-21 20:57   ` Jens Axboe
2017-12-21 20:57     ` Jens Axboe
2017-12-29  9:51   ` Christoph Hellwig
2017-12-29  9:51     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171221204636.2924-4-keith.busch@intel.com \
    --to=keith.busch@intel.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.