All of lore.kernel.org
 help / color / mirror / Atom feed
From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: imx: suspend/resume: use outer_disable/resume
Date: Tue, 26 Dec 2017 17:09:03 +0800	[thread overview]
Message-ID: <20171226090902.GO23070@X250> (raw)
In-Reply-To: <DB6PR04MB32218D8A75D4D9F6CB2D2F3C88060@DB6PR04MB3221.eurprd04.prod.outlook.com>

On Tue, Dec 26, 2017 at 06:52:45AM +0000, Peng Fan wrote:
> Hi Shawn,
> 
> > -----Original Message-----
> > From: Shawn Guo [mailto:shawnguo at kernel.org]
> > Sent: Tuesday, December 26, 2017 11:31 AM
> > To: Peng Fan <peng.fan@nxp.com>
> > Cc: A.s. Dong <aisheng.dong@nxp.com>; linux-kernel at vger.kernel.org; Russell
> > King <linux@armlinux.org.uk>; Fabio Estevam <fabio.estevam@nxp.com>;
> > Sascha Hauer <kernel@pengutronix.de>; van.freenix at gmail.com; linux-arm-
> > kernel at lists.infradead.org
> > Subject: Re: [PATCH] arm: imx: suspend/resume: use outer_disable/resume
> > 
> > On Sun, Dec 10, 2017 at 08:07:18PM +0800, Peng Fan wrote:
> > > Use outer_disable/resume for suspend/resume.
> > > With the two APIs used, code could be simplified and easy to extend to
> > > introduce l2c_write_sec for i.MX platforms when moving Linux Kernel
> > > runs in non-secure world.
> > >
> > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > > Cc: Shawn Guo <shawnguo@kernel.org>
> > > Cc: Sascha Hauer <kernel@pengutronix.de>
> > > Cc: Fabio Estevam <fabio.estevam@nxp.com>
> > > Cc: Russell King <linux@armlinux.org.uk>
> > > Cc: Dong Aisheng <aisheng.dong@nxp.com>
> > > ---
> > >  arch/arm/mach-imx/pm-imx6.c      |  2 ++
> > >  arch/arm/mach-imx/suspend-imx6.S | 24 ------------------------
> > 
> > I'm fine with the patch in general.  But this piece of code is running on a few
> > i.MX6 platforms, and I'm wondering on which SoCs you have verified the
> > change work fine.
> 
> I tested it on 6Q-SDB board. Is it ok?

Okay, I will get it into linux-next for a bit wider testing.

Shawn

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Peng Fan <peng.fan@nxp.com>
Cc: "A.s. Dong" <aisheng.dong@nxp.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Russell King <linux@armlinux.org.uk>,
	"van.freenix@gmail.com" <van.freenix@gmail.com>,
	Sascha Hauer <kernel@pengutronix.de>,
	Fabio Estevam <fabio.estevam@nxp.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] arm: imx: suspend/resume: use outer_disable/resume
Date: Tue, 26 Dec 2017 17:09:03 +0800	[thread overview]
Message-ID: <20171226090902.GO23070@X250> (raw)
In-Reply-To: <DB6PR04MB32218D8A75D4D9F6CB2D2F3C88060@DB6PR04MB3221.eurprd04.prod.outlook.com>

On Tue, Dec 26, 2017 at 06:52:45AM +0000, Peng Fan wrote:
> Hi Shawn,
> 
> > -----Original Message-----
> > From: Shawn Guo [mailto:shawnguo@kernel.org]
> > Sent: Tuesday, December 26, 2017 11:31 AM
> > To: Peng Fan <peng.fan@nxp.com>
> > Cc: A.s. Dong <aisheng.dong@nxp.com>; linux-kernel@vger.kernel.org; Russell
> > King <linux@armlinux.org.uk>; Fabio Estevam <fabio.estevam@nxp.com>;
> > Sascha Hauer <kernel@pengutronix.de>; van.freenix@gmail.com; linux-arm-
> > kernel@lists.infradead.org
> > Subject: Re: [PATCH] arm: imx: suspend/resume: use outer_disable/resume
> > 
> > On Sun, Dec 10, 2017 at 08:07:18PM +0800, Peng Fan wrote:
> > > Use outer_disable/resume for suspend/resume.
> > > With the two APIs used, code could be simplified and easy to extend to
> > > introduce l2c_write_sec for i.MX platforms when moving Linux Kernel
> > > runs in non-secure world.
> > >
> > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > > Cc: Shawn Guo <shawnguo@kernel.org>
> > > Cc: Sascha Hauer <kernel@pengutronix.de>
> > > Cc: Fabio Estevam <fabio.estevam@nxp.com>
> > > Cc: Russell King <linux@armlinux.org.uk>
> > > Cc: Dong Aisheng <aisheng.dong@nxp.com>
> > > ---
> > >  arch/arm/mach-imx/pm-imx6.c      |  2 ++
> > >  arch/arm/mach-imx/suspend-imx6.S | 24 ------------------------
> > 
> > I'm fine with the patch in general.  But this piece of code is running on a few
> > i.MX6 platforms, and I'm wondering on which SoCs you have verified the
> > change work fine.
> 
> I tested it on 6Q-SDB board. Is it ok?

Okay, I will get it into linux-next for a bit wider testing.

Shawn

  reply	other threads:[~2017-12-26  9:09 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-10 12:07 [PATCH] arm: imx: suspend/resume: use outer_disable/resume Peng Fan
2017-12-10 12:07 ` Peng Fan
2017-12-25  1:24 ` Peng Fan
2017-12-25  1:24   ` Peng Fan
2017-12-26  3:31 ` Shawn Guo
2017-12-26  3:31   ` Shawn Guo
2017-12-26  6:52   ` Peng Fan
2017-12-26  6:52     ` Peng Fan
2017-12-26  9:09     ` Shawn Guo [this message]
2017-12-26  9:09       ` Shawn Guo
2017-12-26  9:18       ` Peng Fan
2017-12-26  9:18         ` Peng Fan
2017-12-26  9:12 ` Shawn Guo
2017-12-26  9:12   ` Shawn Guo
2017-12-26  9:49   ` Peng Fan
2017-12-26  9:49     ` Peng Fan
2017-12-26 10:03     ` Dong Aisheng
2017-12-26 10:03       ` Dong Aisheng
2017-12-26 10:11       ` Peng Fan
2017-12-26 10:11         ` Peng Fan
2017-12-26 10:20         ` Dong Aisheng
2017-12-26 10:20           ` Dong Aisheng
2017-12-26 10:36           ` Dong Aisheng
2017-12-26 10:36             ` Dong Aisheng
2017-12-27  2:07             ` Shawn Guo
2017-12-27  2:07               ` Shawn Guo
2017-12-27  0:54           ` Peng Fan
2017-12-27  0:54             ` Peng Fan
2017-12-27  1:36     ` Shawn Guo
2017-12-27  1:36       ` Shawn Guo
2017-12-27  2:19     ` Peng Fan
2017-12-27  2:19       ` Peng Fan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171226090902.GO23070@X250 \
    --to=shawnguo@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.