From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: imx: suspend/resume: use outer_disable/resume
Date: Wed, 27 Dec 2017 10:07:50 +0800 [thread overview]
Message-ID: <20171227020749.GU23070@X250> (raw)
In-Reply-To: <20171226103629.GC11724@b29396-OptiPlex-7040>
On Tue, Dec 26, 2017 at 06:36:29PM +0800, Dong Aisheng wrote:
> > > > diff --git a/arch/arm/mach-imx/cpuidle-imx6sx.c b/arch/arm/mach-
> > > > imx/cpuidle-imx6sx.c
> > > > index c5a5c3a..edce5bd 100644
> > > > --- a/arch/arm/mach-imx/cpuidle-imx6sx.c
> > > > +++ b/arch/arm/mach-imx/cpuidle-imx6sx.c
> > > > @@ -26,7 +26,7 @@ static int imx6sx_idle_finish(unsigned long val)
> > > > * to adding conditional code for L2 cache type,
> > > > * just call flush_cache_all() is fine.
> > > > */
> > > > - flush_cache_all();
> > > > +// flush_cache_all();
> > >
> > > I think flush_cache_all is still needed, to flush L1 data, right?
> > >
> >
> > I thought it will be done in generic cpu_suspend.
> > See: __cpu_suspend_save()
> >
> > So we still need it?
> >
>
> Shawn,
>
> Do you have comments about it?
It seems that there are comments about this flush_cache_all() call right
above it. To be safe, I would suggest to keep it as it is.
Shawn
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Dong Aisheng <dongas86@gmail.com>
Cc: Peng Fan <peng.fan@nxp.com>, "A.s. Dong" <aisheng.dong@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Russell King <linux@armlinux.org.uk>,
Fabio Estevam <fabio.estevam@nxp.com>,
Sascha Hauer <kernel@pengutronix.de>,
"van.freenix@gmail.com" <van.freenix@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] arm: imx: suspend/resume: use outer_disable/resume
Date: Wed, 27 Dec 2017 10:07:50 +0800 [thread overview]
Message-ID: <20171227020749.GU23070@X250> (raw)
In-Reply-To: <20171226103629.GC11724@b29396-OptiPlex-7040>
On Tue, Dec 26, 2017 at 06:36:29PM +0800, Dong Aisheng wrote:
> > > > diff --git a/arch/arm/mach-imx/cpuidle-imx6sx.c b/arch/arm/mach-
> > > > imx/cpuidle-imx6sx.c
> > > > index c5a5c3a..edce5bd 100644
> > > > --- a/arch/arm/mach-imx/cpuidle-imx6sx.c
> > > > +++ b/arch/arm/mach-imx/cpuidle-imx6sx.c
> > > > @@ -26,7 +26,7 @@ static int imx6sx_idle_finish(unsigned long val)
> > > > * to adding conditional code for L2 cache type,
> > > > * just call flush_cache_all() is fine.
> > > > */
> > > > - flush_cache_all();
> > > > +// flush_cache_all();
> > >
> > > I think flush_cache_all is still needed, to flush L1 data, right?
> > >
> >
> > I thought it will be done in generic cpu_suspend.
> > See: __cpu_suspend_save()
> >
> > So we still need it?
> >
>
> Shawn,
>
> Do you have comments about it?
It seems that there are comments about this flush_cache_all() call right
above it. To be safe, I would suggest to keep it as it is.
Shawn
next prev parent reply other threads:[~2017-12-27 2:07 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-10 12:07 [PATCH] arm: imx: suspend/resume: use outer_disable/resume Peng Fan
2017-12-10 12:07 ` Peng Fan
2017-12-25 1:24 ` Peng Fan
2017-12-25 1:24 ` Peng Fan
2017-12-26 3:31 ` Shawn Guo
2017-12-26 3:31 ` Shawn Guo
2017-12-26 6:52 ` Peng Fan
2017-12-26 6:52 ` Peng Fan
2017-12-26 9:09 ` Shawn Guo
2017-12-26 9:09 ` Shawn Guo
2017-12-26 9:18 ` Peng Fan
2017-12-26 9:18 ` Peng Fan
2017-12-26 9:12 ` Shawn Guo
2017-12-26 9:12 ` Shawn Guo
2017-12-26 9:49 ` Peng Fan
2017-12-26 9:49 ` Peng Fan
2017-12-26 10:03 ` Dong Aisheng
2017-12-26 10:03 ` Dong Aisheng
2017-12-26 10:11 ` Peng Fan
2017-12-26 10:11 ` Peng Fan
2017-12-26 10:20 ` Dong Aisheng
2017-12-26 10:20 ` Dong Aisheng
2017-12-26 10:36 ` Dong Aisheng
2017-12-26 10:36 ` Dong Aisheng
2017-12-27 2:07 ` Shawn Guo [this message]
2017-12-27 2:07 ` Shawn Guo
2017-12-27 0:54 ` Peng Fan
2017-12-27 0:54 ` Peng Fan
2017-12-27 1:36 ` Shawn Guo
2017-12-27 1:36 ` Shawn Guo
2017-12-27 2:19 ` Peng Fan
2017-12-27 2:19 ` Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171227020749.GU23070@X250 \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.