From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Kai-Heng Feng <kai.heng.feng@canonical.com>,
linux-usb@vger.kernel.org,
"open list:BLUETOOTH DRIVERS" <linux-bluetooth@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
stable <stable@vger.kernel.org>,
Leif Liddy <leif.linux@gmail.com>,
Matthias Kaehlcke <mka@chromium.org>,
Brian Norris <briannorris@chromium.org>,
Daniel Drake <drake@endlessm.com>
Subject: Re: [PATCH 2/2] usb: quirks: Add reset-resume quirk for Dell DW1820 QCA Rome Bluetooth
Date: Wed, 27 Dec 2017 13:52:04 +0100 [thread overview]
Message-ID: <20171227125204.GE3373@kroah.com> (raw)
In-Reply-To: <FC2D8E58-CA2D-4115-9E62-DF6D69A483CF@holtmann.org>
On Tue, Dec 26, 2017 at 10:01:46PM +0100, Marcel Holtmann wrote:
> Hi Greg,
>
> > Commit ("fd865802c66bc451dc515ed89360f84376ce1a56 Bluetooth: btusb: fix
> > QCA Rome suspend/resume") enables reset_resume in btusb_probe(). This
> > makes the device resets during btusb_open(), firmware loading gets
> > interrupted as a result.
> >
> > We still want to reset the device to solve the original issue, but we
> > should do it before btusb_open().
> >
> > Hence, add reset-resume quirk in usb core intead of btusb.
> >
> > Cc: stable@vger.kernel.org
> > Cc: Leif Liddy <leif.linux@gmail.com>
> > Cc: Matthias Kaehlcke <mka@chromium.org>
> > Cc: Brian Norris <briannorris@chromium.org>
> > Cc: Daniel Drake <drake@endlessm.com>
> > Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> >
> > ---
> > drivers/usb/core/quirks.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> > index a10b346b9777..96951104c45b 100644
> > --- a/drivers/usb/core/quirks.c
> > +++ b/drivers/usb/core/quirks.c
> > @@ -197,6 +197,9 @@ static const struct usb_device_id usb_quirk_list[] = {
> > { USB_DEVICE(0x0b05, 0x17e0), .driver_info =
> > USB_QUIRK_IGNORE_REMOTE_WAKEUP },
> >
> > + /* QCA Rome Bluetooth in Dell DW1820 wireless module */
> > + { USB_DEVICE(0x0cf3, 0xe007), .driver_info = USB_QUIRK_RESET_RESUME },
> > +
>
> can I get an ACK from you to take this patch through bluetooth-next tree? Or are you planning to take it?
It's not in my queue at all, so I didn't even have the chance to take it
:)
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Kai-Heng Feng <kai.heng.feng@canonical.com>,
linux-usb@vger.kernel.org,
"open list:BLUETOOTH DRIVERS" <linux-bluetooth@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
stable <stable@vger.kernel.org>,
Leif Liddy <leif.linux@gmail.com>,
Matthias Kaehlcke <mka@chromium.org>,
Brian Norris <briannorris@chromium.org>,
Daniel Drake <drake@endlessm.com>
Subject: [2/2] usb: quirks: Add reset-resume quirk for Dell DW1820 QCA Rome Bluetooth
Date: Wed, 27 Dec 2017 13:52:04 +0100 [thread overview]
Message-ID: <20171227125204.GE3373@kroah.com> (raw)
On Tue, Dec 26, 2017 at 10:01:46PM +0100, Marcel Holtmann wrote:
> Hi Greg,
>
> > Commit ("fd865802c66bc451dc515ed89360f84376ce1a56 Bluetooth: btusb: fix
> > QCA Rome suspend/resume") enables reset_resume in btusb_probe(). This
> > makes the device resets during btusb_open(), firmware loading gets
> > interrupted as a result.
> >
> > We still want to reset the device to solve the original issue, but we
> > should do it before btusb_open().
> >
> > Hence, add reset-resume quirk in usb core intead of btusb.
> >
> > Cc: stable@vger.kernel.org
> > Cc: Leif Liddy <leif.linux@gmail.com>
> > Cc: Matthias Kaehlcke <mka@chromium.org>
> > Cc: Brian Norris <briannorris@chromium.org>
> > Cc: Daniel Drake <drake@endlessm.com>
> > Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> >
> > ---
> > drivers/usb/core/quirks.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> > index a10b346b9777..96951104c45b 100644
> > --- a/drivers/usb/core/quirks.c
> > +++ b/drivers/usb/core/quirks.c
> > @@ -197,6 +197,9 @@ static const struct usb_device_id usb_quirk_list[] = {
> > { USB_DEVICE(0x0b05, 0x17e0), .driver_info =
> > USB_QUIRK_IGNORE_REMOTE_WAKEUP },
> >
> > + /* QCA Rome Bluetooth in Dell DW1820 wireless module */
> > + { USB_DEVICE(0x0cf3, 0xe007), .driver_info = USB_QUIRK_RESET_RESUME },
> > +
>
> can I get an ACK from you to take this patch through bluetooth-next tree? Or are you planning to take it?
It's not in my queue at all, so I didn't even have the chance to take it
:)
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-12-27 12:52 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-20 11:00 [PATCH 1/2] Revert "Bluetooth: btusb: fix QCA Rome suspend/resume" Kai-Heng Feng
2017-12-20 11:00 ` [1/2] " Kai-Heng Feng
2017-12-20 11:00 ` [PATCH 2/2] usb: quirks: Add reset-resume quirk for Dell DW1820 QCA Rome Bluetooth Kai-Heng Feng
2017-12-20 11:00 ` [2/2] " Kai-Heng Feng
2017-12-26 21:01 ` [PATCH 2/2] " Marcel Holtmann
2017-12-26 21:01 ` [2/2] " Marcel Holtmann
2017-12-27 12:52 ` Greg Kroah-Hartman [this message]
2017-12-27 12:52 ` Greg Kroah-Hartman
2017-12-28 11:59 ` [PATCH 2/2] " Leif Liddy
2017-12-28 11:59 ` [2/2] " Leif Liddy
2017-12-28 20:15 ` [PATCH 2/2] " Marcel Holtmann
2017-12-28 20:15 ` [2/2] " Marcel Holtmann
2017-12-20 18:53 ` [PATCH 1/2] Revert "Bluetooth: btusb: fix QCA Rome suspend/resume" Brian Norris
2017-12-20 18:53 ` [1/2] " Brian Norris
2017-12-21 11:43 ` [PATCH 1/2] " Daniel Drake
2017-12-21 11:43 ` [1/2] " Daniel Drake
2017-12-21 17:31 ` [PATCH 1/2] " Brian Norris
2017-12-21 17:31 ` [1/2] " Brian Norris
2018-01-02 10:06 ` [PATCH 1/2] " Kai Heng Feng
2018-01-02 10:06 ` Kai Heng Feng
2018-01-02 10:06 ` [1/2] " Kai-Heng Feng
2017-12-26 21:00 ` [PATCH 1/2] " Marcel Holtmann
2017-12-26 21:00 ` [1/2] " Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171227125204.GE3373@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=briannorris@chromium.org \
--cc=drake@endlessm.com \
--cc=kai.heng.feng@canonical.com \
--cc=leif.linux@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mka@chromium.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.