All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vinod Koul <vinod.koul@intel.com>
To: Kedareswara rao Appana <appana.durga.rao@xilinx.com>
Cc: dan.j.williams@intel.com, michal.simek@xilinx.com,
	appanad@xilinx.com, lars@metafoo.de, akinobu.mita@gmail.com,
	joabreu@synopsys.com, mike.looijmans@topic.nl,
	kedare06@gmail.com, dmaengine@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: [LINUX,3/4] dmaengine: xilinx_dma: Fix compilation warning
Date: Wed, 3 Jan 2018 09:29:18 +0530	[thread overview]
Message-ID: <20180103035918.GH18649@localhost> (raw)

On Thu, Dec 21, 2017 at 03:41:37PM +0530, Kedareswara rao Appana wrote:

Fix title here too

BTW whats with LINUX tag in patches, pls drop them

> This patch fixes the below sparse warning in the driver
> drivers/dma/xilinx/xilinx_dma.c: In function ‘xilinx_vdma_dma_prep_interleaved’:
> drivers/dma/xilinx/xilinx_dma.c:1614:43: warning: variable ‘prev’ set but not used [-Wunused-but-set-variable]
>   struct xilinx_vdma_tx_segment *segment, *prev = NULL;
> 
> Signed-off-by: Kedareswara rao Appana <appanad@xilinx.com>
> ---
>  drivers/dma/xilinx/xilinx_dma.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c
> index 8467671..845e638 100644
> --- a/drivers/dma/xilinx/xilinx_dma.c
> +++ b/drivers/dma/xilinx/xilinx_dma.c
> @@ -1611,7 +1611,7 @@ xilinx_vdma_dma_prep_interleaved(struct dma_chan *dchan,
>  {
>  	struct xilinx_dma_chan *chan = to_xilinx_chan(dchan);
>  	struct xilinx_dma_tx_descriptor *desc;
> -	struct xilinx_vdma_tx_segment *segment, *prev = NULL;
> +	struct xilinx_vdma_tx_segment *segment;
>  	struct xilinx_vdma_desc_hw *hw;
>  
>  	if (!is_slave_direction(xt->dir))
> @@ -1665,8 +1665,6 @@ xilinx_vdma_dma_prep_interleaved(struct dma_chan *dchan,
>  	/* Insert the segment into the descriptor segments list. */
>  	list_add_tail(&segment->node, &desc->segments);
>  
> -	prev = segment;
> -
>  	/* Link the last hardware descriptor with the first. */
>  	segment = list_first_entry(&desc->segments,
>  				   struct xilinx_vdma_tx_segment, node);
> -- 
> 2.7.4
>

WARNING: multiple messages have this Message-ID (diff)
From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [LINUX PATCH 3/4] dmaengine: xilinx_dma: Fix compilation warning
Date: Wed, 3 Jan 2018 09:29:18 +0530	[thread overview]
Message-ID: <20180103035918.GH18649@localhost> (raw)
In-Reply-To: <1513851098-15787-4-git-send-email-appanad@xilinx.com>

On Thu, Dec 21, 2017 at 03:41:37PM +0530, Kedareswara rao Appana wrote:

Fix title here too

BTW whats with LINUX tag in patches, pls drop them

> This patch fixes the below sparse warning in the driver
> drivers/dma/xilinx/xilinx_dma.c: In function ?xilinx_vdma_dma_prep_interleaved?:
> drivers/dma/xilinx/xilinx_dma.c:1614:43: warning: variable ?prev? set but not used [-Wunused-but-set-variable]
>   struct xilinx_vdma_tx_segment *segment, *prev = NULL;
> 
> Signed-off-by: Kedareswara rao Appana <appanad@xilinx.com>
> ---
>  drivers/dma/xilinx/xilinx_dma.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c
> index 8467671..845e638 100644
> --- a/drivers/dma/xilinx/xilinx_dma.c
> +++ b/drivers/dma/xilinx/xilinx_dma.c
> @@ -1611,7 +1611,7 @@ xilinx_vdma_dma_prep_interleaved(struct dma_chan *dchan,
>  {
>  	struct xilinx_dma_chan *chan = to_xilinx_chan(dchan);
>  	struct xilinx_dma_tx_descriptor *desc;
> -	struct xilinx_vdma_tx_segment *segment, *prev = NULL;
> +	struct xilinx_vdma_tx_segment *segment;
>  	struct xilinx_vdma_desc_hw *hw;
>  
>  	if (!is_slave_direction(xt->dir))
> @@ -1665,8 +1665,6 @@ xilinx_vdma_dma_prep_interleaved(struct dma_chan *dchan,
>  	/* Insert the segment into the descriptor segments list. */
>  	list_add_tail(&segment->node, &desc->segments);
>  
> -	prev = segment;
> -
>  	/* Link the last hardware descriptor with the first. */
>  	segment = list_first_entry(&desc->segments,
>  				   struct xilinx_vdma_tx_segment, node);
> -- 
> 2.7.4
> 

-- 
~Vinod

WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vinod.koul@intel.com>
To: Kedareswara rao Appana <appana.durga.rao@xilinx.com>
Cc: dan.j.williams@intel.com, michal.simek@xilinx.com,
	appanad@xilinx.com, lars@metafoo.de, akinobu.mita@gmail.com,
	joabreu@synopsys.com, mike.looijmans@topic.nl,
	kedare06@gmail.com, dmaengine@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [LINUX PATCH 3/4] dmaengine: xilinx_dma: Fix compilation warning
Date: Wed, 3 Jan 2018 09:29:18 +0530	[thread overview]
Message-ID: <20180103035918.GH18649@localhost> (raw)
In-Reply-To: <1513851098-15787-4-git-send-email-appanad@xilinx.com>

On Thu, Dec 21, 2017 at 03:41:37PM +0530, Kedareswara rao Appana wrote:

Fix title here too

BTW whats with LINUX tag in patches, pls drop them

> This patch fixes the below sparse warning in the driver
> drivers/dma/xilinx/xilinx_dma.c: In function ‘xilinx_vdma_dma_prep_interleaved’:
> drivers/dma/xilinx/xilinx_dma.c:1614:43: warning: variable ‘prev’ set but not used [-Wunused-but-set-variable]
>   struct xilinx_vdma_tx_segment *segment, *prev = NULL;
> 
> Signed-off-by: Kedareswara rao Appana <appanad@xilinx.com>
> ---
>  drivers/dma/xilinx/xilinx_dma.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c
> index 8467671..845e638 100644
> --- a/drivers/dma/xilinx/xilinx_dma.c
> +++ b/drivers/dma/xilinx/xilinx_dma.c
> @@ -1611,7 +1611,7 @@ xilinx_vdma_dma_prep_interleaved(struct dma_chan *dchan,
>  {
>  	struct xilinx_dma_chan *chan = to_xilinx_chan(dchan);
>  	struct xilinx_dma_tx_descriptor *desc;
> -	struct xilinx_vdma_tx_segment *segment, *prev = NULL;
> +	struct xilinx_vdma_tx_segment *segment;
>  	struct xilinx_vdma_desc_hw *hw;
>  
>  	if (!is_slave_direction(xt->dir))
> @@ -1665,8 +1665,6 @@ xilinx_vdma_dma_prep_interleaved(struct dma_chan *dchan,
>  	/* Insert the segment into the descriptor segments list. */
>  	list_add_tail(&segment->node, &desc->segments);
>  
> -	prev = segment;
> -
>  	/* Link the last hardware descriptor with the first. */
>  	segment = list_first_entry(&desc->segments,
>  				   struct xilinx_vdma_tx_segment, node);
> -- 
> 2.7.4
> 

-- 
~Vinod

             reply	other threads:[~2018-01-03  3:59 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-03  3:59 Vinod Koul [this message]
2018-01-03  3:59 ` [LINUX PATCH 3/4] dmaengine: xilinx_dma: Fix compilation warning Vinod Koul
2018-01-03  3:59 ` Vinod Koul
  -- strict thread matches above, loose matches on Subject: below --
2018-01-03  9:09 [LINUX,3/4] " Appana Durga Kedareswara Rao
2018-01-03  9:09 ` [LINUX PATCH 3/4] " Appana Durga Kedareswara Rao
2018-01-03  9:09 ` Appana Durga Kedareswara Rao
2018-01-03  6:10 [LINUX,3/4] " Appana Durga Kedareswara Rao
2018-01-03  6:10 ` [LINUX PATCH 3/4] " Appana Durga Kedareswara Rao
2018-01-03  6:10 ` Appana Durga Kedareswara Rao
2018-01-03  5:27 [LINUX,3/4] " Vinod Koul
2018-01-03  5:27 ` [LINUX PATCH 3/4] " Vinod Koul
2018-01-03  5:27 ` Vinod Koul
2018-01-03  5:13 [LINUX,3/4] " Appana Durga Kedareswara Rao
2018-01-03  5:13 ` [LINUX PATCH 3/4] " Appana Durga Kedareswara Rao
2018-01-03  5:13 ` Appana Durga Kedareswara Rao
2018-01-03  5:10 [LINUX,2/4] dmaengine: xilinx_dma: Fix race condition in the driver for cdma Appana Durga Kedareswara Rao
2018-01-03  5:10 ` [LINUX PATCH 2/4] " Appana Durga Kedareswara Rao
2018-01-03  5:10 ` Appana Durga Kedareswara Rao
2018-01-03  5:09 [LINUX,1/4] dmaengine: xilinx_dma: Fix dma_get_slave_caps() API failures Appana Durga Kedareswara Rao
2018-01-03  5:09 ` [LINUX PATCH 1/4] " Appana Durga Kedareswara Rao
2018-01-03  5:09 ` Appana Durga Kedareswara Rao
2018-01-03  3:58 [LINUX,2/4] dmaengine: xilinx_dma: Fix race condition in the driver for cdma Vinod Koul
2018-01-03  3:58 ` [LINUX PATCH 2/4] " Vinod Koul
2018-01-03  3:58 ` Vinod Koul
2018-01-03  3:57 [LINUX,1/4] dmaengine: xilinx_dma: Fix dma_get_slave_caps() API failures Vinod Koul
2018-01-03  3:57 ` [LINUX PATCH 1/4] " Vinod Koul
2018-01-03  3:57 ` Vinod Koul
2017-12-21 10:11 [LINUX,4/4] dmaengine: xilinx_dma: Free BD consistent memory Kedareswara rao Appana
2017-12-21 10:11 ` [LINUX PATCH 4/4] " Kedareswara rao Appana
2017-12-21 10:11 ` Kedareswara rao Appana
2017-12-21 10:11 [LINUX,3/4] dmaengine: xilinx_dma: Fix compilation warning Kedareswara rao Appana
2017-12-21 10:11 ` [LINUX PATCH 3/4] " Kedareswara rao Appana
2017-12-21 10:11 ` Kedareswara rao Appana
2017-12-21 10:11 [LINUX,2/4] dmaengine: xilinx_dma: Fix race condition in the driver for cdma Kedareswara rao Appana
2017-12-21 10:11 ` [LINUX PATCH 2/4] " Kedareswara rao Appana
2017-12-21 10:11 ` Kedareswara rao Appana
2017-12-21 10:11 [LINUX,1/4] dmaengine: xilinx_dma: Fix dma_get_slave_caps() API failures Kedareswara rao Appana
2017-12-21 10:11 ` [LINUX PATCH 1/4] " Kedareswara rao Appana
2017-12-21 10:11 ` Kedareswara rao Appana
2017-12-21 10:11 [LINUX PATCH 0/4] dmaengine: xilinx_dma: Bug fixes Kedareswara rao Appana
2017-12-21 10:11 ` Kedareswara rao Appana

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180103035918.GH18649@localhost \
    --to=vinod.koul@intel.com \
    --cc=akinobu.mita@gmail.com \
    --cc=appana.durga.rao@xilinx.com \
    --cc=appanad@xilinx.com \
    --cc=dan.j.williams@intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=joabreu@synopsys.com \
    --cc=kedare06@gmail.com \
    --cc=lars@metafoo.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=mike.looijmans@topic.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.