From: Yang Zhong <yang.zhong@intel.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: yang.zhong@intel.com, andrew.cooper3@citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH v4 4/4] x86/cpuid: Enable new SSE/AVX/AVX512 cpu features
Date: Thu, 4 Jan 2018 14:06:32 +0800 [thread overview]
Message-ID: <20180104060632.GA11726@yangzhon-Virtual> (raw)
In-Reply-To: <5A4CA661020000780019A5FC@prv-mh.provo.novell.com>
On Wed, Jan 03, 2018 at 01:46:09AM -0700, Jan Beulich wrote:
> > --- a/xen/include/public/arch-x86/cpufeatureset.h
> > +++ b/xen/include/public/arch-x86/cpufeatureset.h
> > @@ -228,6 +228,12 @@ XEN_CPUFEATURE(AVX512VBMI, 6*32+ 1) /*A AVX-512 Vector Byte Manipulation Ins
> > XEN_CPUFEATURE(UMIP, 6*32+ 2) /*S User Mode Instruction Prevention */
> > XEN_CPUFEATURE(PKU, 6*32+ 3) /*H Protection Keys for Userspace */
> > XEN_CPUFEATURE(OSPKE, 6*32+ 4) /*! OS Protection Keys Enable */
> > +XEN_CPUFEATURE(AVX512_VBMI2, 6*32+ 6) /*A addition AVX-512 VBMI Instructions */
>
> "additional"?
Jan, i will change "addition" to "additional", thanks! Yang.
> > --- a/xen/tools/gen-cpuid.py
> > +++ b/xen/tools/gen-cpuid.py
> > @@ -255,7 +255,8 @@ def crunch_numbers(state):
> > # top of AVX512F
> > AVX512F: [AVX512DQ, AVX512IFMA, AVX512PF, AVX512ER, AVX512CD,
> > AVX512BW, AVX512VL, AVX512VBMI, AVX512_4VNNIW,
> > - AVX512_4FMAPS, AVX512_VPOPCNTDQ],
> > + AVX512_4FMAPS, AVX512_VPOPCNTDQ, AVX512_VBMI2,
> > + AVX512_VNNI, AVX512_BITALG],
> > }
>
> This is insufficient afaict: VAES and VPCLMULQDQ ought to be
> made dependent upon AVX.
Thanks Jan, i will do below changes for this. Yang.
- AVX: [FMA, FMA4, F16C, AVX2, XOP],
+ AVX: [FMA, FMA4, F16C, AVX2, XOP, VAES, VPCLMULQDQ],
>
> Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-01-04 6:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-03 8:26 [PATCH v4 0/4] x86/cpuid: enable new cpu features Yang Zhong
2018-01-03 8:26 ` [PATCH v4 1/4] x86emul: Support GFNI insns Yang Zhong
2018-01-03 17:00 ` Jan Beulich
2018-01-04 9:20 ` Yang Zhong
2018-01-04 11:02 ` Jan Beulich
2018-01-03 8:26 ` [PATCH v4 2/4] x86emul: Support vpclmulqdq Yang Zhong
2018-01-18 14:05 ` Jan Beulich
2018-01-03 8:26 ` [PATCH v4 3/4] x86emul: Support vaes insns Yang Zhong
2018-01-18 14:13 ` Jan Beulich
2018-01-23 12:56 ` Yang Zhong
2018-01-23 13:27 ` Jan Beulich
2018-01-03 8:26 ` [PATCH v4 4/4] x86/cpuid: Enable new SSE/AVX/AVX512 cpu features Yang Zhong
2018-01-03 8:46 ` Jan Beulich
2018-01-04 6:06 ` Yang Zhong [this message]
[not found] ` <5A4CA485020000780019A5DD@prv-mh.provo.novell.com>
2018-01-04 6:08 ` [PATCH v4 0/4] x86/cpuid: enable new " Yang Zhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180104060632.GA11726@yangzhon-Virtual \
--to=yang.zhong@intel.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.