All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jerome Brunet <jbrunet@baylibre.com>
To: Stephen Boyd <sboyd@codeaurora.org>,
	Michael Turquette <mturquette@baylibre.com>,
	linux-clk@vger.kernel.org
Cc: Jerome Brunet <jbrunet@baylibre.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-arm-msm@vger.kernel.org, Vladimir Zapolskiy <vz@mleia.com>,
	Sylvain Lemieux <slemieux.tyco@gmail.com>,
	Andy Gross <andy.gross@linaro.org>,
	David Brown <david.brown@linaro.org>
Subject: [PATCH 0/5] clk: read-only dividers and rate propagation fixup
Date: Fri,  5 Jan 2018 18:09:54 +0100	[thread overview]
Message-ID: <20180105170959.17266-1-jbrunet@baylibre.com> (raw)

A read-only divider may also have CLK_SET_RATE_PARENT flag set, in which
case it should propagate the requested rate to its parent, taking the
read-only divider value into account.

While this is done correctly in qcom's clk-regmap-divider, it is not in
the generic divider and lpc32xx.

Other drivers using divider_round_rate are not impacted because they are
using hard-coded flags without CLK_DIVIDER_READ_ONLY, so read-only
dividers does seems to be concern for them and rate propagation should
work as expected

Jerome Brunet (5):
  clk: divider: read-only divider can propagate rate change
  clk: lpc32xx: read-only divider can propagate rate change
  clk: divider: add divider_ro_round_rate helper
  clk: lpc32xx: use divider_ro_round_rate helper
  clk: qcom: use divider_ro_round_rate helper

 drivers/clk/clk-divider.c             | 35 +++++++++++++++++++++++++++++------
 drivers/clk/nxp/clk-lpc32xx.c         | 15 ++++++++-------
 drivers/clk/qcom/clk-regmap-divider.c | 19 ++++++-------------
 include/linux/clk-provider.h          | 15 +++++++++++++++
 4 files changed, 58 insertions(+), 26 deletions(-)

-- 
2.14.3

WARNING: multiple messages have this Message-ID (diff)
From: jbrunet@baylibre.com (Jerome Brunet)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/5] clk: read-only dividers and rate propagation fixup
Date: Fri,  5 Jan 2018 18:09:54 +0100	[thread overview]
Message-ID: <20180105170959.17266-1-jbrunet@baylibre.com> (raw)

A read-only divider may also have CLK_SET_RATE_PARENT flag set, in which
case it should propagate the requested rate to its parent, taking the
read-only divider value into account.

While this is done correctly in qcom's clk-regmap-divider, it is not in
the generic divider and lpc32xx.

Other drivers using divider_round_rate are not impacted because they are
using hard-coded flags without CLK_DIVIDER_READ_ONLY, so read-only
dividers does seems to be concern for them and rate propagation should
work as expected

Jerome Brunet (5):
  clk: divider: read-only divider can propagate rate change
  clk: lpc32xx: read-only divider can propagate rate change
  clk: divider: add divider_ro_round_rate helper
  clk: lpc32xx: use divider_ro_round_rate helper
  clk: qcom: use divider_ro_round_rate helper

 drivers/clk/clk-divider.c             | 35 +++++++++++++++++++++++++++++------
 drivers/clk/nxp/clk-lpc32xx.c         | 15 ++++++++-------
 drivers/clk/qcom/clk-regmap-divider.c | 19 ++++++-------------
 include/linux/clk-provider.h          | 15 +++++++++++++++
 4 files changed, 58 insertions(+), 26 deletions(-)

-- 
2.14.3

             reply	other threads:[~2018-01-05 17:10 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-05 17:09 Jerome Brunet [this message]
2018-01-05 17:09 ` [PATCH 0/5] clk: read-only dividers and rate propagation fixup Jerome Brunet
2018-01-05 17:09 ` [PATCH 1/5] clk: divider: read-only divider can propagate rate change Jerome Brunet
2018-01-05 17:09   ` Jerome Brunet
2018-01-05 17:09   ` Jerome Brunet
2018-01-11 22:55   ` [1/5] " David Lechner
2018-01-11 22:55     ` David Lechner
2018-01-17 16:39     ` Jerome Brunet
2018-01-17 16:39       ` Jerome Brunet
2018-01-05 17:09 ` [PATCH 2/5] clk: lpc32xx: " Jerome Brunet
2018-01-05 17:09   ` Jerome Brunet
2018-01-05 18:12   ` Vladimir Zapolskiy
2018-01-05 18:12     ` Vladimir Zapolskiy
2018-01-05 19:40     ` Jerome Brunet
2018-01-05 19:40       ` Jerome Brunet
2018-01-06 14:04       ` Vladimir Zapolskiy
2018-01-06 14:04         ` Vladimir Zapolskiy
2018-01-08  9:10         ` Jerome Brunet
2018-01-08  9:10           ` Jerome Brunet
2018-01-05 17:09 ` [PATCH 3/5] clk: divider: add divider_ro_round_rate helper Jerome Brunet
2018-01-05 17:09   ` Jerome Brunet
2018-01-11 23:08   ` [3/5] " David Lechner
2018-01-11 23:08     ` David Lechner
2018-01-17 17:47     ` Jerome Brunet
2018-01-17 17:47       ` Jerome Brunet
2018-01-17 17:55       ` David Lechner
2018-01-17 17:55         ` David Lechner
2018-01-05 17:09 ` [PATCH 4/5] clk: lpc32xx: use " Jerome Brunet
2018-01-05 17:09   ` Jerome Brunet
2018-01-05 17:09 ` [PATCH 5/5] clk: qcom: " Jerome Brunet
2018-01-05 17:09   ` Jerome Brunet
2018-01-08 10:04   ` Jerome Brunet
2018-01-08 10:04     ` Jerome Brunet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180105170959.17266-1-jbrunet@baylibre.com \
    --to=jbrunet@baylibre.com \
    --cc=andy.gross@linaro.org \
    --cc=david.brown@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@codeaurora.org \
    --cc=slemieux.tyco@gmail.com \
    --cc=vz@mleia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.