From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [PATCH v2 12/15] thunderx: use _rte_eth_linkstatus_set
Date: Fri, 5 Jan 2018 17:06:53 -0800 [thread overview]
Message-ID: <20180106010656.9167-13-stephen@networkplumber.org> (raw)
In-Reply-To: <20180106010656.9167-1-stephen@networkplumber.org>
Use new helper function.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/thunderx/nicvf_ethdev.c | 17 ++---------------
1 file changed, 2 insertions(+), 15 deletions(-)
diff --git a/drivers/net/thunderx/nicvf_ethdev.c b/drivers/net/thunderx/nicvf_ethdev.c
index d65d3cee727e..e41b379f3c9c 100644
--- a/drivers/net/thunderx/nicvf_ethdev.c
+++ b/drivers/net/thunderx/nicvf_ethdev.c
@@ -43,7 +43,6 @@
#include <sys/queue.h>
#include <rte_alarm.h>
-#include <rte_atomic.h>
#include <rte_branch_prediction.h>
#include <rte_byteorder.h>
#include <rte_common.h>
@@ -76,19 +75,6 @@ static void nicvf_dev_stop_cleanup(struct rte_eth_dev *dev, bool cleanup);
static void nicvf_vf_stop(struct rte_eth_dev *dev, struct nicvf *nic,
bool cleanup);
-static inline int
-nicvf_atomic_write_link_status(struct rte_eth_dev *dev,
- struct rte_eth_link *link)
-{
- struct rte_eth_link *dst = &dev->data->dev_link;
- struct rte_eth_link *src = link;
-
- if (rte_atomic64_cmpset((uint64_t *)dst, *(uint64_t *)dst,
- *(uint64_t *)src) == 0)
- return -1;
-
- return 0;
-}
static inline void
nicvf_set_eth_link_status(struct nicvf *nic, struct rte_eth_link *link)
@@ -170,7 +156,8 @@ nicvf_dev_link_update(struct rte_eth_dev *dev, int wait_to_complete)
memset(&link, 0, sizeof(link));
nicvf_set_eth_link_status(nic, &link);
}
- return nicvf_atomic_write_link_status(dev, &link);
+
+ return _rte_eth_linkstatus_set(dev, &link);
}
static int
--
2.15.1
next prev parent reply other threads:[~2018-01-06 1:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-06 1:06 [PATCH v2 00/15] common ethdev linkstatus functions Stephen Hemminger
2018-01-06 1:06 ` [PATCH v2 01/15] eal: introduce atomic exchange operation Stephen Hemminger
2018-01-06 1:06 ` [PATCH v2 02/15] ethdev: add linkstatus get/set helper functions Stephen Hemminger
2018-01-06 10:49 ` Andrew Rybchenko
2018-01-06 14:24 ` Stephen Hemminger
2018-01-06 14:35 ` Andrew Rybchenko
2018-01-06 1:06 ` [PATCH v2 03/15] virtio: use eth_linkstatus_set Stephen Hemminger
2018-01-06 3:10 ` Tiwei Bie
2018-01-08 17:03 ` Stephen Hemminger
2018-01-06 1:06 ` [PATCH v2 04/15] vmxnet3: use rte_eth_linkstatus_set Stephen Hemminger
2018-01-06 1:06 ` [PATCH v2 05/15] dpaa2: " Stephen Hemminger
2018-01-06 1:06 ` [PATCH v2 06/15] nfp: use rte_eth_linkstatus functions Stephen Hemminger
2018-01-06 1:06 ` [PATCH v2 07/15] e1000: use rte_eth_linkstatus helpers Stephen Hemminger
2018-01-06 1:06 ` [PATCH v2 08/15] ixgbe: use rte_eth_linkstatus functions Stephen Hemminger
2018-01-06 1:06 ` [PATCH v2 09/15] sfc: use new " Stephen Hemminger
2018-01-06 11:10 ` Andrew Rybchenko
2018-01-06 1:06 ` [PATCH v2 10/15] i40e: use " Stephen Hemminger
2018-01-06 1:06 ` [PATCH v2 11/15] liquidio: use _rte_eth_linkstatus_set Stephen Hemminger
2018-01-06 1:06 ` Stephen Hemminger [this message]
2018-01-06 1:06 ` [PATCH v2 13/15] szedata: " Stephen Hemminger
2018-01-06 1:06 ` [PATCH v2 14/15] octeontx: use rte_eth_linkstatus_set Stephen Hemminger
2018-01-06 1:06 ` [PATCH v2 15/15] enic: use _rte_eth_linkstatus_set Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180106010656.9167-13-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.