All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: "Ji-Ze Hong \(Peter Hong\)" <hpeter@gmail.com>
Cc: johan@kernel.org, gregkh@linuxfoundation.org,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	peter_hong@fintek.com.tw,
	"Ji-Ze Hong \(Peter Hong\)" <hpeter+linux_kernel@gmail.com>
Subject: [V2,4/5] usb: serial: f81534: add H/W disable port support
Date: Tue, 9 Jan 2018 12:29:57 +0100	[thread overview]
Message-ID: <20180109112957.GQ11344@localhost> (raw)

On Thu, Jan 04, 2018 at 10:29:20AM +0800, Ji-Ze Hong (Peter Hong) wrote:
> The F81532/534 can be disable port by manufacturer with
> following H/W design.
>     1: Connect DCD/DSR/CTS/RI pin to ground.
>     2: Connect RX pin to ground.
> 
> In driver, we'll implements some detect method likes following:
>     1: Read MSR.
>     2: Turn MCR LOOP bit on, off and read LSR after delay with 60ms.
>        It'll contain BREAK status in LSR.
> 
> Signed-off-by: Ji-Ze Hong (Peter Hong) <hpeter+linux_kernel@gmail.com>
> ---
> V2:
> 	1: f81534_check_port_hw_disabled() change return type from int to bool.
> 	2: Add help function f81534_set_phy_port_register() /
> 	   f81534_get_phy_port_register() for f81534_check_port_hw_disabled()
> 	   to read register without port.
> 	3: Re-write f81534_calc_num_ports() & f81534_attach() to reduce the
> 	   f81534_check_port_hw_disabled() repeatedly called.

This looks good, but please split up the config-data-readout refactoring
and f81534_check_port_hw_disabled() changes in two patches.

Johan
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <johan@kernel.org>
To: "Ji-Ze Hong (Peter Hong)" <hpeter@gmail.com>
Cc: johan@kernel.org, gregkh@linuxfoundation.org,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	peter_hong@fintek.com.tw,
	"Ji-Ze Hong (Peter Hong)" <hpeter+linux_kernel@gmail.com>
Subject: Re: [PATCH V2 4/5] usb: serial: f81534: add H/W disable port support
Date: Tue, 9 Jan 2018 12:29:57 +0100	[thread overview]
Message-ID: <20180109112957.GQ11344@localhost> (raw)
In-Reply-To: <1515032961-29131-4-git-send-email-hpeter+linux_kernel@gmail.com>

On Thu, Jan 04, 2018 at 10:29:20AM +0800, Ji-Ze Hong (Peter Hong) wrote:
> The F81532/534 can be disable port by manufacturer with
> following H/W design.
>     1: Connect DCD/DSR/CTS/RI pin to ground.
>     2: Connect RX pin to ground.
> 
> In driver, we'll implements some detect method likes following:
>     1: Read MSR.
>     2: Turn MCR LOOP bit on, off and read LSR after delay with 60ms.
>        It'll contain BREAK status in LSR.
> 
> Signed-off-by: Ji-Ze Hong (Peter Hong) <hpeter+linux_kernel@gmail.com>
> ---
> V2:
> 	1: f81534_check_port_hw_disabled() change return type from int to bool.
> 	2: Add help function f81534_set_phy_port_register() /
> 	   f81534_get_phy_port_register() for f81534_check_port_hw_disabled()
> 	   to read register without port.
> 	3: Re-write f81534_calc_num_ports() & f81534_attach() to reduce the
> 	   f81534_check_port_hw_disabled() repeatedly called.

This looks good, but please split up the config-data-readout refactoring
and f81534_check_port_hw_disabled() changes in two patches.

Johan

             reply	other threads:[~2018-01-09 11:29 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-09 11:29 Johan Hovold [this message]
2018-01-09 11:29 ` [PATCH V2 4/5] usb: serial: f81534: add H/W disable port support Johan Hovold
  -- strict thread matches above, loose matches on Subject: below --
2018-01-10  9:27 [V2,1/5] usb: serial: f81534: add high baud rate support Johan Hovold
2018-01-10  9:27 ` [PATCH V2 1/5] " Johan Hovold
2018-01-10  9:16 [V2,1/5] " Ji-Ze Hong (Peter Hong)
2018-01-10  9:16 ` [PATCH V2 1/5] " Ji-Ze Hong (Peter Hong)
2018-01-10  8:50 [V2,5/5] usb: serial: f81534: fix tx error on some baud rate Johan Hovold
2018-01-10  8:50 ` [PATCH V2 5/5] " Johan Hovold
2018-01-10  8:49 [V2,1/5] usb: serial: f81534: add high baud rate support Johan Hovold
2018-01-10  8:49 ` [PATCH V2 1/5] " Johan Hovold
2018-01-10  5:42 [V2,5/5] usb: serial: f81534: fix tx error on some baud rate Ji-Ze Hong (Peter Hong)
2018-01-10  5:42 ` [PATCH V2 5/5] " Ji-Ze Hong (Peter Hong)
2018-01-10  5:30 [V2,1/5] usb: serial: f81534: add high baud rate support Ji-Ze Hong (Peter Hong)
2018-01-10  5:30 ` [PATCH V2 1/5] " Ji-Ze Hong (Peter Hong)
2018-01-09 11:32 [V2,5/5] usb: serial: f81534: fix tx error on some baud rate Johan Hovold
2018-01-09 11:32 ` [PATCH V2 5/5] " Johan Hovold
2018-01-09 11:19 [V2,3/5] usb: serial: f81534: add output pin control Johan Hovold
2018-01-09 11:19 ` [PATCH V2 3/5] " Johan Hovold
2018-01-09 11:14 [V2,2/5] usb: serial: f81534: add auto RTS direction support Johan Hovold
2018-01-09 11:14 ` [PATCH V2 2/5] " Johan Hovold
2018-01-09 11:08 [V2,1/5] usb: serial: f81534: add high baud rate support Johan Hovold
2018-01-09 11:08 ` [PATCH V2 1/5] " Johan Hovold
2018-01-04  2:29 [V2,5/5] usb: serial: f81534: fix tx error on some baud rate Ji-Ze Hong (Peter Hong)
2018-01-04  2:29 ` [PATCH V2 5/5] " Ji-Ze Hong (Peter Hong)
2018-01-04  2:29 [V2,4/5] usb: serial: f81534: add H/W disable port support Ji-Ze Hong (Peter Hong)
2018-01-04  2:29 ` [PATCH V2 4/5] " Ji-Ze Hong (Peter Hong)
2018-01-04  2:29 [V2,3/5] usb: serial: f81534: add output pin control Ji-Ze Hong (Peter Hong)
2018-01-04  2:29 ` [PATCH V2 3/5] " Ji-Ze Hong (Peter Hong)
2018-01-04  2:29 [V2,2/5] usb: serial: f81534: add auto RTS direction support Ji-Ze Hong (Peter Hong)
2018-01-04  2:29 ` [PATCH V2 2/5] " Ji-Ze Hong (Peter Hong)
2018-01-04  2:29 [V2,1/5] usb: serial: f81534: add high baud rate support Ji-Ze Hong (Peter Hong)
2018-01-04  2:29 ` [PATCH V2 1/5] " Ji-Ze Hong (Peter Hong)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180109112957.GQ11344@localhost \
    --to=johan@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpeter+linux_kernel@gmail.com \
    --cc=hpeter@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=peter_hong@fintek.com.tw \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.