From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: Marc Zyngier <marc.zyngier-5wv7dgnIgG8@public.gmane.org>
Cc: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Sinan Kaya <okaya-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] iommu/arm-smmu-v3: suppress MSI allocation failure message
Date: Wed, 17 Jan 2018 20:23:01 +0100 [thread overview]
Message-ID: <20180117192301.GV28161@8bytes.org> (raw)
In-Reply-To: <66706458-d971-be9b-4390-80a9be39248c-5wv7dgnIgG8@public.gmane.org>
On Wed, Jan 17, 2018 at 07:08:39PM +0000, Marc Zyngier wrote:
> On 17/01/18 18:54, Robin Murphy wrote:
> Indeed. How about checking dev->msi_domain first, which should tell you
> whether it is even possible to allocate MSIs, and fallback to wired IRQs
> instead. That way, we keep the warning on genuine failures to allocate
> MSIs, and you get to add a nice "Falling back to wired interrupts"
> message when msi_domain is NULL.
>
> Thoughts?
That sounds much better then the proposed patch. I am not really interested
in changing log-levels to make test-tools happy.
Joerg
WARNING: multiple messages have this Message-ID (diff)
From: joro@8bytes.org (Joerg Roedel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] iommu/arm-smmu-v3: suppress MSI allocation failure message
Date: Wed, 17 Jan 2018 20:23:01 +0100 [thread overview]
Message-ID: <20180117192301.GV28161@8bytes.org> (raw)
In-Reply-To: <66706458-d971-be9b-4390-80a9be39248c@arm.com>
On Wed, Jan 17, 2018 at 07:08:39PM +0000, Marc Zyngier wrote:
> On 17/01/18 18:54, Robin Murphy wrote:
> Indeed. How about checking dev->msi_domain first, which should tell you
> whether it is even possible to allocate MSIs, and fallback to wired IRQs
> instead. That way, we keep the warning on genuine failures to allocate
> MSIs, and you get to add a nice "Falling back to wired interrupts"
> message when msi_domain is NULL.
>
> Thoughts?
That sounds much better then the proposed patch. I am not really interested
in changing log-levels to make test-tools happy.
Joerg
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: Robin Murphy <robin.murphy@arm.com>,
Nate Watterson <nwatters@codeaurora.org>,
Will Deacon <will.deacon@arm.com>,
linux-arm-kernel@lists.infradead.org,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
Sinan Kaya <okaya@codeaurora.org>
Subject: Re: [PATCH] iommu/arm-smmu-v3: suppress MSI allocation failure message
Date: Wed, 17 Jan 2018 20:23:01 +0100 [thread overview]
Message-ID: <20180117192301.GV28161@8bytes.org> (raw)
In-Reply-To: <66706458-d971-be9b-4390-80a9be39248c@arm.com>
On Wed, Jan 17, 2018 at 07:08:39PM +0000, Marc Zyngier wrote:
> On 17/01/18 18:54, Robin Murphy wrote:
> Indeed. How about checking dev->msi_domain first, which should tell you
> whether it is even possible to allocate MSIs, and fallback to wired IRQs
> instead. That way, we keep the warning on genuine failures to allocate
> MSIs, and you get to add a nice "Falling back to wired interrupts"
> message when msi_domain is NULL.
>
> Thoughts?
That sounds much better then the proposed patch. I am not really interested
in changing log-levels to make test-tools happy.
Joerg
next prev parent reply other threads:[~2018-01-17 19:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 18:39 [PATCH] iommu/arm-smmu-v3: suppress MSI allocation failure message Nate Watterson
2018-01-17 18:39 ` Nate Watterson
2018-01-17 18:54 ` Robin Murphy
2018-01-17 18:54 ` Robin Murphy
[not found] ` <2f651cfe-e006-cf1d-b624-08e2ba5340fc-5wv7dgnIgG8@public.gmane.org>
2018-01-17 19:08 ` Marc Zyngier
2018-01-17 19:08 ` Marc Zyngier
2018-01-17 19:08 ` Marc Zyngier
[not found] ` <66706458-d971-be9b-4390-80a9be39248c-5wv7dgnIgG8@public.gmane.org>
2018-01-17 19:23 ` Joerg Roedel [this message]
2018-01-17 19:23 ` Joerg Roedel
2018-01-17 19:23 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180117192301.GV28161@8bytes.org \
--to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=marc.zyngier-5wv7dgnIgG8@public.gmane.org \
--cc=okaya-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=will.deacon-5wv7dgnIgG8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.