* [PATCH] iommu/arm-smmu-v3: suppress MSI allocation failure message
@ 2018-01-17 18:39 ` Nate Watterson
0 siblings, 0 replies; 10+ messages in thread
From: Nate Watterson @ 2018-01-17 18:39 UTC (permalink / raw)
To: Will Deacon, Robin Murphy, Joerg Roedel, linux-arm-kernel, iommu,
linux-kernel
Cc: Sinan Kaya, Nate Watterson
From: Sinan Kaya <okaya@codeaurora.org>
Even though QDF2400 supports MSI interrupts with SMMUv3, it is not enabled
in ACPI FW to preserve compatibility with older kernel versions. Code is
emitting warning message during boot.
This is causing some test tools to record a false warning and is causing
support issues.
Better reduce the message level.
Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
Signed-off-by: Nate Watterson <nwatters@codeaurora.org>
---
drivers/iommu/arm-smmu-v3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/arm-smmu-v3.c b/drivers/iommu/arm-smmu-v3.c
index 744592d..2118fda 100644
--- a/drivers/iommu/arm-smmu-v3.c
+++ b/drivers/iommu/arm-smmu-v3.c
@@ -2331,7 +2331,7 @@ static void arm_smmu_setup_msis(struct arm_smmu_device *smmu)
/* Allocate MSIs for evtq, gerror and priq. Ignore cmdq */
ret = platform_msi_domain_alloc_irqs(dev, nvec, arm_smmu_write_msi_msg);
if (ret) {
- dev_warn(dev, "failed to allocate MSIs\n");
+ dev_info(dev, "failed to allocate MSIs\n");
return;
}
--
Qualcomm Datacenter Technologies, Inc. on behalf of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux
Foundation Collaborative Project.
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH] iommu/arm-smmu-v3: suppress MSI allocation failure message
@ 2018-01-17 18:39 ` Nate Watterson
0 siblings, 0 replies; 10+ messages in thread
From: Nate Watterson @ 2018-01-17 18:39 UTC (permalink / raw)
To: linux-arm-kernel
From: Sinan Kaya <okaya@codeaurora.org>
Even though QDF2400 supports MSI interrupts with SMMUv3, it is not enabled
in ACPI FW to preserve compatibility with older kernel versions. Code is
emitting warning message during boot.
This is causing some test tools to record a false warning and is causing
support issues.
Better reduce the message level.
Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
Signed-off-by: Nate Watterson <nwatters@codeaurora.org>
---
drivers/iommu/arm-smmu-v3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/arm-smmu-v3.c b/drivers/iommu/arm-smmu-v3.c
index 744592d..2118fda 100644
--- a/drivers/iommu/arm-smmu-v3.c
+++ b/drivers/iommu/arm-smmu-v3.c
@@ -2331,7 +2331,7 @@ static void arm_smmu_setup_msis(struct arm_smmu_device *smmu)
/* Allocate MSIs for evtq, gerror and priq. Ignore cmdq */
ret = platform_msi_domain_alloc_irqs(dev, nvec, arm_smmu_write_msi_msg);
if (ret) {
- dev_warn(dev, "failed to allocate MSIs\n");
+ dev_info(dev, "failed to allocate MSIs\n");
return;
}
--
Qualcomm Datacenter Technologies, Inc. on behalf of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux
Foundation Collaborative Project.
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH] iommu/arm-smmu-v3: suppress MSI allocation failure message
2018-01-17 18:39 ` Nate Watterson
@ 2018-01-17 18:54 ` Robin Murphy
-1 siblings, 0 replies; 10+ messages in thread
From: Robin Murphy @ 2018-01-17 18:54 UTC (permalink / raw)
To: Nate Watterson, Will Deacon, Joerg Roedel, linux-arm-kernel,
iommu, linux-kernel
Cc: Sinan Kaya, Marc Zyngier
[ +Marc just in case ]
On 17/01/18 18:39, Nate Watterson wrote:
> From: Sinan Kaya <okaya@codeaurora.org>
>
> Even though QDF2400 supports MSI interrupts with SMMUv3, it is not enabled
> in ACPI FW to preserve compatibility with older kernel versions. Code is
> emitting warning message during boot.
>
> This is causing some test tools to record a false warning and is causing
> support issues.
>
> Better reduce the message level.
Ugh, that's unfortunate, since there are also plenty of genuine error
conditions encapsulated in there which we *would* want to report as such
(but still then fall back to wired IRQs if possible). Is the return
value sufficient to differentiate the "there is no MSI parent" and
"there are MSIs but something went wrong" cases, or is it more
complicated than that?
Robin.
> Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
> Signed-off-by: Nate Watterson <nwatters@codeaurora.org>
> ---
> drivers/iommu/arm-smmu-v3.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/arm-smmu-v3.c b/drivers/iommu/arm-smmu-v3.c
> index 744592d..2118fda 100644
> --- a/drivers/iommu/arm-smmu-v3.c
> +++ b/drivers/iommu/arm-smmu-v3.c
> @@ -2331,7 +2331,7 @@ static void arm_smmu_setup_msis(struct arm_smmu_device *smmu)
> /* Allocate MSIs for evtq, gerror and priq. Ignore cmdq */
> ret = platform_msi_domain_alloc_irqs(dev, nvec, arm_smmu_write_msi_msg);
> if (ret) {
> - dev_warn(dev, "failed to allocate MSIs\n");
> + dev_info(dev, "failed to allocate MSIs\n");
> return;
> }
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH] iommu/arm-smmu-v3: suppress MSI allocation failure message
@ 2018-01-17 18:54 ` Robin Murphy
0 siblings, 0 replies; 10+ messages in thread
From: Robin Murphy @ 2018-01-17 18:54 UTC (permalink / raw)
To: linux-arm-kernel
[ +Marc just in case ]
On 17/01/18 18:39, Nate Watterson wrote:
> From: Sinan Kaya <okaya@codeaurora.org>
>
> Even though QDF2400 supports MSI interrupts with SMMUv3, it is not enabled
> in ACPI FW to preserve compatibility with older kernel versions. Code is
> emitting warning message during boot.
>
> This is causing some test tools to record a false warning and is causing
> support issues.
>
> Better reduce the message level.
Ugh, that's unfortunate, since there are also plenty of genuine error
conditions encapsulated in there which we *would* want to report as such
(but still then fall back to wired IRQs if possible). Is the return
value sufficient to differentiate the "there is no MSI parent" and
"there are MSIs but something went wrong" cases, or is it more
complicated than that?
Robin.
> Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
> Signed-off-by: Nate Watterson <nwatters@codeaurora.org>
> ---
> drivers/iommu/arm-smmu-v3.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/arm-smmu-v3.c b/drivers/iommu/arm-smmu-v3.c
> index 744592d..2118fda 100644
> --- a/drivers/iommu/arm-smmu-v3.c
> +++ b/drivers/iommu/arm-smmu-v3.c
> @@ -2331,7 +2331,7 @@ static void arm_smmu_setup_msis(struct arm_smmu_device *smmu)
> /* Allocate MSIs for evtq, gerror and priq. Ignore cmdq */
> ret = platform_msi_domain_alloc_irqs(dev, nvec, arm_smmu_write_msi_msg);
> if (ret) {
> - dev_warn(dev, "failed to allocate MSIs\n");
> + dev_info(dev, "failed to allocate MSIs\n");
> return;
> }
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread[parent not found: <2f651cfe-e006-cf1d-b624-08e2ba5340fc-5wv7dgnIgG8@public.gmane.org>]
* Re: [PATCH] iommu/arm-smmu-v3: suppress MSI allocation failure message
2018-01-17 18:54 ` Robin Murphy
(?)
@ 2018-01-17 19:08 ` Marc Zyngier
-1 siblings, 0 replies; 10+ messages in thread
From: Marc Zyngier @ 2018-01-17 19:08 UTC (permalink / raw)
To: Robin Murphy, Nate Watterson, Will Deacon, Joerg Roedel,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
Cc: Sinan Kaya
On 17/01/18 18:54, Robin Murphy wrote:
> [ +Marc just in case ]
>
> On 17/01/18 18:39, Nate Watterson wrote:
>> From: Sinan Kaya <okaya-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
>>
>> Even though QDF2400 supports MSI interrupts with SMMUv3, it is not enabled
>> in ACPI FW to preserve compatibility with older kernel versions. Code is
>> emitting warning message during boot.
>>
>> This is causing some test tools to record a false warning and is causing
>> support issues.
>>
>> Better reduce the message level.
>
> Ugh, that's unfortunate, since there are also plenty of genuine error
> conditions encapsulated in there which we *would* want to report as such
> (but still then fall back to wired IRQs if possible). Is the return
> value sufficient to differentiate the "there is no MSI parent" and
> "there are MSIs but something went wrong" cases, or is it more
> complicated than that?
Indeed. How about checking dev->msi_domain first, which should tell you
whether it is even possible to allocate MSIs, and fallback to wired IRQs
instead. That way, we keep the warning on genuine failures to allocate
MSIs, and you get to add a nice "Falling back to wired interrupts"
message when msi_domain is NULL.
Thoughts?
M.
>
> Robin.
>
>> Signed-off-by: Sinan Kaya <okaya-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
>> Signed-off-by: Nate Watterson <nwatters-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
>> ---
>> drivers/iommu/arm-smmu-v3.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/iommu/arm-smmu-v3.c b/drivers/iommu/arm-smmu-v3.c
>> index 744592d..2118fda 100644
>> --- a/drivers/iommu/arm-smmu-v3.c
>> +++ b/drivers/iommu/arm-smmu-v3.c
>> @@ -2331,7 +2331,7 @@ static void arm_smmu_setup_msis(struct arm_smmu_device *smmu)
>> /* Allocate MSIs for evtq, gerror and priq. Ignore cmdq */
>> ret = platform_msi_domain_alloc_irqs(dev, nvec, arm_smmu_write_msi_msg);
>> if (ret) {
>> - dev_warn(dev, "failed to allocate MSIs\n");
>> + dev_info(dev, "failed to allocate MSIs\n");
>> return;
>> }
>>
>>
--
Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] iommu/arm-smmu-v3: suppress MSI allocation failure message
@ 2018-01-17 19:08 ` Marc Zyngier
0 siblings, 0 replies; 10+ messages in thread
From: Marc Zyngier @ 2018-01-17 19:08 UTC (permalink / raw)
To: Robin Murphy, Nate Watterson, Will Deacon, Joerg Roedel,
linux-arm-kernel, iommu, linux-kernel
Cc: Sinan Kaya
On 17/01/18 18:54, Robin Murphy wrote:
> [ +Marc just in case ]
>
> On 17/01/18 18:39, Nate Watterson wrote:
>> From: Sinan Kaya <okaya@codeaurora.org>
>>
>> Even though QDF2400 supports MSI interrupts with SMMUv3, it is not enabled
>> in ACPI FW to preserve compatibility with older kernel versions. Code is
>> emitting warning message during boot.
>>
>> This is causing some test tools to record a false warning and is causing
>> support issues.
>>
>> Better reduce the message level.
>
> Ugh, that's unfortunate, since there are also plenty of genuine error
> conditions encapsulated in there which we *would* want to report as such
> (but still then fall back to wired IRQs if possible). Is the return
> value sufficient to differentiate the "there is no MSI parent" and
> "there are MSIs but something went wrong" cases, or is it more
> complicated than that?
Indeed. How about checking dev->msi_domain first, which should tell you
whether it is even possible to allocate MSIs, and fallback to wired IRQs
instead. That way, we keep the warning on genuine failures to allocate
MSIs, and you get to add a nice "Falling back to wired interrupts"
message when msi_domain is NULL.
Thoughts?
M.
>
> Robin.
>
>> Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
>> Signed-off-by: Nate Watterson <nwatters@codeaurora.org>
>> ---
>> drivers/iommu/arm-smmu-v3.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/iommu/arm-smmu-v3.c b/drivers/iommu/arm-smmu-v3.c
>> index 744592d..2118fda 100644
>> --- a/drivers/iommu/arm-smmu-v3.c
>> +++ b/drivers/iommu/arm-smmu-v3.c
>> @@ -2331,7 +2331,7 @@ static void arm_smmu_setup_msis(struct arm_smmu_device *smmu)
>> /* Allocate MSIs for evtq, gerror and priq. Ignore cmdq */
>> ret = platform_msi_domain_alloc_irqs(dev, nvec, arm_smmu_write_msi_msg);
>> if (ret) {
>> - dev_warn(dev, "failed to allocate MSIs\n");
>> + dev_info(dev, "failed to allocate MSIs\n");
>> return;
>> }
>>
>>
--
Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH] iommu/arm-smmu-v3: suppress MSI allocation failure message
@ 2018-01-17 19:08 ` Marc Zyngier
0 siblings, 0 replies; 10+ messages in thread
From: Marc Zyngier @ 2018-01-17 19:08 UTC (permalink / raw)
To: linux-arm-kernel
On 17/01/18 18:54, Robin Murphy wrote:
> [ +Marc just in case ]
>
> On 17/01/18 18:39, Nate Watterson wrote:
>> From: Sinan Kaya <okaya@codeaurora.org>
>>
>> Even though QDF2400 supports MSI interrupts with SMMUv3, it is not enabled
>> in ACPI FW to preserve compatibility with older kernel versions. Code is
>> emitting warning message during boot.
>>
>> This is causing some test tools to record a false warning and is causing
>> support issues.
>>
>> Better reduce the message level.
>
> Ugh, that's unfortunate, since there are also plenty of genuine error
> conditions encapsulated in there which we *would* want to report as such
> (but still then fall back to wired IRQs if possible). Is the return
> value sufficient to differentiate the "there is no MSI parent" and
> "there are MSIs but something went wrong" cases, or is it more
> complicated than that?
Indeed. How about checking dev->msi_domain first, which should tell you
whether it is even possible to allocate MSIs, and fallback to wired IRQs
instead. That way, we keep the warning on genuine failures to allocate
MSIs, and you get to add a nice "Falling back to wired interrupts"
message when msi_domain is NULL.
Thoughts?
M.
>
> Robin.
>
>> Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
>> Signed-off-by: Nate Watterson <nwatters@codeaurora.org>
>> ---
>> drivers/iommu/arm-smmu-v3.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/iommu/arm-smmu-v3.c b/drivers/iommu/arm-smmu-v3.c
>> index 744592d..2118fda 100644
>> --- a/drivers/iommu/arm-smmu-v3.c
>> +++ b/drivers/iommu/arm-smmu-v3.c
>> @@ -2331,7 +2331,7 @@ static void arm_smmu_setup_msis(struct arm_smmu_device *smmu)
>> /* Allocate MSIs for evtq, gerror and priq. Ignore cmdq */
>> ret = platform_msi_domain_alloc_irqs(dev, nvec, arm_smmu_write_msi_msg);
>> if (ret) {
>> - dev_warn(dev, "failed to allocate MSIs\n");
>> + dev_info(dev, "failed to allocate MSIs\n");
>> return;
>> }
>>
>>
--
Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 10+ messages in thread[parent not found: <66706458-d971-be9b-4390-80a9be39248c-5wv7dgnIgG8@public.gmane.org>]
* Re: [PATCH] iommu/arm-smmu-v3: suppress MSI allocation failure message
2018-01-17 19:08 ` Marc Zyngier
(?)
@ 2018-01-17 19:23 ` Joerg Roedel
-1 siblings, 0 replies; 10+ messages in thread
From: Joerg Roedel @ 2018-01-17 19:23 UTC (permalink / raw)
To: Marc Zyngier
Cc: Will Deacon, linux-kernel-u79uwXL29TY76Z2rM5mHXA, Sinan Kaya,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
On Wed, Jan 17, 2018 at 07:08:39PM +0000, Marc Zyngier wrote:
> On 17/01/18 18:54, Robin Murphy wrote:
> Indeed. How about checking dev->msi_domain first, which should tell you
> whether it is even possible to allocate MSIs, and fallback to wired IRQs
> instead. That way, we keep the warning on genuine failures to allocate
> MSIs, and you get to add a nice "Falling back to wired interrupts"
> message when msi_domain is NULL.
>
> Thoughts?
That sounds much better then the proposed patch. I am not really interested
in changing log-levels to make test-tools happy.
Joerg
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] iommu/arm-smmu-v3: suppress MSI allocation failure message
@ 2018-01-17 19:23 ` Joerg Roedel
0 siblings, 0 replies; 10+ messages in thread
From: Joerg Roedel @ 2018-01-17 19:23 UTC (permalink / raw)
To: Marc Zyngier
Cc: Robin Murphy, Nate Watterson, Will Deacon, linux-arm-kernel,
iommu, linux-kernel, Sinan Kaya
On Wed, Jan 17, 2018 at 07:08:39PM +0000, Marc Zyngier wrote:
> On 17/01/18 18:54, Robin Murphy wrote:
> Indeed. How about checking dev->msi_domain first, which should tell you
> whether it is even possible to allocate MSIs, and fallback to wired IRQs
> instead. That way, we keep the warning on genuine failures to allocate
> MSIs, and you get to add a nice "Falling back to wired interrupts"
> message when msi_domain is NULL.
>
> Thoughts?
That sounds much better then the proposed patch. I am not really interested
in changing log-levels to make test-tools happy.
Joerg
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] iommu/arm-smmu-v3: suppress MSI allocation failure message
@ 2018-01-17 19:23 ` Joerg Roedel
0 siblings, 0 replies; 10+ messages in thread
From: Joerg Roedel @ 2018-01-17 19:23 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jan 17, 2018 at 07:08:39PM +0000, Marc Zyngier wrote:
> On 17/01/18 18:54, Robin Murphy wrote:
> Indeed. How about checking dev->msi_domain first, which should tell you
> whether it is even possible to allocate MSIs, and fallback to wired IRQs
> instead. That way, we keep the warning on genuine failures to allocate
> MSIs, and you get to add a nice "Falling back to wired interrupts"
> message when msi_domain is NULL.
>
> Thoughts?
That sounds much better then the proposed patch. I am not really interested
in changing log-levels to make test-tools happy.
Joerg
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2018-01-17 19:23 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-17 18:39 [PATCH] iommu/arm-smmu-v3: suppress MSI allocation failure message Nate Watterson
2018-01-17 18:39 ` Nate Watterson
2018-01-17 18:54 ` Robin Murphy
2018-01-17 18:54 ` Robin Murphy
[not found] ` <2f651cfe-e006-cf1d-b624-08e2ba5340fc-5wv7dgnIgG8@public.gmane.org>
2018-01-17 19:08 ` Marc Zyngier
2018-01-17 19:08 ` Marc Zyngier
2018-01-17 19:08 ` Marc Zyngier
[not found] ` <66706458-d971-be9b-4390-80a9be39248c-5wv7dgnIgG8@public.gmane.org>
2018-01-17 19:23 ` Joerg Roedel
2018-01-17 19:23 ` Joerg Roedel
2018-01-17 19:23 ` Joerg Roedel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.