From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Shuah Khan <shuahkh@osg.samsung.com>
Cc: valentina.manea.m@gmail.com, shuah@kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: [4.9] usbip: fix warning in vhci_hcd_probe/lockdep_init_map
Date: Sun, 21 Jan 2018 17:27:11 +0100 [thread overview]
Message-ID: <20180121162711.GA18144@kroah.com> (raw)
On Wed, Jan 17, 2018 at 03:03:43PM -0700, Shuah Khan wrote:
> commit 918b8ac55b6c809b70aa05c279087109584e393e upstream
>
> vhci_hcd calls sysfs_create_group() with dynamically allocated sysfs
> attributes triggering the lock-class key not persistent warning. Call
> sysfs_attr_init() for dynamically allocated sysfs attributes to fix it.
>
> vhci_hcd vhci_hcd: USB/IP Virtual Host Controller
> vhci_hcd vhci_hcd: new USB bus registered, assigned bus number 2
> BUG: key ffff88006a7e8d18 not in .data!
> ------------[ cut here ]------------
> WARNING: CPU: 0 PID: 1 at kernel/locking/lockdep.c:3131
> lockdep_init_map+0x60c/0x770
> DEBUG_LOCKS_WARN_ON(1)[ 1.567044] Modules linked in:
> CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.9.0-rc7+ #58
> Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011
> ffff88006bce6eb8 ffffffff81f96c8a ffffffff00000a02 1ffff1000d79cd6a
> ffffed000d79cd62 000000046bce6ed8 0000000041b58ab3 ffffffff8598af40
> ffffffff81f969f8 0000000000000000 0000000041b58ab3 0000000000000200
> Call Trace:
> [< inline >] __dump_stack lib/dump_stack.c:15
> [<ffffffff81f96c8a>] dump_stack+0x292/0x398 lib/dump_stack.c:51
> [<ffffffff812b808f>] __warn+0x19f/0x1e0 kernel/panic.c:550
> [<ffffffff812b8195>] warn_slowpath_fmt+0xc5/0x110 kernel/panic.c:565
> [<ffffffff813f3efc>] lockdep_init_map+0x60c/0x770 kernel/locking/lockdep.c:3131
> [<ffffffff819e43d4>] __kernfs_create_file+0x114/0x2a0 fs/kernfs/file.c:954
> [<ffffffff819e68f5>] sysfs_add_file_mode_ns+0x225/0x520 fs/sysfs/file.c:305
> [< inline >] create_files fs/sysfs/group.c:64
> [<ffffffff819e8a89>] internal_create_group+0x239/0x8f0 fs/sysfs/group.c:134
> [<ffffffff819e915f>] sysfs_create_group+0x1f/0x30 fs/sysfs/group.c:156
> [<ffffffff8323de24>] vhci_start+0x5b4/0x7a0 drivers/usb/usbip/vhci_hcd.c:978
> [<ffffffff82c907ca>] usb_add_hcd+0x8da/0x1c60 drivers/usb/core/hcd.c:2867
> [<ffffffff8323bc57>] vhci_hcd_probe+0x97/0x130
> drivers/usb/usbip/vhci_hcd.c:1103
> ---
> ---
> ---[ end trace c33c7b202cf3aac8 ]---
>
> Reported-by: Andrey Konovalov <andreyknvl@google.com>
> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
> ---
>
> Greg,
>
> Please apply this fix to 4.9 stable. I re-discovered the problem
> on 4.9.77-rc1 and re-tested the patch on it.
Now queued up, thanks.
greg k-h
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Shuah Khan <shuahkh@osg.samsung.com>
Cc: valentina.manea.m@gmail.com, shuah@kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH 4.9] usbip: fix warning in vhci_hcd_probe/lockdep_init_map
Date: Sun, 21 Jan 2018 17:27:11 +0100 [thread overview]
Message-ID: <20180121162711.GA18144@kroah.com> (raw)
In-Reply-To: <20180117220343.21725-1-shuahkh@osg.samsung.com>
On Wed, Jan 17, 2018 at 03:03:43PM -0700, Shuah Khan wrote:
> commit 918b8ac55b6c809b70aa05c279087109584e393e upstream
>
> vhci_hcd calls sysfs_create_group() with dynamically allocated sysfs
> attributes triggering the lock-class key not persistent warning. Call
> sysfs_attr_init() for dynamically allocated sysfs attributes to fix it.
>
> vhci_hcd vhci_hcd: USB/IP Virtual Host Controller
> vhci_hcd vhci_hcd: new USB bus registered, assigned bus number 2
> BUG: key ffff88006a7e8d18 not in .data!
> ------------[ cut here ]------------
> WARNING: CPU: 0 PID: 1 at kernel/locking/lockdep.c:3131
> lockdep_init_map+0x60c/0x770
> DEBUG_LOCKS_WARN_ON(1)[ 1.567044] Modules linked in:
> CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.9.0-rc7+ #58
> Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011
> ffff88006bce6eb8 ffffffff81f96c8a ffffffff00000a02 1ffff1000d79cd6a
> ffffed000d79cd62 000000046bce6ed8 0000000041b58ab3 ffffffff8598af40
> ffffffff81f969f8 0000000000000000 0000000041b58ab3 0000000000000200
> Call Trace:
> [< inline >] __dump_stack lib/dump_stack.c:15
> [<ffffffff81f96c8a>] dump_stack+0x292/0x398 lib/dump_stack.c:51
> [<ffffffff812b808f>] __warn+0x19f/0x1e0 kernel/panic.c:550
> [<ffffffff812b8195>] warn_slowpath_fmt+0xc5/0x110 kernel/panic.c:565
> [<ffffffff813f3efc>] lockdep_init_map+0x60c/0x770 kernel/locking/lockdep.c:3131
> [<ffffffff819e43d4>] __kernfs_create_file+0x114/0x2a0 fs/kernfs/file.c:954
> [<ffffffff819e68f5>] sysfs_add_file_mode_ns+0x225/0x520 fs/sysfs/file.c:305
> [< inline >] create_files fs/sysfs/group.c:64
> [<ffffffff819e8a89>] internal_create_group+0x239/0x8f0 fs/sysfs/group.c:134
> [<ffffffff819e915f>] sysfs_create_group+0x1f/0x30 fs/sysfs/group.c:156
> [<ffffffff8323de24>] vhci_start+0x5b4/0x7a0 drivers/usb/usbip/vhci_hcd.c:978
> [<ffffffff82c907ca>] usb_add_hcd+0x8da/0x1c60 drivers/usb/core/hcd.c:2867
> [<ffffffff8323bc57>] vhci_hcd_probe+0x97/0x130
> drivers/usb/usbip/vhci_hcd.c:1103
> ---
> ---
> ---[ end trace c33c7b202cf3aac8 ]---
>
> Reported-by: Andrey Konovalov <andreyknvl@google.com>
> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
> ---
>
> Greg,
>
> Please apply this fix to 4.9 stable. I re-discovered the problem
> on 4.9.77-rc1 and re-tested the patch on it.
Now queued up, thanks.
greg k-h
next reply other threads:[~2018-01-21 16:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-21 16:27 Greg Kroah-Hartman [this message]
2018-01-21 16:27 ` [PATCH 4.9] usbip: fix warning in vhci_hcd_probe/lockdep_init_map Greg KH
-- strict thread matches above, loose matches on Subject: below --
2018-01-17 22:03 [4.9] " Shuah Khan
2018-01-17 22:03 ` [PATCH 4.9] " Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180121162711.GA18144@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=shuahkh@osg.samsung.com \
--cc=stable@vger.kernel.org \
--cc=valentina.manea.m@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.