From: Martin Kaiser <martin@kaiser.cx>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: Matt Mackall <mpm@selenic.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-crypto@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] hwrng: make symbol imx_rngc_pm_ops static
Date: Tue, 23 Jan 2018 09:09:34 +0000 [thread overview]
Message-ID: <20180123090934.GA29930@botnar.kaiser.cx> (raw)
In-Reply-To: <1516673336-170194-1-git-send-email-weiyongjun1@huawei.com>
Thus wrote Wei Yongjun (weiyongjun1@huawei.com):
> Fixes the following sparse warnings:
> drivers/char/hw_random/imx-rngc.c:303:1: warning:
> symbol 'imx_rngc_pm_ops' was not declared. Should it be static?
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/char/hw_random/imx-rngc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/drivers/char/hw_random/imx-rngc.c b/drivers/char/hw_random/imx-rngc.c
> index eca8724..250123b 100644
> --- a/drivers/char/hw_random/imx-rngc.c
> +++ b/drivers/char/hw_random/imx-rngc.c
> @@ -300,7 +300,7 @@ static int __maybe_unused imx_rngc_resume(struct device *dev)
> return 0;
> }
> -SIMPLE_DEV_PM_OPS(imx_rngc_pm_ops, imx_rngc_suspend, imx_rngc_resume);
> +static SIMPLE_DEV_PM_OPS(imx_rngc_pm_ops, imx_rngc_suspend, imx_rngc_resume);
> static const struct of_device_id imx_rngc_dt_ids[] = {
> { .compatible = "fsl,imx25-rngb", .data = NULL, },
You're right. The vast majority of other drivers uses a
static SIMPLE_DEV_PM_OPS(), so should we.
Reviewed-by: Martin Kaiser <martin@kaiser.cx>
WARNING: multiple messages have this Message-ID (diff)
From: Martin Kaiser <martin@kaiser.cx>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: Matt Mackall <mpm@selenic.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-crypto@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] hwrng: make symbol imx_rngc_pm_ops static
Date: Tue, 23 Jan 2018 10:09:34 +0100 [thread overview]
Message-ID: <20180123090934.GA29930@botnar.kaiser.cx> (raw)
In-Reply-To: <1516673336-170194-1-git-send-email-weiyongjun1@huawei.com>
Thus wrote Wei Yongjun (weiyongjun1@huawei.com):
> Fixes the following sparse warnings:
> drivers/char/hw_random/imx-rngc.c:303:1: warning:
> symbol 'imx_rngc_pm_ops' was not declared. Should it be static?
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/char/hw_random/imx-rngc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/drivers/char/hw_random/imx-rngc.c b/drivers/char/hw_random/imx-rngc.c
> index eca8724..250123b 100644
> --- a/drivers/char/hw_random/imx-rngc.c
> +++ b/drivers/char/hw_random/imx-rngc.c
> @@ -300,7 +300,7 @@ static int __maybe_unused imx_rngc_resume(struct device *dev)
> return 0;
> }
> -SIMPLE_DEV_PM_OPS(imx_rngc_pm_ops, imx_rngc_suspend, imx_rngc_resume);
> +static SIMPLE_DEV_PM_OPS(imx_rngc_pm_ops, imx_rngc_suspend, imx_rngc_resume);
> static const struct of_device_id imx_rngc_dt_ids[] = {
> { .compatible = "fsl,imx25-rngb", .data = NULL, },
You're right. The vast majority of other drivers uses a
static SIMPLE_DEV_PM_OPS(), so should we.
Reviewed-by: Martin Kaiser <martin@kaiser.cx>
next prev parent reply other threads:[~2018-01-23 9:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 2:08 [PATCH -next] hwrng: make symbol imx_rngc_pm_ops static Wei Yongjun
2018-01-23 2:08 ` Wei Yongjun
2018-01-23 9:09 ` Martin Kaiser [this message]
2018-01-23 9:09 ` Martin Kaiser
2018-02-15 15:42 ` Herbert Xu
2018-02-15 15:42 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180123090934.GA29930@botnar.kaiser.cx \
--to=martin@kaiser.cx \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.