* [PATCH -next] hwrng: make symbol imx_rngc_pm_ops static
@ 2018-01-23 2:08 ` Wei Yongjun
0 siblings, 0 replies; 6+ messages in thread
From: Wei Yongjun @ 2018-01-23 2:08 UTC (permalink / raw)
To: Matt Mackall, Herbert Xu, Arnd Bergmann, Greg Kroah-Hartman,
Martin Kaiser
Cc: Wei Yongjun, linux-crypto, kernel-janitors
Fixes the following sparse warnings:
drivers/char/hw_random/imx-rngc.c:303:1: warning:
symbol 'imx_rngc_pm_ops' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/char/hw_random/imx-rngc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/hw_random/imx-rngc.c b/drivers/char/hw_random/imx-rngc.c
index eca8724..250123b 100644
--- a/drivers/char/hw_random/imx-rngc.c
+++ b/drivers/char/hw_random/imx-rngc.c
@@ -300,7 +300,7 @@ static int __maybe_unused imx_rngc_resume(struct device *dev)
return 0;
}
-SIMPLE_DEV_PM_OPS(imx_rngc_pm_ops, imx_rngc_suspend, imx_rngc_resume);
+static SIMPLE_DEV_PM_OPS(imx_rngc_pm_ops, imx_rngc_suspend, imx_rngc_resume);
static const struct of_device_id imx_rngc_dt_ids[] = {
{ .compatible = "fsl,imx25-rngb", .data = NULL, },
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH -next] hwrng: make symbol imx_rngc_pm_ops static
@ 2018-01-23 2:08 ` Wei Yongjun
0 siblings, 0 replies; 6+ messages in thread
From: Wei Yongjun @ 2018-01-23 2:08 UTC (permalink / raw)
To: Matt Mackall, Herbert Xu, Arnd Bergmann, Greg Kroah-Hartman,
Martin Kaiser
Cc: Wei Yongjun, linux-crypto, kernel-janitors
Fixes the following sparse warnings:
drivers/char/hw_random/imx-rngc.c:303:1: warning:
symbol 'imx_rngc_pm_ops' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/char/hw_random/imx-rngc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/hw_random/imx-rngc.c b/drivers/char/hw_random/imx-rngc.c
index eca8724..250123b 100644
--- a/drivers/char/hw_random/imx-rngc.c
+++ b/drivers/char/hw_random/imx-rngc.c
@@ -300,7 +300,7 @@ static int __maybe_unused imx_rngc_resume(struct device *dev)
return 0;
}
-SIMPLE_DEV_PM_OPS(imx_rngc_pm_ops, imx_rngc_suspend, imx_rngc_resume);
+static SIMPLE_DEV_PM_OPS(imx_rngc_pm_ops, imx_rngc_suspend, imx_rngc_resume);
static const struct of_device_id imx_rngc_dt_ids[] = {
{ .compatible = "fsl,imx25-rngb", .data = NULL, },
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH -next] hwrng: make symbol imx_rngc_pm_ops static
2018-01-23 2:08 ` Wei Yongjun
@ 2018-01-23 9:09 ` Martin Kaiser
-1 siblings, 0 replies; 6+ messages in thread
From: Martin Kaiser @ 2018-01-23 9:09 UTC (permalink / raw)
To: Wei Yongjun
Cc: Matt Mackall, Herbert Xu, Arnd Bergmann, Greg Kroah-Hartman,
linux-crypto, kernel-janitors
Thus wrote Wei Yongjun (weiyongjun1@huawei.com):
> Fixes the following sparse warnings:
> drivers/char/hw_random/imx-rngc.c:303:1: warning:
> symbol 'imx_rngc_pm_ops' was not declared. Should it be static?
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/char/hw_random/imx-rngc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/drivers/char/hw_random/imx-rngc.c b/drivers/char/hw_random/imx-rngc.c
> index eca8724..250123b 100644
> --- a/drivers/char/hw_random/imx-rngc.c
> +++ b/drivers/char/hw_random/imx-rngc.c
> @@ -300,7 +300,7 @@ static int __maybe_unused imx_rngc_resume(struct device *dev)
> return 0;
> }
> -SIMPLE_DEV_PM_OPS(imx_rngc_pm_ops, imx_rngc_suspend, imx_rngc_resume);
> +static SIMPLE_DEV_PM_OPS(imx_rngc_pm_ops, imx_rngc_suspend, imx_rngc_resume);
> static const struct of_device_id imx_rngc_dt_ids[] = {
> { .compatible = "fsl,imx25-rngb", .data = NULL, },
You're right. The vast majority of other drivers uses a
static SIMPLE_DEV_PM_OPS(), so should we.
Reviewed-by: Martin Kaiser <martin@kaiser.cx>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH -next] hwrng: make symbol imx_rngc_pm_ops static
@ 2018-01-23 9:09 ` Martin Kaiser
0 siblings, 0 replies; 6+ messages in thread
From: Martin Kaiser @ 2018-01-23 9:09 UTC (permalink / raw)
To: Wei Yongjun
Cc: Matt Mackall, Herbert Xu, Arnd Bergmann, Greg Kroah-Hartman,
linux-crypto, kernel-janitors
Thus wrote Wei Yongjun (weiyongjun1@huawei.com):
> Fixes the following sparse warnings:
> drivers/char/hw_random/imx-rngc.c:303:1: warning:
> symbol 'imx_rngc_pm_ops' was not declared. Should it be static?
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/char/hw_random/imx-rngc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/drivers/char/hw_random/imx-rngc.c b/drivers/char/hw_random/imx-rngc.c
> index eca8724..250123b 100644
> --- a/drivers/char/hw_random/imx-rngc.c
> +++ b/drivers/char/hw_random/imx-rngc.c
> @@ -300,7 +300,7 @@ static int __maybe_unused imx_rngc_resume(struct device *dev)
> return 0;
> }
> -SIMPLE_DEV_PM_OPS(imx_rngc_pm_ops, imx_rngc_suspend, imx_rngc_resume);
> +static SIMPLE_DEV_PM_OPS(imx_rngc_pm_ops, imx_rngc_suspend, imx_rngc_resume);
> static const struct of_device_id imx_rngc_dt_ids[] = {
> { .compatible = "fsl,imx25-rngb", .data = NULL, },
You're right. The vast majority of other drivers uses a
static SIMPLE_DEV_PM_OPS(), so should we.
Reviewed-by: Martin Kaiser <martin@kaiser.cx>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] hwrng: make symbol imx_rngc_pm_ops static
2018-01-23 2:08 ` Wei Yongjun
@ 2018-02-15 15:42 ` Herbert Xu
-1 siblings, 0 replies; 6+ messages in thread
From: Herbert Xu @ 2018-02-15 15:42 UTC (permalink / raw)
To: Wei Yongjun
Cc: Matt Mackall, Arnd Bergmann, Greg Kroah-Hartman, Martin Kaiser,
linux-crypto, kernel-janitors
On Tue, Jan 23, 2018 at 02:08:56AM +0000, Wei Yongjun wrote:
> Fixes the following sparse warnings:
>
> drivers/char/hw_random/imx-rngc.c:303:1: warning:
> symbol 'imx_rngc_pm_ops' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-02-15 15:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-23 2:08 [PATCH -next] hwrng: make symbol imx_rngc_pm_ops static Wei Yongjun
2018-01-23 2:08 ` Wei Yongjun
2018-01-23 9:09 ` Martin Kaiser
2018-01-23 9:09 ` Martin Kaiser
2018-02-15 15:42 ` Herbert Xu
2018-02-15 15:42 ` Herbert Xu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.