* [PATCH] drm/edid: use false for boolean value
@ 2018-01-23 16:46 Gustavo A. R. Silva
2018-01-30 9:43 ` Daniel Vetter
0 siblings, 1 reply; 4+ messages in thread
From: Gustavo A. R. Silva @ 2018-01-23 16:46 UTC (permalink / raw)
To: Daniel Vetter, Gustavo Padovan, Sean Paul, David Airlie
Cc: dri-devel, linux-kernel, Gustavo A. R. Silva
Assign true or false to boolean variables instead of an integer value.
This issue was detected with the help of Coccinelle.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/gpu/drm/drm_edid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index ddd5379..45a80d7 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -2767,7 +2767,7 @@ do_detailed_mode(struct detailed_timing *timing, void *c)
drm_mode_probed_add(closure->connector, newmode);
closure->modes++;
- closure->preferred = 0;
+ closure->preferred = false;
}
}
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/edid: use false for boolean value
2018-01-23 16:46 [PATCH] drm/edid: use false for boolean value Gustavo A. R. Silva
@ 2018-01-30 9:43 ` Daniel Vetter
0 siblings, 0 replies; 4+ messages in thread
From: Daniel Vetter @ 2018-01-30 9:43 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: David Airlie, linux-kernel, dri-devel, Gustavo A. R. Silva,
Daniel Vetter
On Tue, Jan 23, 2018 at 10:46:07AM -0600, Gustavo A. R. Silva wrote:
> Assign true or false to boolean variables instead of an integer value.
>
> This issue was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Thanks for your patch.
> ---
> drivers/gpu/drm/drm_edid.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> index ddd5379..45a80d7 100644
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -2767,7 +2767,7 @@ do_detailed_mode(struct detailed_timing *timing, void *c)
>
> drm_mode_probed_add(closure->connector, newmode);
> closure->modes++;
> - closure->preferred = 0;
> + closure->preferred = false;
There's also
.preferred = 1,
in add_detailed_modes. Please fix that one up too for consistency, then
I'll merge your patch.
Cheers, Daniel
> }
> }
>
> --
> 2.7.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/edid: use false for boolean value
@ 2018-01-30 9:43 ` Daniel Vetter
0 siblings, 0 replies; 4+ messages in thread
From: Daniel Vetter @ 2018-01-30 9:43 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Daniel Vetter, Gustavo Padovan, Sean Paul, David Airlie,
Gustavo A. R. Silva, linux-kernel, dri-devel
On Tue, Jan 23, 2018 at 10:46:07AM -0600, Gustavo A. R. Silva wrote:
> Assign true or false to boolean variables instead of an integer value.
>
> This issue was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Thanks for your patch.
> ---
> drivers/gpu/drm/drm_edid.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> index ddd5379..45a80d7 100644
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -2767,7 +2767,7 @@ do_detailed_mode(struct detailed_timing *timing, void *c)
>
> drm_mode_probed_add(closure->connector, newmode);
> closure->modes++;
> - closure->preferred = 0;
> + closure->preferred = false;
There's also
.preferred = 1,
in add_detailed_modes. Please fix that one up too for consistency, then
I'll merge your patch.
Cheers, Daniel
> }
> }
>
> --
> 2.7.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/edid: use false for boolean value
2018-01-30 9:43 ` Daniel Vetter
(?)
@ 2018-01-30 10:02 ` Gustavo A. R. Silva
-1 siblings, 0 replies; 4+ messages in thread
From: Gustavo A. R. Silva @ 2018-01-30 10:02 UTC (permalink / raw)
To: Daniel Vetter
Cc: Gustavo A. R. Silva, Daniel Vetter, Gustavo Padovan, Sean Paul,
David Airlie, linux-kernel, dri-devel
Hi Daniel,
Quoting Daniel Vetter <daniel@ffwll.ch>:
> On Tue, Jan 23, 2018 at 10:46:07AM -0600, Gustavo A. R. Silva wrote:
>> Assign true or false to boolean variables instead of an integer value.
>>
>> This issue was detected with the help of Coccinelle.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>
> Thanks for your patch.
>
>> ---
>> drivers/gpu/drm/drm_edid.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
>> index ddd5379..45a80d7 100644
>> --- a/drivers/gpu/drm/drm_edid.c
>> +++ b/drivers/gpu/drm/drm_edid.c
>> @@ -2767,7 +2767,7 @@ do_detailed_mode(struct detailed_timing
>> *timing, void *c)
>>
>> drm_mode_probed_add(closure->connector, newmode);
>> closure->modes++;
>> - closure->preferred = 0;
>> + closure->preferred = false;
>
> There's also
>
> .preferred = 1,
>
> in add_detailed_modes. Please fix that one up too for consistency, then
> I'll merge your patch.
>
Sure. I'll send a new patch shortly.
I also need to update the Coccinelle script to catch those cases.
Thanks for the feedback.
--
Gustavo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-01-30 10:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-23 16:46 [PATCH] drm/edid: use false for boolean value Gustavo A. R. Silva
2018-01-30 9:43 ` Daniel Vetter
2018-01-30 9:43 ` Daniel Vetter
2018-01-30 10:02 ` Gustavo A. R. Silva
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.