All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bin Liu <b-liu@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Andreas Kemnade <andreas@kemnade.info>,
	gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Discussions about the Letux Kernel <letux-kernel@openphoenux.org>,
	linux-omap@vger.kernel.org
Subject: Re: [PATCH] usb: musb: fix enumeration after resume
Date: Wed, 7 Feb 2018 14:32:20 -0600	[thread overview]
Message-ID: <20180207203220.GB3992@uda0271908> (raw)
In-Reply-To: <20180206184725.GD21573@atomide.com>

On Tue, Feb 06, 2018 at 10:47:25AM -0800, Tony Lindgren wrote:
> * Andreas Kemnade <andreas@kemnade.info> [180127 08:34]:
> > On dm3730 there are enumeration problems after resume.
> > Investigation led to the cause that the MUSB_POWER_SOFTCONN
> > bit is not set. If it was set before suspend (because it
> > was enabled via musb_pullup()), it is set in
> > musb_restore_context() so the pullup is enabled. But then
> > musb_start() is called which overwrites MUSB_POWER and
> > therefore disables MUSB_POWER_SOFTCONN, so no pullup is
> > enabled and the device is not enumerated.
> 
> I just gave this patch a quick try and things seem to behave
> for me from PM point of view:
> 
> Tested-by: Tony Lindgren <tony@atomide.com>

Thanks for testing it.

Regards,
-Bin.

WARNING: multiple messages have this Message-ID (diff)
From: Bin Liu <b-liu@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Andreas Kemnade <andreas@kemnade.info>,
	gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Discussions about the Letux Kernel <letux-kernel@openphoenux.org>,
	linux-omap@vger.kernel.org
Subject: usb: musb: fix enumeration after resume
Date: Wed, 7 Feb 2018 14:32:20 -0600	[thread overview]
Message-ID: <20180207203220.GB3992@uda0271908> (raw)

On Tue, Feb 06, 2018 at 10:47:25AM -0800, Tony Lindgren wrote:
> * Andreas Kemnade <andreas@kemnade.info> [180127 08:34]:
> > On dm3730 there are enumeration problems after resume.
> > Investigation led to the cause that the MUSB_POWER_SOFTCONN
> > bit is not set. If it was set before suspend (because it
> > was enabled via musb_pullup()), it is set in
> > musb_restore_context() so the pullup is enabled. But then
> > musb_start() is called which overwrites MUSB_POWER and
> > therefore disables MUSB_POWER_SOFTCONN, so no pullup is
> > enabled and the device is not enumerated.
> 
> I just gave this patch a quick try and things seem to behave
> for me from PM point of view:
> 
> Tested-by: Tony Lindgren <tony@atomide.com>

Thanks for testing it.

Regards,
-Bin.
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Bin Liu <b-liu@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Andreas Kemnade <andreas@kemnade.info>,
	<gregkh@linuxfoundation.org>, <linux-usb@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	Discussions about the Letux Kernel <letux-kernel@openphoenux.org>,
	<linux-omap@vger.kernel.org>
Subject: Re: [PATCH] usb: musb: fix enumeration after resume
Date: Wed, 7 Feb 2018 14:32:20 -0600	[thread overview]
Message-ID: <20180207203220.GB3992@uda0271908> (raw)
In-Reply-To: <20180206184725.GD21573@atomide.com>

On Tue, Feb 06, 2018 at 10:47:25AM -0800, Tony Lindgren wrote:
> * Andreas Kemnade <andreas@kemnade.info> [180127 08:34]:
> > On dm3730 there are enumeration problems after resume.
> > Investigation led to the cause that the MUSB_POWER_SOFTCONN
> > bit is not set. If it was set before suspend (because it
> > was enabled via musb_pullup()), it is set in
> > musb_restore_context() so the pullup is enabled. But then
> > musb_start() is called which overwrites MUSB_POWER and
> > therefore disables MUSB_POWER_SOFTCONN, so no pullup is
> > enabled and the device is not enumerated.
> 
> I just gave this patch a quick try and things seem to behave
> for me from PM point of view:
> 
> Tested-by: Tony Lindgren <tony@atomide.com>

Thanks for testing it.

Regards,
-Bin.

  parent reply	other threads:[~2018-02-07 20:32 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-27  8:34 usb: musb: fix enumeration after resume Andreas Kemnade
2018-01-27  8:34 ` [PATCH] " Andreas Kemnade
     [not found] ` <20180127083403.928-1-andreas-cLv4Z9ELZ06ZuzBka8ofvg@public.gmane.org>
2018-02-06 18:47   ` Tony Lindgren
2018-02-06 18:47     ` Tony Lindgren
2018-02-06 18:47     ` Tony Lindgren
     [not found]     ` <20180206184725.GD21573-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2018-02-06 19:09       ` [PATCH] " Andreas Kemnade
2018-02-06 19:09         ` Andreas Kemnade
2018-02-06 19:09         ` Andreas Kemnade
2018-02-07 20:32     ` Bin Liu [this message]
2018-02-07 20:32       ` [PATCH] " Bin Liu
2018-02-07 20:32       ` Bin Liu
  -- strict thread matches above, loose matches on Subject: below --
2018-02-06 18:46 Bin Liu
2018-02-06 18:46 ` [PATCH] " Bin Liu
2018-02-06 19:00 Andreas Kemnade
2018-02-06 19:00 ` [PATCH] " Andreas Kemnade
2018-02-07 20:37 Bin Liu
2018-02-07 20:37 ` [PATCH] " Bin Liu
2018-02-16  7:10 Andreas Kemnade
2018-02-16  7:10 ` [PATCH] " Andreas Kemnade

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180207203220.GB3992@uda0271908 \
    --to=b-liu@ti.com \
    --cc=andreas@kemnade.info \
    --cc=gregkh@linuxfoundation.org \
    --cc=letux-kernel@openphoenux.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.