[v4,5/5] dmaengine: mediatek: fix zalloc-simple.cocci warnings

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Vinod Koul <vinod.koul@intel.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: sean.wang@mediatek.com, dan.j.williams@intel.com,
	robh+dt@kernel.org, mark.rutland@arm.com,
	dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Fengguang Wu <fengguang.wu@intel.com>
Subject: [v4,5/5] dmaengine: mediatek: fix zalloc-simple.cocci warnings
Date: Tue, 13 Feb 2018 12:16:59 +0530	[thread overview]
Message-ID: <20180213064659.GD3666@localhost> (raw)

On Fri, Feb 09, 2018 at 03:55:58PM +0100, Julia Lawall wrote:
> 
> > > -	ring->txd = dma_alloc_coherent(hsdma2dev(hsdma),
> > > -				       pc->sz_ring, &ring->tphys,
> > > -				       GFP_ATOMIC | __GFP_ZERO);
> > > +	ring->txd = dma_zalloc_coherent(hsdma2dev(hsdma), pc->sz_ring,
> > > +					&ring->tphys, GFP_ATOMIC);
> > >  	if (!ring->txd)
> > >  		return -ENOMEM;
> > >
> > > -	memset(ring->txd, 0, pc->sz_ring);
> >
> > This should be folded back..
> 
> Sorry, I'm not sure what you mean by "folded back".

Since the original patch is also up for review in this series, it doesn't
help much to add a change and fix on top in a series. The fix should be
folded back into the original commit. IIRC Fengguang's bot also recommends
so..

WARNING: multiple messages have this Message-ID (diff)

From: Vinod Koul <vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Julia Lawall <julia.lawall-L2FTfq7BK8M@public.gmane.org>
Cc: sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
	dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Fengguang Wu
	<fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v4 5/5] dmaengine: mediatek: fix zalloc-simple.cocci warnings
Date: Tue, 13 Feb 2018 12:16:59 +0530	[thread overview]
Message-ID: <20180213064659.GD3666@localhost> (raw)
In-Reply-To: <alpine.DEB.2.20.1802091555290.2944@hadrien>

On Fri, Feb 09, 2018 at 03:55:58PM +0100, Julia Lawall wrote:
> 
> > > -	ring->txd = dma_alloc_coherent(hsdma2dev(hsdma),
> > > -				       pc->sz_ring, &ring->tphys,
> > > -				       GFP_ATOMIC | __GFP_ZERO);
> > > +	ring->txd = dma_zalloc_coherent(hsdma2dev(hsdma), pc->sz_ring,
> > > +					&ring->tphys, GFP_ATOMIC);
> > >  	if (!ring->txd)
> > >  		return -ENOMEM;
> > >
> > > -	memset(ring->txd, 0, pc->sz_ring);
> >
> > This should be folded back..
> 
> Sorry, I'm not sure what you mean by "folded back".

Since the original patch is also up for review in this series, it doesn't
help much to add a change and fix on top in a series. The fix should be
folded back into the original commit. IIRC Fengguang's bot also recommends
so..

-- 
~Vinod
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)

From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 5/5] dmaengine: mediatek: fix zalloc-simple.cocci warnings
Date: Tue, 13 Feb 2018 12:16:59 +0530	[thread overview]
Message-ID: <20180213064659.GD3666@localhost> (raw)
In-Reply-To: <alpine.DEB.2.20.1802091555290.2944@hadrien>

On Fri, Feb 09, 2018 at 03:55:58PM +0100, Julia Lawall wrote:
> 
> > > -	ring->txd = dma_alloc_coherent(hsdma2dev(hsdma),
> > > -				       pc->sz_ring, &ring->tphys,
> > > -				       GFP_ATOMIC | __GFP_ZERO);
> > > +	ring->txd = dma_zalloc_coherent(hsdma2dev(hsdma), pc->sz_ring,
> > > +					&ring->tphys, GFP_ATOMIC);
> > >  	if (!ring->txd)
> > >  		return -ENOMEM;
> > >
> > > -	memset(ring->txd, 0, pc->sz_ring);
> >
> > This should be folded back..
> 
> Sorry, I'm not sure what you mean by "folded back".

Since the original patch is also up for review in this series, it doesn't
help much to add a change and fix on top in a series. The fix should be
folded back into the original commit. IIRC Fengguang's bot also recommends
so..

-- 
~Vinod

WARNING: multiple messages have this Message-ID (diff)

From: Vinod Koul <vinod.koul@intel.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: sean.wang@mediatek.com, dan.j.williams@intel.com,
	robh+dt@kernel.org, mark.rutland@arm.com,
	dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Fengguang Wu <fengguang.wu@intel.com>
Subject: Re: [PATCH v4 5/5] dmaengine: mediatek: fix zalloc-simple.cocci warnings
Date: Tue, 13 Feb 2018 12:16:59 +0530	[thread overview]
Message-ID: <20180213064659.GD3666@localhost> (raw)
In-Reply-To: <alpine.DEB.2.20.1802091555290.2944@hadrien>

On Fri, Feb 09, 2018 at 03:55:58PM +0100, Julia Lawall wrote:
> 
> > > -	ring->txd = dma_alloc_coherent(hsdma2dev(hsdma),
> > > -				       pc->sz_ring, &ring->tphys,
> > > -				       GFP_ATOMIC | __GFP_ZERO);
> > > +	ring->txd = dma_zalloc_coherent(hsdma2dev(hsdma), pc->sz_ring,
> > > +					&ring->tphys, GFP_ATOMIC);
> > >  	if (!ring->txd)
> > >  		return -ENOMEM;
> > >
> > > -	memset(ring->txd, 0, pc->sz_ring);
> >
> > This should be folded back..
> 
> Sorry, I'm not sure what you mean by "folded back".

Since the original patch is also up for review in this series, it doesn't
help much to add a change and fix on top in a series. The fix should be
folded back into the original commit. IIRC Fengguang's bot also recommends
so..

-- 
~Vinod

next             reply	other threads:[~2018-02-13  6:46 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-13  6:46 Vinod Koul [this message]
2018-02-13  6:46 ` [PATCH v4 5/5] dmaengine: mediatek: fix zalloc-simple.cocci warnings Vinod Koul
2018-02-13  6:46 ` Vinod Koul
2018-02-13  6:46 ` Vinod Koul
  -- strict thread matches above, loose matches on Subject: below --
2018-02-13  7:07 [v4,5/5] " Julia Lawall
2018-02-13  7:07 ` [PATCH v4 5/5] " Julia Lawall
2018-02-13  7:07 ` Julia Lawall
2018-02-13  7:07 ` Julia Lawall
2018-02-09 14:55 [v4,5/5] " Julia Lawall
2018-02-09 14:55 ` [PATCH v4 5/5] " Julia Lawall
2018-02-09 14:55 ` Julia Lawall
2018-02-09 12:58 [v4,5/5] " Vinod Koul
2018-02-09 12:58 ` [PATCH v4 5/5] " Vinod Koul
2018-02-09 12:58 ` Vinod Koul
2018-02-09 12:58 ` Vinod Koul
2018-02-08 19:14 [v4,2/5] dmaengine: mediatek: Add MediaTek High-Speed DMA controller for MT7622 and MT7623 SoC Randy Dunlap
2018-02-08 19:14 ` [PATCH v4 2/5] " Randy Dunlap
2018-02-08 19:14 ` Randy Dunlap
2018-02-08 17:58 [v4,5/5] dmaengine: mediatek: fix zalloc-simple.cocci warnings sean.wang
2018-02-08 17:58 ` [PATCH v4 5/5] " sean.wang
2018-02-08 17:58 ` sean.wang at mediatek.com
2018-02-08 17:58 ` sean.wang
2018-02-08 17:58 [v4,4/5] dmaengine: mediatek: mtk_hsdma_find_active_desc() can be static sean.wang
2018-02-08 17:58 ` [PATCH v4 4/5] " sean.wang
2018-02-08 17:58 ` sean.wang at mediatek.com
2018-02-08 17:58 ` sean.wang
2018-02-08 17:58 [v4,3/5] dmaengine: mediatek: update MAINTAINERS entry with MediaTek DMA driver sean.wang
2018-02-08 17:58 ` [PATCH v4 3/5] " sean.wang
2018-02-08 17:58 ` sean.wang at mediatek.com
2018-02-08 17:58 ` sean.wang
2018-02-08 17:58 [v4,2/5] dmaengine: mediatek: Add MediaTek High-Speed DMA controller for MT7622 and MT7623 SoC sean.wang
2018-02-08 17:58 ` [PATCH v4 2/5] " sean.wang
2018-02-08 17:58 ` sean.wang at mediatek.com
2018-02-08 17:58 ` sean.wang
2018-02-08 17:58 [v4,1/5] dt-bindings: dmaengine: Add MediaTek High-Speed DMA controller bindings sean.wang
2018-02-08 17:58 ` [PATCH v4 1/5] " sean.wang
2018-02-08 17:58 ` sean.wang at mediatek.com
2018-02-08 17:58 ` sean.wang
2018-02-08 17:58 [PATCH v4 0/5] add support for Mediatek High-Speed DMA controller on MT7622 and MT7623 SoC sean.wang-NuS5LvNUpcJWk0Htik3J/w
2018-02-08 17:58 ` sean.wang
2018-02-08 17:58 ` sean.wang at mediatek.com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180213064659.GD3666@localhost \
    --to=vinod.koul@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=fengguang.wu@intel.com \
    --cc=julia.lawall@lip6.fr \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=sean.wang@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.