From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: James Hogan <jhogan@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
linux-mips@linux-mips.org, Paul Burton <paul.burton@mips.com>,
Ralf Baechle <ralf@linux-mips.org>,
Corentin Labbe <clabbe.montjoie@gmail.com>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH 1/2] usb: Move USB_UHCI_BIG_ENDIAN_* out of USB_SUPPORT
Date: Thu, 15 Feb 2018 22:41:42 +0100 [thread overview]
Message-ID: <20180215214142.GA31227@kroah.com> (raw)
In-Reply-To: <20180215213847.GK3986@saruman>
On Thu, Feb 15, 2018 at 09:38:48PM +0000, James Hogan wrote:
> On Thu, Feb 15, 2018 at 06:42:03PM +0100, Greg Kroah-Hartman wrote:
> > On Wed, Jan 31, 2018 at 10:24:45PM +0000, James Hogan wrote:
> > > Move the Kconfig symbols USB_UHCI_BIG_ENDIAN_MMIO and
> > > USB_UHCI_BIG_ENDIAN_DESC out of drivers/usb/host/Kconfig, which is
> > > conditional upon USB && USB_SUPPORT, so that it can be freely selected
> > > by platform Kconfig symbols in architecture code.
> > >
> > > For example once the MIPS_GENERIC platform selects are fixed in the
> > > patch "MIPS: Fix typo BIG_ENDIAN to CPU_BIG_ENDIAN", the MIPS
> > > 32r6_defconfig warns like so:
> > >
> > > warning: (MIPS_GENERIC) selects USB_UHCI_BIG_ENDIAN_MMIO which has unmet direct dependencies (USB_SUPPORT && USB)
> > > warning: (MIPS_GENERIC) selects USB_UHCI_BIG_ENDIAN_DESC which has unmet direct dependencies (USB_SUPPORT && USB)
> > >
> > > Signed-off-by: James Hogan <jhogan@kernel.org>
> > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > Cc: Corentin Labbe <clabbe.montjoie@gmail.com>
> > > Cc: linux-usb@vger.kernel.org
> >
> > Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> Thanks, I'll apply this as a MIPS fix for 4.16.
>
> Okay to leave patch 2 for you to deal with Greg since it doesn't really
> directly affect MIPS nor is it important for 4.16?
Just take both of them and be done with it :)
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: James Hogan <jhogan@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
linux-mips@linux-mips.org, Paul Burton <paul.burton@mips.com>,
Ralf Baechle <ralf@linux-mips.org>,
Corentin Labbe <clabbe.montjoie@gmail.com>,
linux-usb@vger.kernel.org
Subject: [1/2] usb: Move USB_UHCI_BIG_ENDIAN_* out of USB_SUPPORT
Date: Thu, 15 Feb 2018 22:41:42 +0100 [thread overview]
Message-ID: <20180215214142.GA31227@kroah.com> (raw)
On Thu, Feb 15, 2018 at 09:38:48PM +0000, James Hogan wrote:
> On Thu, Feb 15, 2018 at 06:42:03PM +0100, Greg Kroah-Hartman wrote:
> > On Wed, Jan 31, 2018 at 10:24:45PM +0000, James Hogan wrote:
> > > Move the Kconfig symbols USB_UHCI_BIG_ENDIAN_MMIO and
> > > USB_UHCI_BIG_ENDIAN_DESC out of drivers/usb/host/Kconfig, which is
> > > conditional upon USB && USB_SUPPORT, so that it can be freely selected
> > > by platform Kconfig symbols in architecture code.
> > >
> > > For example once the MIPS_GENERIC platform selects are fixed in the
> > > patch "MIPS: Fix typo BIG_ENDIAN to CPU_BIG_ENDIAN", the MIPS
> > > 32r6_defconfig warns like so:
> > >
> > > warning: (MIPS_GENERIC) selects USB_UHCI_BIG_ENDIAN_MMIO which has unmet direct dependencies (USB_SUPPORT && USB)
> > > warning: (MIPS_GENERIC) selects USB_UHCI_BIG_ENDIAN_DESC which has unmet direct dependencies (USB_SUPPORT && USB)
> > >
> > > Signed-off-by: James Hogan <jhogan@kernel.org>
> > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > Cc: Corentin Labbe <clabbe.montjoie@gmail.com>
> > > Cc: linux-usb@vger.kernel.org
> >
> > Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> Thanks, I'll apply this as a MIPS fix for 4.16.
>
> Okay to leave patch 2 for you to deal with Greg since it doesn't really
> directly affect MIPS nor is it important for 4.16?
Just take both of them and be done with it :)
thanks,
greg k-h
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-02-15 21:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-31 22:24 [PATCH 0/2] usb: Move USB_UHCI_BIG_ENDIAN_* and select from SPARC_LEON James Hogan
2018-01-31 22:24 ` [PATCH 1/2] usb: Move USB_UHCI_BIG_ENDIAN_* out of USB_SUPPORT James Hogan
2018-01-31 22:24 ` [1/2] " James Hogan
2018-02-15 17:42 ` [PATCH 1/2] " Greg Kroah-Hartman
2018-02-15 17:42 ` [1/2] " Greg Kroah-Hartman
2018-02-15 21:38 ` [PATCH 1/2] " James Hogan
2018-02-15 21:38 ` [1/2] " James Hogan
2018-02-15 21:41 ` Greg Kroah-Hartman [this message]
2018-02-15 21:41 ` Greg Kroah-Hartman
2018-02-15 21:42 ` [PATCH 1/2] " James Hogan
2018-02-15 21:42 ` [1/2] " James Hogan
2018-01-31 22:24 ` [PATCH 2/2] sparc,leon: Select USB_UHCI_BIG_ENDIAN_{MMIO,DESC} James Hogan
2018-01-31 22:24 ` [2/2] " James Hogan
2018-02-01 3:36 ` [PATCH 2/2] " David Miller
2018-02-01 3:36 ` David Miller
2018-02-01 3:36 ` [2/2] " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180215214142.GA31227@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=clabbe.montjoie@gmail.com \
--cc=davem@davemloft.net \
--cc=jhogan@kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-usb@vger.kernel.org \
--cc=paul.burton@mips.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.