* Re: [PATCH] Fix checkpatch issue
2018-02-16 20:41 [PATCH] Fix checkpatch issue Ishita Tripathi
@ 2018-02-16 20:51 ` Greg Kroah-Hartman
2018-02-16 20:54 ` [Outreachy kernel] " Julia Lawall
2018-02-16 21:26 ` Ishita Tripathi
2 siblings, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2018-02-16 20:51 UTC (permalink / raw)
To: Ishita Tripathi; +Cc: Ian Abbott, H Hartley Sweeten, outreachy-kernel
On Fri, Feb 16, 2018 at 12:41:00PM -0800, Ishita Tripathi wrote:
> Deleted line break after dereference operator (->)
Your subject is a bit "odd" :)
Please look at other patches for this directory to see the proper prefix
to use.
>
> Signed-off-by: Ishita Tripathi <sakurakhadag@gmail.com>
>
> ---
> drivers/staging/comedi/drivers/rtd520.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/rtd520.c b/drivers/staging/comedi/drivers/rtd520.c
> index bb400e0..47b7093 100644
> --- a/drivers/staging/comedi/drivers/rtd520.c
> +++ b/drivers/staging/comedi/drivers/rtd520.c
> @@ -815,9 +815,8 @@ static int rtd_ai_cmdtest(struct comedi_device *dev,
>
> if (cmd->scan_begin_src == TRIG_TIMER) {
> arg = cmd->convert_arg * cmd->scan_end_arg;
> - err |= comedi_check_trigger_arg_min(&cmd->
> - scan_begin_arg,
> - arg);
> + err |= comedi_check_trigger_arg_min(&cmd->scan_begin_arg,
> + arg);
No need to move the last line here, right? Please keep it as-is.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Outreachy kernel] [PATCH] Fix checkpatch issue
2018-02-16 20:41 [PATCH] Fix checkpatch issue Ishita Tripathi
2018-02-16 20:51 ` Greg Kroah-Hartman
@ 2018-02-16 20:54 ` Julia Lawall
2018-02-16 21:26 ` Ishita Tripathi
2 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2018-02-16 20:54 UTC (permalink / raw)
To: Ishita Tripathi
Cc: Greg Kroah-Hartman, Ian Abbott, H Hartley Sweeten,
outreachy-kernel
On Fri, 16 Feb 2018, Ishita Tripathi wrote:
> Deleted line break after dereference operator (->)
Thank you for your patch. There are some issues with various parts of it,
however.
First, the "To" list looks strange. There should not be the --to: and the
; after the email of H Hartley Sweeten. Did these come from th
get_maintainers script?
Next, the subject line should give some information about what files are
affected. Run git log --oneline drivers/staging/comedi/drivers/rtd520.c
to see what are the subject lines that others have used on this file.
Next, "Fix checkpatch issue" is not very descriptive. Find something short
that described what you do. You can put that the issue was found using
checkpatch at the end of the commit log message.
Next, the commit log message should be in the imperative, like you are
ordering the patch to do something. So it would be "Delete" rather than
"Deleted". Here you may also want to say why you made the change. I
think the code is more readable without these strange linebreaks.
Finally, it could be better to just put &cmd->scan_begin_arg on the next
line, lined up with arg, rather than going over the 80 character limit.
Please send a v2 patch. There are some hints about doing this in the
tutorial.
julia
>
> Signed-off-by: Ishita Tripathi <sakurakhadag@gmail.com>
>
> ---
> drivers/staging/comedi/drivers/rtd520.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/rtd520.c b/drivers/staging/comedi/drivers/rtd520.c
> index bb400e0..47b7093 100644
> --- a/drivers/staging/comedi/drivers/rtd520.c
> +++ b/drivers/staging/comedi/drivers/rtd520.c
> @@ -815,9 +815,8 @@ static int rtd_ai_cmdtest(struct comedi_device *dev,
>
> if (cmd->scan_begin_src == TRIG_TIMER) {
> arg = cmd->convert_arg * cmd->scan_end_arg;
> - err |= comedi_check_trigger_arg_min(&cmd->
> - scan_begin_arg,
> - arg);
> + err |= comedi_check_trigger_arg_min(&cmd->scan_begin_arg,
> + arg);
> }
> }
>
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20180216204100.GA76452%40ubuntu.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Fix checkpatch issue
2018-02-16 20:41 [PATCH] Fix checkpatch issue Ishita Tripathi
2018-02-16 20:51 ` Greg Kroah-Hartman
2018-02-16 20:54 ` [Outreachy kernel] " Julia Lawall
@ 2018-02-16 21:26 ` Ishita Tripathi
2 siblings, 0 replies; 4+ messages in thread
From: Ishita Tripathi @ 2018-02-16 21:26 UTC (permalink / raw)
To: outreachy-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1292 bytes --]
Hi!
I'm very sorry about the horrible quality. I'll try better with v2.
Thank you very much for the replies.
Ishita
On Saturday, 17 February 2018 02:11:07 UTC+5:30, Ishita Tripathi wrote:
>
> Deleted line break after dereference operator (->)
>
> Signed-off-by: Ishita Tripathi <sakurakhadag@gmail.com>
>
> ---
> drivers/staging/comedi/drivers/rtd520.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/rtd520.c
> b/drivers/staging/comedi/drivers/rtd520.c
> index bb400e0..47b7093 100644
> --- a/drivers/staging/comedi/drivers/rtd520.c
> +++ b/drivers/staging/comedi/drivers/rtd520.c
> @@ -815,9 +815,8 @@ static int rtd_ai_cmdtest(struct comedi_device *dev,
>
> if (cmd->scan_begin_src == TRIG_TIMER) {
> arg = cmd->convert_arg * cmd->scan_end_arg;
> - err |= comedi_check_trigger_arg_min(&cmd->
> -
> scan_begin_arg,
> - arg);
> + err |=
> comedi_check_trigger_arg_min(&cmd->scan_begin_arg,
> + arg);
> }
> }
>
> --
> 2.7.4
>
>
[-- Attachment #1.2: Type: text/html, Size: 2099 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread