* [U-Boot] [PATCH] config_whitelist: remove false-positive CONFIG options
@ 2018-01-05 18:17 Masahiro Yamada
2018-01-08 4:52 ` Simon Glass
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Masahiro Yamada @ 2018-01-05 18:17 UTC (permalink / raw)
To: u-boot
U-Boot pulled in several core makefiles from Linux. The following
are not used in U-Boot:
- CONFIG_DEBUG_SECTION_MISMATCH
- CONFIG_FTRACE_MCOUNT_RECORD
- CONFIG_GCOV_KERNEL
- CONFIG_GCOV_PROFILE_ALL
- CONFIG_KASAN
- CONFIG_MODVERSIONS
We can remove the unused code if we like. (although it will get the
scripts out of sync)
CONFIG_BOOM and CONFIG_HIS_DRIVER are just mentioned in the comment
block of scripts/basic/fixdep.c
CONFIG_SHELL is not configuration, but a variable for internal-use.
It is just a historical misnomer in Kbuild.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
scripts/config_whitelist.txt | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/scripts/config_whitelist.txt b/scripts/config_whitelist.txt
index 43a4ff0..2b07dee 100644
--- a/scripts/config_whitelist.txt
+++ b/scripts/config_whitelist.txt
@@ -154,7 +154,6 @@ CONFIG_BOARD_SIZE_LIMIT
CONFIG_BOARD_TAURUS
CONFIG_BOARD_TYPES
CONFIG_BOOGER
-CONFIG_BOOM
CONFIG_BOOTBLOCK
CONFIG_BOOTCOUNT_ALEN
CONFIG_BOOTCOUNT_AM33XX
@@ -387,7 +386,6 @@ CONFIG_DEBUG
CONFIG_DEBUG_FS
CONFIG_DEBUG_LED
CONFIG_DEBUG_LOCK_ALLOC
-CONFIG_DEBUG_SECTION_MISMATCH
CONFIG_DEBUG_SEMIHOSTING
CONFIG_DEBUG_UART_LINFLEXUART
CONFIG_DEBUG_WRITECOUNT
@@ -784,7 +782,6 @@ CONFIG_FTPMU010
CONFIG_FTPMU010_BASE
CONFIG_FTPMU010_POWER
CONFIG_FTPWM010_BASE
-CONFIG_FTRACE_MCOUNT_RECORD
CONFIG_FTRTC010_BASE
CONFIG_FTRTC010_EXTCLK
CONFIG_FTRTC010_PCLK
@@ -807,8 +804,6 @@ CONFIG_FTWDT010_BASE
CONFIG_FTWDT010_WATCHDOG
CONFIG_FZOTG266HD0A_BASE
CONFIG_GATEWAYIP
-CONFIG_GCOV_KERNEL
-CONFIG_GCOV_PROFILE_ALL
CONFIG_GICV2
CONFIG_GICV3
CONFIG_GLOBAL_DATA_NOT_REG10
@@ -851,7 +846,6 @@ CONFIG_HETROGENOUS_CLUSTERS
CONFIG_HIDE_LOGO_VERSION
CONFIG_HIGH_BATS
CONFIG_HIKEY_GPIO
-CONFIG_HIS_DRIVER
CONFIG_HITACHI_SX14
CONFIG_HOSTNAME
CONFIG_HOST_MAX_DEVICES
@@ -1091,7 +1085,6 @@ CONFIG_JFFS2_PART_SIZE
CONFIG_JFFS2_SUMMARY
CONFIG_JRSTARTR_JR0
CONFIG_JTAG_CONSOLE
-CONFIG_KASAN
CONFIG_KCLK_DIS
CONFIG_KEEP_SERVERADDR
CONFIG_KERNEL_OFFSET
@@ -1373,7 +1366,6 @@ CONFIG_MMC_SPI_SPEED
CONFIG_MMC_SUNXI_SLOT
CONFIG_MMC_TRACE
CONFIG_MMU
-CONFIG_MODVERSIONS
CONFIG_MONITOR_IS_IN_RAM
CONFIG_MP
CONFIG_MPC8308
@@ -1947,7 +1939,6 @@ CONFIG_SHARP_LM8V31
CONFIG_SHARP_LQ035Q7DH06
CONFIG_SHEEVA_88SV131
CONFIG_SHEEVA_88SV331xV5
-CONFIG_SHELL
CONFIG_SHMIN
CONFIG_SHOW_ACTIVITY
CONFIG_SHOW_BOOT_PROGRESS
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] config_whitelist: remove false-positive CONFIG options
2018-01-05 18:17 [U-Boot] [PATCH] config_whitelist: remove false-positive CONFIG options Masahiro Yamada
@ 2018-01-08 4:52 ` Simon Glass
2018-02-21 7:07 ` Masahiro Yamada
2018-02-23 18:03 ` [U-Boot] " Tom Rini
2 siblings, 0 replies; 7+ messages in thread
From: Simon Glass @ 2018-01-08 4:52 UTC (permalink / raw)
To: u-boot
On 5 January 2018 at 11:17, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> U-Boot pulled in several core makefiles from Linux. The following
> are not used in U-Boot:
>
> - CONFIG_DEBUG_SECTION_MISMATCH
> - CONFIG_FTRACE_MCOUNT_RECORD
> - CONFIG_GCOV_KERNEL
> - CONFIG_GCOV_PROFILE_ALL
> - CONFIG_KASAN
> - CONFIG_MODVERSIONS
>
> We can remove the unused code if we like. (although it will get the
> scripts out of sync)
>
> CONFIG_BOOM and CONFIG_HIS_DRIVER are just mentioned in the comment
> block of scripts/basic/fixdep.c
>
> CONFIG_SHELL is not configuration, but a variable for internal-use.
> It is just a historical misnomer in Kbuild.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> scripts/config_whitelist.txt | 9 ---------
> 1 file changed, 9 deletions(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] config_whitelist: remove false-positive CONFIG options
2018-01-05 18:17 [U-Boot] [PATCH] config_whitelist: remove false-positive CONFIG options Masahiro Yamada
2018-01-08 4:52 ` Simon Glass
@ 2018-02-21 7:07 ` Masahiro Yamada
2018-02-21 12:19 ` Tom Rini
2018-02-23 18:03 ` [U-Boot] " Tom Rini
2 siblings, 1 reply; 7+ messages in thread
From: Masahiro Yamada @ 2018-02-21 7:07 UTC (permalink / raw)
To: u-boot
2018-01-06 3:17 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> U-Boot pulled in several core makefiles from Linux. The following
> are not used in U-Boot:
>
> - CONFIG_DEBUG_SECTION_MISMATCH
> - CONFIG_FTRACE_MCOUNT_RECORD
> - CONFIG_GCOV_KERNEL
> - CONFIG_GCOV_PROFILE_ALL
> - CONFIG_KASAN
> - CONFIG_MODVERSIONS
>
> We can remove the unused code if we like. (although it will get the
> scripts out of sync)
>
> CONFIG_BOOM and CONFIG_HIS_DRIVER are just mentioned in the comment
> block of scripts/basic/fixdep.c
>
> CONFIG_SHELL is not configuration, but a variable for internal-use.
> It is just a historical misnomer in Kbuild.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Tom,
Can you check this please?
> ---
>
> scripts/config_whitelist.txt | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/scripts/config_whitelist.txt b/scripts/config_whitelist.txt
> index 43a4ff0..2b07dee 100644
> --- a/scripts/config_whitelist.txt
> +++ b/scripts/config_whitelist.txt
> @@ -154,7 +154,6 @@ CONFIG_BOARD_SIZE_LIMIT
> CONFIG_BOARD_TAURUS
> CONFIG_BOARD_TYPES
> CONFIG_BOOGER
> -CONFIG_BOOM
> CONFIG_BOOTBLOCK
> CONFIG_BOOTCOUNT_ALEN
> CONFIG_BOOTCOUNT_AM33XX
> @@ -387,7 +386,6 @@ CONFIG_DEBUG
> CONFIG_DEBUG_FS
> CONFIG_DEBUG_LED
> CONFIG_DEBUG_LOCK_ALLOC
> -CONFIG_DEBUG_SECTION_MISMATCH
> CONFIG_DEBUG_SEMIHOSTING
> CONFIG_DEBUG_UART_LINFLEXUART
> CONFIG_DEBUG_WRITECOUNT
> @@ -784,7 +782,6 @@ CONFIG_FTPMU010
> CONFIG_FTPMU010_BASE
> CONFIG_FTPMU010_POWER
> CONFIG_FTPWM010_BASE
> -CONFIG_FTRACE_MCOUNT_RECORD
> CONFIG_FTRTC010_BASE
> CONFIG_FTRTC010_EXTCLK
> CONFIG_FTRTC010_PCLK
> @@ -807,8 +804,6 @@ CONFIG_FTWDT010_BASE
> CONFIG_FTWDT010_WATCHDOG
> CONFIG_FZOTG266HD0A_BASE
> CONFIG_GATEWAYIP
> -CONFIG_GCOV_KERNEL
> -CONFIG_GCOV_PROFILE_ALL
> CONFIG_GICV2
> CONFIG_GICV3
> CONFIG_GLOBAL_DATA_NOT_REG10
> @@ -851,7 +846,6 @@ CONFIG_HETROGENOUS_CLUSTERS
> CONFIG_HIDE_LOGO_VERSION
> CONFIG_HIGH_BATS
> CONFIG_HIKEY_GPIO
> -CONFIG_HIS_DRIVER
> CONFIG_HITACHI_SX14
> CONFIG_HOSTNAME
> CONFIG_HOST_MAX_DEVICES
> @@ -1091,7 +1085,6 @@ CONFIG_JFFS2_PART_SIZE
> CONFIG_JFFS2_SUMMARY
> CONFIG_JRSTARTR_JR0
> CONFIG_JTAG_CONSOLE
> -CONFIG_KASAN
> CONFIG_KCLK_DIS
> CONFIG_KEEP_SERVERADDR
> CONFIG_KERNEL_OFFSET
> @@ -1373,7 +1366,6 @@ CONFIG_MMC_SPI_SPEED
> CONFIG_MMC_SUNXI_SLOT
> CONFIG_MMC_TRACE
> CONFIG_MMU
> -CONFIG_MODVERSIONS
> CONFIG_MONITOR_IS_IN_RAM
> CONFIG_MP
> CONFIG_MPC8308
> @@ -1947,7 +1939,6 @@ CONFIG_SHARP_LM8V31
> CONFIG_SHARP_LQ035Q7DH06
> CONFIG_SHEEVA_88SV131
> CONFIG_SHEEVA_88SV331xV5
> -CONFIG_SHELL
> CONFIG_SHMIN
> CONFIG_SHOW_ACTIVITY
> CONFIG_SHOW_BOOT_PROGRESS
> --
> 2.7.4
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] config_whitelist: remove false-positive CONFIG options
2018-02-21 7:07 ` Masahiro Yamada
@ 2018-02-21 12:19 ` Tom Rini
2018-02-21 12:41 ` Masahiro Yamada
0 siblings, 1 reply; 7+ messages in thread
From: Tom Rini @ 2018-02-21 12:19 UTC (permalink / raw)
To: u-boot
On Wed, Feb 21, 2018 at 04:07:10PM +0900, Masahiro Yamada wrote:
> 2018-01-06 3:17 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> > U-Boot pulled in several core makefiles from Linux. The following
> > are not used in U-Boot:
> >
> > - CONFIG_DEBUG_SECTION_MISMATCH
> > - CONFIG_FTRACE_MCOUNT_RECORD
> > - CONFIG_GCOV_KERNEL
> > - CONFIG_GCOV_PROFILE_ALL
> > - CONFIG_KASAN
> > - CONFIG_MODVERSIONS
> >
> > We can remove the unused code if we like. (although it will get the
> > scripts out of sync)
> >
> > CONFIG_BOOM and CONFIG_HIS_DRIVER are just mentioned in the comment
> > block of scripts/basic/fixdep.c
> >
> > CONFIG_SHELL is not configuration, but a variable for internal-use.
> > It is just a historical misnomer in Kbuild.
> >
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>
>
> Tom,
>
> Can you check this please?
The problem is that it will get put back in by
./scripts/build-whitelist.sh yes? I try and run that at least every
tag. Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180221/4ad201ce/attachment.sig>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] config_whitelist: remove false-positive CONFIG options
2018-02-21 12:19 ` Tom Rini
@ 2018-02-21 12:41 ` Masahiro Yamada
2018-02-21 12:46 ` Tom Rini
0 siblings, 1 reply; 7+ messages in thread
From: Masahiro Yamada @ 2018-02-21 12:41 UTC (permalink / raw)
To: u-boot
2018-02-21 21:19 GMT+09:00 Tom Rini <trini@konsulko.com>:
> On Wed, Feb 21, 2018 at 04:07:10PM +0900, Masahiro Yamada wrote:
>> 2018-01-06 3:17 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
>> > U-Boot pulled in several core makefiles from Linux. The following
>> > are not used in U-Boot:
>> >
>> > - CONFIG_DEBUG_SECTION_MISMATCH
>> > - CONFIG_FTRACE_MCOUNT_RECORD
>> > - CONFIG_GCOV_KERNEL
>> > - CONFIG_GCOV_PROFILE_ALL
>> > - CONFIG_KASAN
>> > - CONFIG_MODVERSIONS
>> >
>> > We can remove the unused code if we like. (although it will get the
>> > scripts out of sync)
>> >
>> > CONFIG_BOOM and CONFIG_HIS_DRIVER are just mentioned in the comment
>> > block of scripts/basic/fixdep.c
>> >
>> > CONFIG_SHELL is not configuration, but a variable for internal-use.
>> > It is just a historical misnomer in Kbuild.
>> >
>> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>>
>>
>> Tom,
>>
>> Can you check this please?
>
> The problem is that it will get put back in by
> ./scripts/build-whitelist.sh yes?
No.
If you incrementally run build-whitelist.sh,
they will not get back.
If you delete config_whitelist.txt and
build it from scratch, yes, they will get back
with other options we had already deleted.
For example, commit 8bb0f7c0c59e8c5b6f7a6869b802f593739c7ece
But we do not want to do this.
For detailed implementation, see below.
https://github.com/u-boot/u-boot/blob/v2018.03-rc3/scripts/build-whitelist.sh#L50
> I try and run that at least every
> tag. Thanks!
>
> --
> Tom
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] config_whitelist: remove false-positive CONFIG options
2018-02-21 12:41 ` Masahiro Yamada
@ 2018-02-21 12:46 ` Tom Rini
0 siblings, 0 replies; 7+ messages in thread
From: Tom Rini @ 2018-02-21 12:46 UTC (permalink / raw)
To: u-boot
On Wed, Feb 21, 2018 at 09:41:10PM +0900, Masahiro Yamada wrote:
> 2018-02-21 21:19 GMT+09:00 Tom Rini <trini@konsulko.com>:
> > On Wed, Feb 21, 2018 at 04:07:10PM +0900, Masahiro Yamada wrote:
> >> 2018-01-06 3:17 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> >> > U-Boot pulled in several core makefiles from Linux. The following
> >> > are not used in U-Boot:
> >> >
> >> > - CONFIG_DEBUG_SECTION_MISMATCH
> >> > - CONFIG_FTRACE_MCOUNT_RECORD
> >> > - CONFIG_GCOV_KERNEL
> >> > - CONFIG_GCOV_PROFILE_ALL
> >> > - CONFIG_KASAN
> >> > - CONFIG_MODVERSIONS
> >> >
> >> > We can remove the unused code if we like. (although it will get the
> >> > scripts out of sync)
> >> >
> >> > CONFIG_BOOM and CONFIG_HIS_DRIVER are just mentioned in the comment
> >> > block of scripts/basic/fixdep.c
> >> >
> >> > CONFIG_SHELL is not configuration, but a variable for internal-use.
> >> > It is just a historical misnomer in Kbuild.
> >> >
> >> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> >>
> >>
> >> Tom,
> >>
> >> Can you check this please?
> >
> > The problem is that it will get put back in by
> > ./scripts/build-whitelist.sh yes?
>
> No.
>
> If you incrementally run build-whitelist.sh,
> they will not get back.
>
>
> If you delete config_whitelist.txt and
> build it from scratch, yes, they will get back
> with other options we had already deleted.
>
> For example, commit 8bb0f7c0c59e8c5b6f7a6869b802f593739c7ece
>
> But we do not want to do this.
>
>
>
> For detailed implementation, see below.
>
> https://github.com/u-boot/u-boot/blob/v2018.03-rc3/scripts/build-whitelist.sh#L50
Ah, ok, thanks. Yes, I'll grab this soon.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180221/9d5ca6fd/attachment.sig>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] config_whitelist: remove false-positive CONFIG options
2018-01-05 18:17 [U-Boot] [PATCH] config_whitelist: remove false-positive CONFIG options Masahiro Yamada
2018-01-08 4:52 ` Simon Glass
2018-02-21 7:07 ` Masahiro Yamada
@ 2018-02-23 18:03 ` Tom Rini
2 siblings, 0 replies; 7+ messages in thread
From: Tom Rini @ 2018-02-23 18:03 UTC (permalink / raw)
To: u-boot
On Sat, Jan 06, 2018 at 03:17:06AM +0900, Masahiro Yamada wrote:
> U-Boot pulled in several core makefiles from Linux. The following
> are not used in U-Boot:
>
> - CONFIG_DEBUG_SECTION_MISMATCH
> - CONFIG_FTRACE_MCOUNT_RECORD
> - CONFIG_GCOV_KERNEL
> - CONFIG_GCOV_PROFILE_ALL
> - CONFIG_KASAN
> - CONFIG_MODVERSIONS
>
> We can remove the unused code if we like. (although it will get the
> scripts out of sync)
>
> CONFIG_BOOM and CONFIG_HIS_DRIVER are just mentioned in the comment
> block of scripts/basic/fixdep.c
>
> CONFIG_SHELL is not configuration, but a variable for internal-use.
> It is just a historical misnomer in Kbuild.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180223/d06fb9b7/attachment.sig>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-02-23 18:03 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-05 18:17 [U-Boot] [PATCH] config_whitelist: remove false-positive CONFIG options Masahiro Yamada
2018-01-08 4:52 ` Simon Glass
2018-02-21 7:07 ` Masahiro Yamada
2018-02-21 12:19 ` Tom Rini
2018-02-21 12:41 ` Masahiro Yamada
2018-02-21 12:46 ` Tom Rini
2018-02-23 18:03 ` [U-Boot] " Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.