From: idosch at idosch.org (Ido Schimmel)
Subject: [PATCH net-next 02/14] selftests: forwarding: Add a test for FDB learning
Date: Mon, 26 Feb 2018 22:02:17 +0200 [thread overview]
Message-ID: <20180226200217.GB4195@splinter> (raw)
In-Reply-To: <wih4lm3pv9m.fsf@dev-r-vrt-156.mtr.labs.mlnx>
On Mon, Feb 26, 2018 at 06:31:49PM +0200, Petr Machata wrote:
> Ido Schimmel <idosch at mellanox.com> writes:
>
> > +learning_test()
> > +{
> > + local mac=de:ad:be:ef:13:37
> > + local ageing_time
> > + local br_port1=$2 # Connected to `host1_if`.
> > + local host1_if=$3
> > + local host2_if=$4
> > + local bridge=$1
>
> I don't think applying RXT in Bash is appropriate. The ordering of the
> local variables should instead follow the order of function arguments,
> because that information isn't communicated by the function prototype
> itself, unlike C.
Makes sense. Will fix. Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: idosch@idosch.org (Ido Schimmel)
Subject: [PATCH net-next 02/14] selftests: forwarding: Add a test for FDB learning
Date: Mon, 26 Feb 2018 22:02:17 +0200 [thread overview]
Message-ID: <20180226200217.GB4195@splinter> (raw)
Message-ID: <20180226200217.FgPZs8UV1VpEj8-kgga9zd2w3ow14gjZT-TRpg9rqxQ@z> (raw)
In-Reply-To: <wih4lm3pv9m.fsf@dev-r-vrt-156.mtr.labs.mlnx>
On Mon, Feb 26, 2018@06:31:49PM +0200, Petr Machata wrote:
> Ido Schimmel <idosch at mellanox.com> writes:
>
> > +learning_test()
> > +{
> > + local mac=de:ad:be:ef:13:37
> > + local ageing_time
> > + local br_port1=$2 # Connected to `host1_if`.
> > + local host1_if=$3
> > + local host2_if=$4
> > + local bridge=$1
>
> I don't think applying RXT in Bash is appropriate. The ordering of the
> local variables should instead follow the order of function arguments,
> because that information isn't communicated by the function prototype
> itself, unlike C.
Makes sense. Will fix. Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Ido Schimmel <idosch@idosch.org>
To: Petr Machata <petrm@mellanox.com>
Cc: Ido Schimmel <idosch@mellanox.com>,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
davem@davemloft.net, shuah@kernel.org, jiri@mellanox.com,
dsahern@gmail.com, roopa@cumulusnetworks.com,
nikolay@cumulusnetworks.com, f.fainelli@gmail.com,
andrew@lunn.ch, vivien.didelot@savoirfairelinux.com,
mlxsw@mellanox.com
Subject: Re: [PATCH net-next 02/14] selftests: forwarding: Add a test for FDB learning
Date: Mon, 26 Feb 2018 22:02:17 +0200 [thread overview]
Message-ID: <20180226200217.GB4195@splinter> (raw)
In-Reply-To: <wih4lm3pv9m.fsf@dev-r-vrt-156.mtr.labs.mlnx>
On Mon, Feb 26, 2018 at 06:31:49PM +0200, Petr Machata wrote:
> Ido Schimmel <idosch@mellanox.com> writes:
>
> > +learning_test()
> > +{
> > + local mac=de:ad:be:ef:13:37
> > + local ageing_time
> > + local br_port1=$2 # Connected to `host1_if`.
> > + local host1_if=$3
> > + local host2_if=$4
> > + local bridge=$1
>
> I don't think applying RXT in Bash is appropriate. The ordering of the
> local variables should instead follow the order of function arguments,
> because that information isn't communicated by the function prototype
> itself, unlike C.
Makes sense. Will fix. Thanks!
next prev parent reply other threads:[~2018-02-26 20:02 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-26 8:59 [PATCH net-next 00/14] selftests: forwarding: Add VRF-based tests idosch
2018-02-26 8:59 ` Ido Schimmel
2018-02-26 8:59 ` Ido Schimmel
2018-02-26 8:59 ` [PATCH net-next 01/14] selftests: forwarding: Add initial testing framework idosch
2018-02-26 8:59 ` Ido Schimmel
2018-02-26 8:59 ` Ido Schimmel
2018-02-26 13:48 ` andrew
2018-02-26 13:48 ` Andrew Lunn
2018-02-26 13:48 ` Andrew Lunn
2018-02-26 8:59 ` [PATCH net-next 02/14] selftests: forwarding: Add a test for FDB learning idosch
2018-02-26 8:59 ` Ido Schimmel
2018-02-26 8:59 ` Ido Schimmel
2018-02-26 16:31 ` petrm
2018-02-26 16:31 ` Petr Machata
2018-02-26 16:31 ` Petr Machata
2018-02-26 20:02 ` idosch [this message]
2018-02-26 20:02 ` Ido Schimmel
2018-02-26 20:02 ` Ido Schimmel
2018-02-26 8:59 ` [PATCH net-next 03/14] selftests: forwarding: Add a test for flooded traffic idosch
2018-02-26 8:59 ` Ido Schimmel
2018-02-26 8:59 ` Ido Schimmel
2018-02-26 8:59 ` [PATCH net-next 04/14] selftests: forwarding: Add a test for basic IPv4 and IPv6 routing idosch
2018-02-26 8:59 ` Ido Schimmel
2018-02-26 8:59 ` Ido Schimmel
2018-02-26 8:59 ` [PATCH net-next 05/14] selftests: forwarding: Create test topology for multipath routing idosch
2018-02-26 8:59 ` Ido Schimmel
2018-02-26 8:59 ` Ido Schimmel
2018-02-26 8:59 ` [PATCH net-next 06/14] selftests: forwarding: Test IPv4 weighted nexthops idosch
2018-02-26 8:59 ` Ido Schimmel
2018-02-26 8:59 ` Ido Schimmel
2018-02-26 8:59 ` [PATCH net-next 07/14] selftests: forwarding: Test IPv6 " idosch
2018-02-26 8:59 ` Ido Schimmel
2018-02-26 8:59 ` Ido Schimmel
2018-02-26 8:59 ` [PATCH net-next 08/14] selftests: forwarding: Add tc offload check helper idosch
2018-02-26 8:59 ` Ido Schimmel
2018-02-26 8:59 ` Ido Schimmel
2018-02-26 8:59 ` [PATCH net-next 09/14] selftests: forwarding: Add MAC get helper idosch
2018-02-26 8:59 ` Ido Schimmel
2018-02-26 8:59 ` Ido Schimmel
2018-02-26 8:59 ` [PATCH net-next 10/14] selftests: forwarding: Allow to get netdev interfaces names from commandline idosch
2018-02-26 8:59 ` Ido Schimmel
2018-02-26 8:59 ` Ido Schimmel
2018-02-26 8:59 ` [PATCH net-next 11/14] selftests: forwarding: Introduce tc flower matching tests idosch
2018-02-26 8:59 ` Ido Schimmel
2018-02-26 8:59 ` Ido Schimmel
2018-02-26 8:59 ` [PATCH net-next 12/14] selftests: forwarding: Introduce tc actions tests idosch
2018-02-26 8:59 ` Ido Schimmel
2018-02-26 8:59 ` Ido Schimmel
2018-02-26 8:59 ` [PATCH net-next 13/14] selftests: forwarding: Introduce basic tc chains tests idosch
2018-02-26 8:59 ` Ido Schimmel
2018-02-26 8:59 ` Ido Schimmel
2018-02-26 8:59 ` [PATCH net-next 14/14] selftests: forwarding: Introduce basic shared blocks tests idosch
2018-02-26 8:59 ` Ido Schimmel
2018-02-26 8:59 ` Ido Schimmel
2018-02-26 13:35 ` [PATCH net-next 00/14] selftests: forwarding: Add VRF-based tests andrew
2018-02-26 13:35 ` Andrew Lunn
2018-02-26 13:35 ` Andrew Lunn
2018-02-26 13:46 ` jiri
2018-02-26 13:46 ` Jiri Pirko
2018-02-26 13:46 ` Jiri Pirko
2018-02-26 20:07 ` idosch
2018-02-26 20:07 ` Ido Schimmel
2018-02-26 20:07 ` Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180226200217.GB4195@splinter \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.