From: Ladislav Michl <ladis@linux-mips.org>
To: Tony Lindgren <tony@atomide.com>
Cc: linux-pwm@vger.kernel.org, aaro.koskinen@iki.fi,
Keerthy <j-keerthy@ti.com>,
daniel.lezcano@linaro.org, t-kristo@ti.com, robh+dt@kernel.org,
narmstrong@baylibre.com, thierry.reding@gmail.com,
Thomas Gleixner <tglx@linutronix.de>,
Brecht Neyrinck <brechtneyrinck@gmail.com>,
sebastian.reichel@collabora.co.uk, grygorii.strashko@ti.com,
linux-omap@vger.kernel.org, Claudiu.Beznea@microchip.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/6] clocksource: timer-ti-dm: Make unexported functions static
Date: Tue, 27 Feb 2018 20:07:52 +0100 [thread overview]
Message-ID: <20180227190752.GC1961@lenoch> (raw)
In-Reply-To: <20180227180641.GE5448@atomide.com>
On Tue, Feb 27, 2018 at 10:06:41AM -0800, Tony Lindgren wrote:
> * Ladislav Michl <ladis@linux-mips.org> [180223 10:14]:
> > As dmtimer no longer exports functions, make those previously
> > exported static (this requires few functions to be moved around
> > as their prototypes were deleted).
>
> Looks like this one fails to build with omap1_defconfig:
>
> drivers/clocksource/timer-ti-dm.c:935:14: error:
> 'omap_dm_timer_get_fclk' undeclared here
Umm, it compiled fine on top of previous versions, so I didn't bother
to retest. I'm sorry about it.
> Other than that the first three patches seem like nice
> clean-up :)
So are you okay with sending those separately as cleanup with above
issue fixed?
But to be honest, I'm more interested how to do the last two patches
right ;-)
> Regards,
>
> Tony
WARNING: multiple messages have this Message-ID (diff)
From: ladis@linux-mips.org (Ladislav Michl)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/6] clocksource: timer-ti-dm: Make unexported functions static
Date: Tue, 27 Feb 2018 20:07:52 +0100 [thread overview]
Message-ID: <20180227190752.GC1961@lenoch> (raw)
In-Reply-To: <20180227180641.GE5448@atomide.com>
On Tue, Feb 27, 2018 at 10:06:41AM -0800, Tony Lindgren wrote:
> * Ladislav Michl <ladis@linux-mips.org> [180223 10:14]:
> > As dmtimer no longer exports functions, make those previously
> > exported static (this requires few functions to be moved around
> > as their prototypes were deleted).
>
> Looks like this one fails to build with omap1_defconfig:
>
> drivers/clocksource/timer-ti-dm.c:935:14: error:
> 'omap_dm_timer_get_fclk' undeclared here
Umm, it compiled fine on top of previous versions, so I didn't bother
to retest. I'm sorry about it.
> Other than that the first three patches seem like nice
> clean-up :)
So are you okay with sending those separately as cleanup with above
issue fixed?
But to be honest, I'm more interested how to do the last two patches
right ;-)
> Regards,
>
> Tony
next prev parent reply other threads:[~2018-02-27 19:07 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-23 10:12 [PATCH 0/6] Implement event capture for OMAP (draft) Ladislav Michl
2018-02-23 10:12 ` Ladislav Michl
2018-02-23 10:13 ` [PATCH 1/6] clocksource: timer-ti-dm: Make unexported functions static Ladislav Michl
2018-02-23 10:13 ` Ladislav Michl
2018-02-27 18:06 ` Tony Lindgren
2018-02-27 18:06 ` Tony Lindgren
2018-02-27 19:07 ` Ladislav Michl [this message]
2018-02-27 19:07 ` Ladislav Michl
2018-02-27 19:23 ` Tony Lindgren
2018-02-27 19:23 ` Tony Lindgren
2018-02-28 22:11 ` Tony Lindgren
2018-02-28 22:11 ` Tony Lindgren
2018-02-23 10:14 ` [PATCH 2/6] clocksource: timer-ti-dm: Consolidate set source Ladislav Michl
2018-02-23 10:14 ` Ladislav Michl
2018-02-23 10:15 ` [PATCH 3/6] clocksource: timer-ti-dm: Check prescaler value Ladislav Michl
2018-02-23 10:15 ` Ladislav Michl
2018-02-23 10:15 ` [PATCH 4/6] pwm: pwm-omap-dmtimer: Fix frequency when using prescaler Ladislav Michl
2018-02-23 10:15 ` Ladislav Michl
2018-03-27 21:53 ` Thierry Reding
2018-03-27 21:53 ` Thierry Reding
2018-03-27 22:14 ` Thierry Reding
2018-03-27 22:14 ` Thierry Reding
2018-03-27 22:23 ` Tony Lindgren
2018-03-27 22:23 ` Tony Lindgren
2018-03-28 0:34 ` Ladislav Michl
2018-03-28 0:34 ` Ladislav Michl
2018-02-23 10:16 ` [PATCH 5/6] clocksource: timer-ti-dm: Add event capture Ladislav Michl
2018-02-23 10:16 ` Ladislav Michl
2018-02-23 10:17 ` [PATCH 6/6] pwm: pwm-omap-dmtimer: Add capture functionality Ladislav Michl
2018-02-23 10:17 ` Ladislav Michl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180227190752.GC1961@lenoch \
--to=ladis@linux-mips.org \
--cc=Claudiu.Beznea@microchip.com \
--cc=aaro.koskinen@iki.fi \
--cc=brechtneyrinck@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=grygorii.strashko@ti.com \
--cc=j-keerthy@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.reichel@collabora.co.uk \
--cc=t-kristo@ti.com \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.