All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Ladislav Michl <ladis@linux-mips.org>, Tony Lindgren <tony@atomide.com>
Cc: linux-pwm@vger.kernel.org, aaro.koskinen@iki.fi,
	Keerthy <j-keerthy@ti.com>,
	daniel.lezcano@linaro.org, t-kristo@ti.com,
	narmstrong@baylibre.com, robh+dt@kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Brecht Neyrinck <brechtneyrinck@gmail.com>,
	sebastian.reichel@collabora.co.uk, grygorii.strashko@ti.com,
	linux-omap@vger.kernel.org, Claudiu.Beznea@microchip.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/6] pwm: pwm-omap-dmtimer: Fix frequency when using prescaler
Date: Wed, 28 Mar 2018 00:14:02 +0200	[thread overview]
Message-ID: <20180327221401.GD28163@mithrandir> (raw)
In-Reply-To: <20180327215332.GC28163@mithrandir>


[-- Attachment #1.1: Type: text/plain, Size: 1121 bytes --]

On Tue, Mar 27, 2018 at 11:53:33PM +0200, Thierry Reding wrote:
> On Fri, Feb 23, 2018 at 11:15:53AM +0100, Ladislav Michl wrote:
> > Prescaler setting is currently not taken into account.
> > Fix that by introducing freq member variable and initialize
> > it at device probe time. This also avoids frequency
> > recomputing at each pwm configure time.
> > 
> > Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
> > ---
> >  drivers/pwm/pwm-omap-dmtimer.c | 93 +++++++++++++++++++++++++-----------------
> >  1 file changed, 55 insertions(+), 38 deletions(-)
> 
> Applied, thanks.

Actually, that was a little premature. It seems like this conflicts with
a patch series by Keerthy that Tony merged into his tree and that you've
based this on.

I think it'd be easiest if Tony merged this through the TI tree, or we
wait until v4.17-rc1 to resolve the dependency. Given how late we are in
the release cycle, I think it'd have to be the latter.

Tony, if you think you can find a way to still take this in for
v4.17-rc1, feel free to do so:

Acked-by: Thierry Reding <thierry.reding@gmail.com>

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: thierry.reding@gmail.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/6] pwm: pwm-omap-dmtimer: Fix frequency when using prescaler
Date: Wed, 28 Mar 2018 00:14:02 +0200	[thread overview]
Message-ID: <20180327221401.GD28163@mithrandir> (raw)
In-Reply-To: <20180327215332.GC28163@mithrandir>

On Tue, Mar 27, 2018 at 11:53:33PM +0200, Thierry Reding wrote:
> On Fri, Feb 23, 2018 at 11:15:53AM +0100, Ladislav Michl wrote:
> > Prescaler setting is currently not taken into account.
> > Fix that by introducing freq member variable and initialize
> > it at device probe time. This also avoids frequency
> > recomputing at each pwm configure time.
> > 
> > Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
> > ---
> >  drivers/pwm/pwm-omap-dmtimer.c | 93 +++++++++++++++++++++++++-----------------
> >  1 file changed, 55 insertions(+), 38 deletions(-)
> 
> Applied, thanks.

Actually, that was a little premature. It seems like this conflicts with
a patch series by Keerthy that Tony merged into his tree and that you've
based this on.

I think it'd be easiest if Tony merged this through the TI tree, or we
wait until v4.17-rc1 to resolve the dependency. Given how late we are in
the release cycle, I think it'd have to be the latter.

Tony, if you think you can find a way to still take this in for
v4.17-rc1, feel free to do so:

Acked-by: Thierry Reding <thierry.reding@gmail.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180328/c2b783c6/attachment.sig>

  reply	other threads:[~2018-03-27 22:14 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-23 10:12 [PATCH 0/6] Implement event capture for OMAP (draft) Ladislav Michl
2018-02-23 10:12 ` Ladislav Michl
2018-02-23 10:13 ` [PATCH 1/6] clocksource: timer-ti-dm: Make unexported functions static Ladislav Michl
2018-02-23 10:13   ` Ladislav Michl
2018-02-27 18:06   ` Tony Lindgren
2018-02-27 18:06     ` Tony Lindgren
2018-02-27 19:07     ` Ladislav Michl
2018-02-27 19:07       ` Ladislav Michl
2018-02-27 19:23       ` Tony Lindgren
2018-02-27 19:23         ` Tony Lindgren
2018-02-28 22:11         ` Tony Lindgren
2018-02-28 22:11           ` Tony Lindgren
2018-02-23 10:14 ` [PATCH 2/6] clocksource: timer-ti-dm: Consolidate set source Ladislav Michl
2018-02-23 10:14   ` Ladislav Michl
2018-02-23 10:15 ` [PATCH 3/6] clocksource: timer-ti-dm: Check prescaler value Ladislav Michl
2018-02-23 10:15   ` Ladislav Michl
2018-02-23 10:15 ` [PATCH 4/6] pwm: pwm-omap-dmtimer: Fix frequency when using prescaler Ladislav Michl
2018-02-23 10:15   ` Ladislav Michl
2018-03-27 21:53   ` Thierry Reding
2018-03-27 21:53     ` Thierry Reding
2018-03-27 22:14     ` Thierry Reding [this message]
2018-03-27 22:14       ` Thierry Reding
2018-03-27 22:23       ` Tony Lindgren
2018-03-27 22:23         ` Tony Lindgren
2018-03-28  0:34         ` Ladislav Michl
2018-03-28  0:34           ` Ladislav Michl
2018-02-23 10:16 ` [PATCH 5/6] clocksource: timer-ti-dm: Add event capture Ladislav Michl
2018-02-23 10:16   ` Ladislav Michl
2018-02-23 10:17 ` [PATCH 6/6] pwm: pwm-omap-dmtimer: Add capture functionality Ladislav Michl
2018-02-23 10:17   ` Ladislav Michl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180327221401.GD28163@mithrandir \
    --to=thierry.reding@gmail.com \
    --cc=Claudiu.Beznea@microchip.com \
    --cc=aaro.koskinen@iki.fi \
    --cc=brechtneyrinck@gmail.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=grygorii.strashko@ti.com \
    --cc=j-keerthy@ti.com \
    --cc=ladis@linux-mips.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=narmstrong@baylibre.com \
    --cc=robh+dt@kernel.org \
    --cc=sebastian.reichel@collabora.co.uk \
    --cc=t-kristo@ti.com \
    --cc=tglx@linutronix.de \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.