* [media] cpia2_usb: drop bogus interface-release call
@ 2018-03-07 9:49 ` Johan Hovold
0 siblings, 0 replies; 4+ messages in thread
From: Johan Hovold @ 2018-03-07 9:49 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: linux-media, linux-usb, Johan Hovold
Drop bogus call to usb_driver_release_interface() from the disconnect()
callback. As the interface is already being unbound at this point,
usb_driver_release_interface() simply returns early.
Signed-off-by: Johan Hovold <johan@kernel.org>
---
drivers/media/usb/cpia2/cpia2_usb.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/media/usb/cpia2/cpia2_usb.c b/drivers/media/usb/cpia2/cpia2_usb.c
index f3a1e5b1e57c..b51fc372ca25 100644
--- a/drivers/media/usb/cpia2/cpia2_usb.c
+++ b/drivers/media/usb/cpia2/cpia2_usb.c
@@ -910,9 +910,6 @@ static void cpia2_usb_disconnect(struct usb_interface *intf)
wake_up_interruptible(&cam->wq_stream);
}
- DBG("Releasing interface\n");
- usb_driver_release_interface(&cpia2_driver, intf);
-
LOG("CPiA2 camera disconnected.\n");
}
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] [media] cpia2_usb: drop bogus interface-release call
@ 2018-03-07 9:49 ` Johan Hovold
0 siblings, 0 replies; 4+ messages in thread
From: Johan Hovold @ 2018-03-07 9:49 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: linux-media, linux-usb, Johan Hovold
Drop bogus call to usb_driver_release_interface() from the disconnect()
callback. As the interface is already being unbound at this point,
usb_driver_release_interface() simply returns early.
Signed-off-by: Johan Hovold <johan@kernel.org>
---
drivers/media/usb/cpia2/cpia2_usb.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/media/usb/cpia2/cpia2_usb.c b/drivers/media/usb/cpia2/cpia2_usb.c
index f3a1e5b1e57c..b51fc372ca25 100644
--- a/drivers/media/usb/cpia2/cpia2_usb.c
+++ b/drivers/media/usb/cpia2/cpia2_usb.c
@@ -910,9 +910,6 @@ static void cpia2_usb_disconnect(struct usb_interface *intf)
wake_up_interruptible(&cam->wq_stream);
}
- DBG("Releasing interface\n");
- usb_driver_release_interface(&cpia2_driver, intf);
-
LOG("CPiA2 camera disconnected.\n");
}
--
2.16.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [media] cpia2_usb: drop bogus interface-release call
2018-03-07 9:49 ` [PATCH] " Johan Hovold
@ 2018-03-07 14:57 ` Greg KH
-1 siblings, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2018-03-07 14:57 UTC (permalink / raw)
To: Johan Hovold; +Cc: Mauro Carvalho Chehab, linux-media, linux-usb
On Wed, Mar 07, 2018 at 10:49:36AM +0100, Johan Hovold wrote:
> Drop bogus call to usb_driver_release_interface() from the disconnect()
> callback. As the interface is already being unbound at this point,
> usb_driver_release_interface() simply returns early.
>
> Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] [media] cpia2_usb: drop bogus interface-release call
@ 2018-03-07 14:57 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2018-03-07 14:57 UTC (permalink / raw)
To: Johan Hovold; +Cc: Mauro Carvalho Chehab, linux-media, linux-usb
On Wed, Mar 07, 2018 at 10:49:36AM +0100, Johan Hovold wrote:
> Drop bogus call to usb_driver_release_interface() from the disconnect()
> callback. As the interface is already being unbound at this point,
> usb_driver_release_interface() simply returns early.
>
> Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-03-07 14:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-07 9:49 [media] cpia2_usb: drop bogus interface-release call Johan Hovold
2018-03-07 9:49 ` [PATCH] " Johan Hovold
-- strict thread matches above, loose matches on Subject: below --
2018-03-07 14:57 Greg Kroah-Hartman
2018-03-07 14:57 ` [PATCH] " Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.