From: Tony Lindgren <tony@atomide.com>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
Mark Rutland <mark.rutland@arm.com>,
Marcel Partap <mpartap@gmx.net>,
Michael Scott <michael.scott@linaro.org>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCHv3] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4
Date: Thu, 8 Mar 2018 08:06:44 -0800 [thread overview]
Message-ID: <20180308160644.GJ5799@atomide.com> (raw)
In-Reply-To: <bff8014e-a0b6-8b7b-5de7-2a176e293933@ti.com>
* Kishon Vijay Abraham I <kishon@ti.com> [180308 08:23]:
> On Wednesday 07 March 2018 08:26 PM, Tony Lindgren wrote:
> > +config PHY_MAPPHONE_MDM6600
> > + tristate "Motorola Mapphone MDM6600 modem USB PHY driver"
> > + depends on OF && USB_SUPPORT
> > + select GENERIC_PHY
> > + select USB_PHY
>
> given that OTG is removed, USB_PHY won't be required anymore. Sorry for not
> stating this explicitly before.
Oh OK I did not know that.
> > + ddata->dev = &pdev->dev;
> > + ddata->phy.dev = ddata->dev;
> > + ddata->phy.label = "phy_mdm6600";
> > + ddata->phy.type = USB_PHY_TYPE_USB2;
>
> All of this can be removed since usb_phy is not required.
> > + usb_add_phy_dev(&ddata->phy);
>
> This should also be removed.
OK cool, will remove and post v4 hopefully tonight at some
point.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
Mark Rutland <mark.rutland@arm.com>,
Marcel Partap <mpartap@gmx.net>,
Michael Scott <michael.scott@linaro.org>,
Rob Herring <robh+dt@kernel.org>
Subject: [PATCHv3] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4
Date: Thu, 8 Mar 2018 08:06:44 -0800 [thread overview]
Message-ID: <20180308160644.GJ5799@atomide.com> (raw)
* Kishon Vijay Abraham I <kishon@ti.com> [180308 08:23]:
> On Wednesday 07 March 2018 08:26 PM, Tony Lindgren wrote:
> > +config PHY_MAPPHONE_MDM6600
> > + tristate "Motorola Mapphone MDM6600 modem USB PHY driver"
> > + depends on OF && USB_SUPPORT
> > + select GENERIC_PHY
> > + select USB_PHY
>
> given that OTG is removed, USB_PHY won't be required anymore. Sorry for not
> stating this explicitly before.
Oh OK I did not know that.
> > + ddata->dev = &pdev->dev;
> > + ddata->phy.dev = ddata->dev;
> > + ddata->phy.label = "phy_mdm6600";
> > + ddata->phy.type = USB_PHY_TYPE_USB2;
>
> All of this can be removed since usb_phy is not required.
> > + usb_add_phy_dev(&ddata->phy);
>
> This should also be removed.
OK cool, will remove and post v4 hopefully tonight at some
point.
Regards,
Tony
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-03-08 16:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-07 14:56 [PATCHv3] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4 Tony Lindgren
2018-03-07 14:56 ` Tony Lindgren
2018-03-08 8:22 ` Kishon Vijay Abraham I
2018-03-08 8:22 ` Kishon Vijay Abraham I
2018-03-08 8:22 ` Kishon Vijay Abraham I
2018-03-08 16:06 ` Tony Lindgren [this message]
2018-03-08 16:06 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180308160644.GJ5799@atomide.com \
--to=tony@atomide.com \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michael.scott@linaro.org \
--cc=mpartap@gmx.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.