All of lore.kernel.org
 help / color / mirror / Atom feed
From: LW@KARO-electronics.de (Lothar Waßmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: i.MX25: define SSI FIFO depth
Date: Thu, 8 Mar 2018 16:11:35 +0100	[thread overview]
Message-ID: <20180308161135.1f3d3d18@karo-electronics.de> (raw)
In-Reply-To: <1520373499-13623-1-git-send-email-martin@kaiser.cx>

Hi,

On Tue,  6 Mar 2018 22:58:19 +0100 Martin Kaiser wrote:
> According to the i.MX25 reference manuals, each SSI has four FIFOs. All
> of those FIFOs can store up to 15 entries.
> 
> The fsl_ssi driver's internal default for the FIFO depth in 8. Set our
> non-default FIFO depth explicitly in the Device Tree.
> 
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
>  arch/arm/boot/dts/imx25.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi
> index 9725705..cf70df2 100644
> --- a/arch/arm/boot/dts/imx25.dtsi
> +++ b/arch/arm/boot/dts/imx25.dtsi
> @@ -269,6 +269,7 @@
>  				dmas = <&sdma 24 1 0>,
>  				       <&sdma 25 1 0>;
>  				dma-names = "rx", "tx";
> +				fsl,fifo-depth = <15>;
>  				status = "disabled";
>  			};
>  
> @@ -329,6 +330,7 @@
>  				dmas = <&sdma 28 1 0>,
>  				       <&sdma 29 1 0>;
>  				dma-names = "rx", "tx";
> +				fsl,fifo-depth = <15>;
>  				status = "disabled";
>  			};
>  
You are changing the global .dtsi file. Did you test this change with
all devices that are affected by it?


Lothar Wa?mann

WARNING: multiple messages have this Message-ID (diff)
From: "Lothar Waßmann" <LW@KARO-electronics.de>
To: Martin Kaiser <martin@kaiser.cx>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, Russell King <linux@armlinux.org.uk>,
	linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	Sascha Hauer <kernel@pengutronix.de>,
	Fabio Estevam <fabio.estevam@nxp.com>,
	Shawn Guo <shawnguo@kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: i.MX25: define SSI FIFO depth
Date: Thu, 8 Mar 2018 16:11:35 +0100	[thread overview]
Message-ID: <20180308161135.1f3d3d18@karo-electronics.de> (raw)
In-Reply-To: <1520373499-13623-1-git-send-email-martin@kaiser.cx>

Hi,

On Tue,  6 Mar 2018 22:58:19 +0100 Martin Kaiser wrote:
> According to the i.MX25 reference manuals, each SSI has four FIFOs. All
> of those FIFOs can store up to 15 entries.
> 
> The fsl_ssi driver's internal default for the FIFO depth in 8. Set our
> non-default FIFO depth explicitly in the Device Tree.
> 
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
>  arch/arm/boot/dts/imx25.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi
> index 9725705..cf70df2 100644
> --- a/arch/arm/boot/dts/imx25.dtsi
> +++ b/arch/arm/boot/dts/imx25.dtsi
> @@ -269,6 +269,7 @@
>  				dmas = <&sdma 24 1 0>,
>  				       <&sdma 25 1 0>;
>  				dma-names = "rx", "tx";
> +				fsl,fifo-depth = <15>;
>  				status = "disabled";
>  			};
>  
> @@ -329,6 +330,7 @@
>  				dmas = <&sdma 28 1 0>,
>  				       <&sdma 29 1 0>;
>  				dma-names = "rx", "tx";
> +				fsl,fifo-depth = <15>;
>  				status = "disabled";
>  			};
>  
You are changing the global .dtsi file. Did you test this change with
all devices that are affected by it?


Lothar Waßmann

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: "Lothar Waßmann" <LW@KARO-electronics.de>
To: Martin Kaiser <martin@kaiser.cx>
Cc: Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <kernel@pengutronix.de>,
	Fabio Estevam <fabio.estevam@nxp.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Russell King <linux@armlinux.org.uk>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: i.MX25: define SSI FIFO depth
Date: Thu, 8 Mar 2018 16:11:35 +0100	[thread overview]
Message-ID: <20180308161135.1f3d3d18@karo-electronics.de> (raw)
In-Reply-To: <1520373499-13623-1-git-send-email-martin@kaiser.cx>

Hi,

On Tue,  6 Mar 2018 22:58:19 +0100 Martin Kaiser wrote:
> According to the i.MX25 reference manuals, each SSI has four FIFOs. All
> of those FIFOs can store up to 15 entries.
> 
> The fsl_ssi driver's internal default for the FIFO depth in 8. Set our
> non-default FIFO depth explicitly in the Device Tree.
> 
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
>  arch/arm/boot/dts/imx25.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi
> index 9725705..cf70df2 100644
> --- a/arch/arm/boot/dts/imx25.dtsi
> +++ b/arch/arm/boot/dts/imx25.dtsi
> @@ -269,6 +269,7 @@
>  				dmas = <&sdma 24 1 0>,
>  				       <&sdma 25 1 0>;
>  				dma-names = "rx", "tx";
> +				fsl,fifo-depth = <15>;
>  				status = "disabled";
>  			};
>  
> @@ -329,6 +330,7 @@
>  				dmas = <&sdma 28 1 0>,
>  				       <&sdma 29 1 0>;
>  				dma-names = "rx", "tx";
> +				fsl,fifo-depth = <15>;
>  				status = "disabled";
>  			};
>  
You are changing the global .dtsi file. Did you test this change with
all devices that are affected by it?


Lothar Waßmann

  parent reply	other threads:[~2018-03-08 15:11 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-06 21:58 [PATCH] ARM: dts: i.MX25: define SSI FIFO depth Martin Kaiser
2018-03-06 21:58 ` Martin Kaiser
2018-03-06 22:04 ` Fabio Estevam
2018-03-06 22:04   ` Fabio Estevam
2018-03-08 15:11 ` Lothar Waßmann [this message]
2018-03-08 15:11   ` Lothar Waßmann
2018-03-08 15:11   ` Lothar Waßmann
2018-03-08 15:38   ` Martin Kaiser
2018-03-08 15:38     ` Martin Kaiser
2018-03-08 15:38     ` Martin Kaiser
2018-03-09  8:37     ` Lothar Waßmann
2018-03-09  8:37       ` Lothar Waßmann
2018-03-09  9:25       ` Martin Kaiser
2018-03-09  9:25         ` Martin Kaiser
2018-03-09  9:27       ` Lucas Stach
2018-03-09  9:27         ` Lucas Stach
2018-03-09 15:40         ` Lothar Waßmann
2018-03-09 15:40           ` Lothar Waßmann
2018-03-12  7:24 ` Shawn Guo
2018-03-12  7:24   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180308161135.1f3d3d18@karo-electronics.de \
    --to=lw@karo-electronics.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.