From: Borislav Petkov <bp@alien8.de>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [v4] EDAC, sb_edac: Remove VLA usage
Date: Sat, 17 Mar 2018 05:30:41 +0100 [thread overview]
Message-ID: <20180317043040.GA973@pd.tnic> (raw)
On Wed, Mar 14, 2018 at 01:21:32PM -0500, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wvla, remove VLA and replace it
> with a fixed-length array instead.
>
> Fixed as part of the directive to remove all VLAs from
> the kernel: https://lkml.org/lkml/2018/3/7/621
>
> Also, remove max_interleave as it is no longer useful.
>
> Reviewed-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> Changes in v4:
> - Remove max_interleave.
>
> Changes in v3:
> - Update macro MAX_INTERLEAVE in order to avoid too long lines.
> This change is based on Mauro's feedback.
> - Update changelog with Mauro's Reviewed-by.
>
> Changes in v2:
> - Use macro max_t to compute the max of all three array sizes.
> This change is based on Borislav's feedback.
>
> drivers/edac/sb_edac.c | 12 +++++-------
> 1 file changed, 5 insertions(+), 7 deletions(-)
Applied, thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp@alien8.de>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] EDAC, sb_edac: Remove VLA usage
Date: Sat, 17 Mar 2018 05:30:41 +0100 [thread overview]
Message-ID: <20180317043040.GA973@pd.tnic> (raw)
In-Reply-To: <20180314182131.GA25259@embeddedgus>
On Wed, Mar 14, 2018 at 01:21:32PM -0500, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wvla, remove VLA and replace it
> with a fixed-length array instead.
>
> Fixed as part of the directive to remove all VLAs from
> the kernel: https://lkml.org/lkml/2018/3/7/621
>
> Also, remove max_interleave as it is no longer useful.
>
> Reviewed-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> Changes in v4:
> - Remove max_interleave.
>
> Changes in v3:
> - Update macro MAX_INTERLEAVE in order to avoid too long lines.
> This change is based on Mauro's feedback.
> - Update changelog with Mauro's Reviewed-by.
>
> Changes in v2:
> - Use macro max_t to compute the max of all three array sizes.
> This change is based on Borislav's feedback.
>
> drivers/edac/sb_edac.c | 12 +++++-------
> 1 file changed, 5 insertions(+), 7 deletions(-)
Applied, thanks.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next reply other threads:[~2018-03-17 4:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-17 4:30 Borislav Petkov [this message]
2018-03-17 4:30 ` [PATCH v4] EDAC, sb_edac: Remove VLA usage Borislav Petkov
-- strict thread matches above, loose matches on Subject: below --
2018-03-14 18:21 [v4] " Gustavo A. R. Silva
2018-03-14 18:21 ` [PATCH v4] " Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180317043040.GA973@pd.tnic \
--to=bp@alien8.de \
--cc=gustavo@embeddedor.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.