* [PATCH] drm/gma500: simplify a condition in psbfb_mmap()
@ 2018-03-23 11:44 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2018-03-23 11:44 UTC (permalink / raw)
To: Patrik Jakobsson; +Cc: David Airlie, kernel-janitors, dri-devel
Since we enforce that "vma->vm_pgoff" has to be zero it means we don't
need an additional cap on the upper bound.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/gma500/framebuffer.c b/drivers/gpu/drm/gma500/framebuffer.c
index cb0a2ae916e0..a6732bffb2e2 100644
--- a/drivers/gpu/drm/gma500/framebuffer.c
+++ b/drivers/gpu/drm/gma500/framebuffer.c
@@ -166,9 +166,7 @@ static int psbfb_mmap(struct fb_info *info, struct vm_area_struct *vma)
struct psb_fbdev *fbdev = info->par;
struct psb_framebuffer *psbfb = &fbdev->pfb;
- if (vma->vm_pgoff != 0)
- return -EINVAL;
- if (vma->vm_pgoff > (~0UL >> PAGE_SHIFT))
+ if (vma->vm_pgoff)
return -EINVAL;
if (!psbfb->addr_space)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] drm/gma500: simplify a condition in psbfb_mmap()
@ 2018-03-23 11:44 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2018-03-23 11:44 UTC (permalink / raw)
To: Patrik Jakobsson; +Cc: David Airlie, kernel-janitors, dri-devel
Since we enforce that "vma->vm_pgoff" has to be zero it means we don't
need an additional cap on the upper bound.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/gma500/framebuffer.c b/drivers/gpu/drm/gma500/framebuffer.c
index cb0a2ae916e0..a6732bffb2e2 100644
--- a/drivers/gpu/drm/gma500/framebuffer.c
+++ b/drivers/gpu/drm/gma500/framebuffer.c
@@ -166,9 +166,7 @@ static int psbfb_mmap(struct fb_info *info, struct vm_area_struct *vma)
struct psb_fbdev *fbdev = info->par;
struct psb_framebuffer *psbfb = &fbdev->pfb;
- if (vma->vm_pgoff != 0)
- return -EINVAL;
- if (vma->vm_pgoff > (~0UL >> PAGE_SHIFT))
+ if (vma->vm_pgoff)
return -EINVAL;
if (!psbfb->addr_space)
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-23 11:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-23 11:44 [PATCH] drm/gma500: simplify a condition in psbfb_mmap() Dan Carpenter
2018-03-23 11:44 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.