From: Keith Busch <keith.busch@intel.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Linux NVMe <linux-nvme@lists.infradead.org>,
Linux Block <linux-block@vger.kernel.org>,
Sagi Grimberg <sagi@grimberg.me>,
Jianchao Wang <jianchao.w.wang@oracle.com>,
Ming Lei <ming.lei@redhat.com>, Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH 3/3] nvme-pci: Separate IO and admin queue IRQ vectors
Date: Wed, 28 Mar 2018 14:38:03 -0600 [thread overview]
Message-ID: <20180328203803.GL13039@localhost.localdomain> (raw)
In-Reply-To: <20180328073214.GA18726@lst.de>
On Wed, Mar 28, 2018 at 09:32:14AM +0200, Christoph Hellwig wrote:
> On Tue, Mar 27, 2018 at 09:39:08AM -0600, Keith Busch wrote:
> > - return blk_mq_pci_map_queues(set, to_pci_dev(dev->dev), 0);
> > + return blk_mq_pci_map_queues(set, to_pci_dev(dev->dev),
> > + dev->num_vecs > 1);
>
> Can you turn this into:
>
> - return blk_mq_pci_map_queues(set, to_pci_dev(dev->dev), 0);
> dev->num_vecs > 1 ? 1 /* admin queue */ : 0);
>
> no functional change, but much easier to understand.
>
> Except for that the whole series looks good:
Sounds good, thanks for the reviews, Christoph and Ming.
Updated with your suggestion and applied (Jens picked up the blk-mq part;
nvme-4.17 is rebased to that).
WARNING: multiple messages have this Message-ID (diff)
From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH 3/3] nvme-pci: Separate IO and admin queue IRQ vectors
Date: Wed, 28 Mar 2018 14:38:03 -0600 [thread overview]
Message-ID: <20180328203803.GL13039@localhost.localdomain> (raw)
In-Reply-To: <20180328073214.GA18726@lst.de>
On Wed, Mar 28, 2018@09:32:14AM +0200, Christoph Hellwig wrote:
> On Tue, Mar 27, 2018@09:39:08AM -0600, Keith Busch wrote:
> > - return blk_mq_pci_map_queues(set, to_pci_dev(dev->dev), 0);
> > + return blk_mq_pci_map_queues(set, to_pci_dev(dev->dev),
> > + dev->num_vecs > 1);
>
> Can you turn this into:
>
> - return blk_mq_pci_map_queues(set, to_pci_dev(dev->dev), 0);
> dev->num_vecs > 1 ? 1 /* admin queue */ : 0);
>
> no functional change, but much easier to understand.
>
> Except for that the whole series looks good:
Sounds good, thanks for the reviews, Christoph and Ming.
Updated with your suggestion and applied (Jens picked up the blk-mq part;
nvme-4.17 is rebased to that).
next prev parent reply other threads:[~2018-03-28 20:35 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-27 15:39 [PATCH 1/3] blk-mq: Allow PCI vector offset for mapping queues Keith Busch
2018-03-27 15:39 ` Keith Busch
2018-03-27 15:39 ` [PATCH 2/3] nvme-pci: Remove unused queue parameter Keith Busch
2018-03-27 15:39 ` Keith Busch
2018-03-28 1:27 ` Ming Lei
2018-03-28 1:27 ` Ming Lei
2018-03-27 15:39 ` [PATCH 3/3] nvme-pci: Separate IO and admin queue IRQ vectors Keith Busch
2018-03-27 15:39 ` Keith Busch
2018-03-28 2:08 ` Ming Lei
2018-03-28 2:08 ` Ming Lei
2018-03-28 7:32 ` Christoph Hellwig
2018-03-28 7:32 ` Christoph Hellwig
2018-03-28 20:38 ` Keith Busch [this message]
2018-03-28 20:38 ` Keith Busch
2018-03-28 1:26 ` [PATCH 1/3] blk-mq: Allow PCI vector offset for mapping queues Ming Lei
2018-03-28 1:26 ` Ming Lei
2018-03-28 3:24 ` Jens Axboe
2018-03-28 3:24 ` Jens Axboe
2018-03-28 14:48 ` Don Brace
2018-03-28 14:48 ` Don Brace
-- strict thread matches above, loose matches on Subject: below --
2018-03-23 22:19 Keith Busch
2018-03-23 22:19 ` [PATCH 3/3] nvme-pci: Separate IO and admin queue IRQ vectors Keith Busch
2018-03-23 22:19 ` Keith Busch
2018-03-27 14:20 ` Christoph Hellwig
2018-03-27 14:20 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180328203803.GL13039@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=jianchao.w.wang@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.lei@redhat.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.