From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <keith.busch@intel.com>
Cc: Linux NVMe <linux-nvme@lists.infradead.org>,
Linux Block <linux-block@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Jianchao Wang <jianchao.w.wang@oracle.com>,
Ming Lei <ming.lei@redhat.com>, Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH 3/3] nvme-pci: Separate IO and admin queue IRQ vectors
Date: Tue, 27 Mar 2018 16:20:01 +0200 [thread overview]
Message-ID: <20180327142001.GC4724@lst.de> (raw)
In-Reply-To: <20180323221923.24545-3-keith.busch@intel.com>
> +static inline unsigned int nvme_ioq_vector(struct nvme_dev *dev,
> + unsigned int qid)
No need for the inline here I think.
> +{
> + /*
> + * A queue's vector matches the queue identifier unless the controller
> + * has only one vector available.
> + */
> + return (dev->num_vecs == 1) ? 0 : qid;
and no need for the braces here.
> + struct irq_affinity affd = {.pre_vectors = 1};
struct irq_affinity affd = {
.pre_vectors = 1
};
to make it a little more readable.
WARNING: multiple messages have this Message-ID (diff)
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 3/3] nvme-pci: Separate IO and admin queue IRQ vectors
Date: Tue, 27 Mar 2018 16:20:01 +0200 [thread overview]
Message-ID: <20180327142001.GC4724@lst.de> (raw)
In-Reply-To: <20180323221923.24545-3-keith.busch@intel.com>
> +static inline unsigned int nvme_ioq_vector(struct nvme_dev *dev,
> + unsigned int qid)
No need for the inline here I think.
> +{
> + /*
> + * A queue's vector matches the queue identifier unless the controller
> + * has only one vector available.
> + */
> + return (dev->num_vecs == 1) ? 0 : qid;
and no need for the braces here.
> + struct irq_affinity affd = {.pre_vectors = 1};
struct irq_affinity affd = {
.pre_vectors = 1
};
to make it a little more readable.
next prev parent reply other threads:[~2018-03-27 14:20 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-23 22:19 [PATCH 1/3] blk-mq: Allow PCI vector offset for mapping queues Keith Busch
2018-03-23 22:19 ` Keith Busch
2018-03-23 22:19 ` [PATCH 2/3] nvme-pci: Remove unused queue parameter Keith Busch
2018-03-23 22:19 ` Keith Busch
2018-03-26 1:47 ` Ming Lei
2018-03-26 1:47 ` Ming Lei
2018-03-26 14:48 ` Keith Busch
2018-03-26 14:48 ` Keith Busch
2018-03-27 14:17 ` Christoph Hellwig
2018-03-27 14:17 ` Christoph Hellwig
2018-03-23 22:19 ` [PATCH 3/3] nvme-pci: Separate IO and admin queue IRQ vectors Keith Busch
2018-03-23 22:19 ` Keith Busch
2018-03-27 14:20 ` Christoph Hellwig [this message]
2018-03-27 14:20 ` Christoph Hellwig
2018-03-24 13:55 ` [PATCH 1/3] blk-mq: Allow PCI vector offset for mapping queues jianchao.wang
2018-03-24 13:55 ` jianchao.wang
2018-03-26 19:33 ` Keith Busch
2018-03-26 19:33 ` Keith Busch
2018-03-26 1:50 ` Ming Lei
2018-03-26 1:50 ` Ming Lei
2018-03-26 19:37 ` Keith Busch
2018-03-26 19:37 ` Keith Busch
2018-03-27 14:17 ` Christoph Hellwig
2018-03-27 14:17 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2018-03-27 15:39 Keith Busch
2018-03-27 15:39 ` [PATCH 3/3] nvme-pci: Separate IO and admin queue IRQ vectors Keith Busch
2018-03-27 15:39 ` Keith Busch
2018-03-28 2:08 ` Ming Lei
2018-03-28 2:08 ` Ming Lei
2018-03-28 7:32 ` Christoph Hellwig
2018-03-28 7:32 ` Christoph Hellwig
2018-03-28 20:38 ` Keith Busch
2018-03-28 20:38 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180327142001.GC4724@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=jianchao.w.wang@oracle.com \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.lei@redhat.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.