[meta-raspberrypi] Has anybody run VC4 + X + recent meta/masters lately

[meta-raspberrypi] Has anybody run VC4 + X + recent meta/masters lately

[Andreas Müller]

Hi,

To prepare for sumo I updated all my oe-metas from more or less rocko
to recent masters. Since then I am in trouble with VC4/GL/GLES on
Raspi:

* On X start glmark2-es: complains with 'Modifier 0x0 vs. tiling
(0x7000000000000001) mismatch and window remains black
* On Wayland (weston) glmark2-es-wayland works without issues

OK - I am still sitting on my  meta-raspi-light fork (and am still
promising to come back here with patches :) but I checked: Both layers
are close regarding X and mesa so I'd expect similar results.

To check if mesa might need a later kernel I tried with 4.14 -> same
behaviour. Anybody else with similar issues?

Andreas

Re: [meta-raspberrypi] Has anybody run VC4 + X + recent meta/masters lately

[Trevor Woerner]

[-- Attachment #1: Type: text/plain, Size: 18 bytes --]

64bit RPi or 32?

[-- Attachment #2: Type: text/html, Size: 43 bytes --]

Re: [meta-raspberrypi] Has anybody run VC4 + X + recent meta/masters lately

[Khem Raj]

64bit with mesa yes, for 32bit I usually test on wayland+Westeros+WPE

2018-03-29 12:26 GMT-07:00 Trevor Woerner <twoerner@gmail.com>:
> 64bit RPi or 32?
>
> --
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto
>

Re: [meta-raspberrypi] Has anybody run VC4 + X + recent meta/masters lately

[Andreas Müller]

On Thu, Mar 29, 2018 at 9:29 PM, Khem Raj <raj.khem@gmail.com> wrote:
> 64bit with mesa yes, for 32bit I usually test on wayland+Westeros+WPE
>
> 2018-03-29 12:26 GMT-07:00 Trevor Woerner <twoerner@gmail.com>:
>> 64bit RPi or 32?
>>
>> --
>> _______________________________________________
>> yocto mailing list
>> yocto@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/yocto
>>
Have 32Bit still

Re: [meta-raspberrypi] Has anybody run VC4 + X + recent meta/masters lately

[Andreas Müller]

On Thu, Mar 29, 2018 at 10:23 PM, Andreas Müller
<schnitzeltony@gmail.com> wrote:
> On Thu, Mar 29, 2018 at 9:29 PM, Khem Raj <raj.khem@gmail.com> wrote:
>> 64bit with mesa yes, for 32bit I usually test on wayland+Westeros+WPE
>>
>> 2018-03-29 12:26 GMT-07:00 Trevor Woerner <twoerner@gmail.com>:
>>> 64bit RPi or 32?
>>>
>>> --
Have a bit more information now:

By the update I moved from mesa 17.1.7 -> 17.3.7.

I git diff'ed  around a bit:

* Tiling was introduced (or just reworked?)
* the error message is created in vc4_resource_from_handle. The handle
coming in has modifier DRM_FORMAT_MOD_LINEAR (0x) but kernel says 'hey
I support tiling' DRM_FORMAT_MOD_BROADCOM_VC4_T_TILED
(0x7000000000000001) [1].

With this I'll try some hacks and then ask at mesa mailing list what
might be reason for it (a really bad timing for this...)

Cheers

[1] https://cgit.freedesktop.org/mesa/mesa/tree/src/gallium/drivers/vc4/vc4_resource.c?h=17.3#n745

Andreas

Re: [meta-raspberrypi] Has anybody run VC4 + X + recent meta/masters lately

[Andreas Müller]

[-- Attachment #1: Type: text/plain, Size: 1162 bytes --]

On Thu, Mar 29, 2018 at 10:37 PM, Andreas Müller
<schnitzeltony@gmail.com> wrote:
> On Thu, Mar 29, 2018 at 10:23 PM, Andreas Müller
> <schnitzeltony@gmail.com> wrote:
>> On Thu, Mar 29, 2018 at 9:29 PM, Khem Raj <raj.khem@gmail.com> wrote:
>>> 64bit with mesa yes, for 32bit I usually test on wayland+Westeros+WPE
>>>
>>> 2018-03-29 12:26 GMT-07:00 Trevor Woerner <twoerner@gmail.com>:
>>>> 64bit RPi or 32?
>>>>
>>>> --
> Have a bit more information now:
>
> By the update I moved from mesa 17.1.7 -> 17.3.7.
>
> I git diff'ed  around a bit:
>
> * Tiling was introduced (or just reworked?)
> * the error message is created in vc4_resource_from_handle. The handle
> coming in has modifier DRM_FORMAT_MOD_LINEAR (0x) but kernel says 'hey
> I support tiling' DRM_FORMAT_MOD_BROADCOM_VC4_T_TILED
> (0x7000000000000001) [1].
>
> With this I'll try some hacks and then ask at mesa mailing list what
> might be reason for it (a really bad timing for this...)
>
> Cheers
>
> [1] https://cgit.freedesktop.org/mesa/mesa/tree/src/gallium/drivers/vc4/vc4_resource.c?h=17.3#n745
>
LOL with hack attached I can see horses again:)

Andreas

[-- Attachment #2: 0001-Hack-tiling.patch --]
[-- Type: text/x-patch, Size: 1307 bytes --]

From 281e0934c39408c910a0a6556ad356d0955ca64d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andreas=20M=C3=BCller?= <schnitzeltony@gmail.com>
Date: Thu, 29 Mar 2018 22:18:25 +0200
Subject: [PATCH] Hack tiling
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
---
 src/gallium/drivers/vc4/vc4_resource.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/gallium/drivers/vc4/vc4_resource.c b/src/gallium/drivers/vc4/vc4_resource.c
index cdcbcc917e..472e6dd618 100644
--- a/src/gallium/drivers/vc4/vc4_resource.c
+++ b/src/gallium/drivers/vc4/vc4_resource.c
@@ -742,6 +742,9 @@ vc4_resource_from_handle(struct pipe_screen *pscreen,
                 whandle->modifier = DRM_FORMAT_MOD_LINEAR;
         } else if (whandle->modifier == DRM_FORMAT_MOD_INVALID) {
                 whandle->modifier = get_tiling.modifier;
+        } else if (whandle->modifier == DRM_FORMAT_MOD_LINEAR && 
+                   get_tiling.modifier == DRM_FORMAT_MOD_BROADCOM_VC4_T_TILED) {
+                whandle->modifier = get_tiling.modifier;
         } else if (whandle->modifier != get_tiling.modifier) {
                 fprintf(stderr,
                         "Modifier 0x%llx vs. tiling (0x%llx) mismatch\n",
-- 
2.14.3

Re: [meta-raspberrypi] Has anybody run VC4 + X + recent meta/masters lately

[Trevor Woerner]

[-- Attachment #1: Type: text/plain, Size: 271 bytes --]

I've seen the 'Modifier 0x0 vs. tiling(0x7000000000000001) mismatch' error
and blank screen hundreds of times while working on getting chromium-x11
accelerated. It would happen if chromium was trying to use the system
gl/gles libraries instead of the ones it builds.

[-- Attachment #2: Type: text/html, Size: 305 bytes --]

Re: [meta-raspberrypi] Has anybody run VC4 + X + recent meta/masters lately

[Andreas Müller]

On Thu, Mar 29, 2018 at 11:05 PM, Trevor Woerner <twoerner@gmail.com> wrote:
> I've seen the 'Modifier 0x0 vs. tiling(0x7000000000000001) mismatch' error
> and blank screen hundreds of times while working on getting chromium-x11
> accelerated. It would happen if chromium was trying to use the system
> gl/gles libraries instead of the ones it builds.
Then you should give that patch a try - change is in mesa-megadriver
package (building images after mesa changes takes LONG...)

Some appetizer: glmark on mesa 17.1.7 reports 110 / glmark on mesa
17.1.7 reports 145!

As said: will post this to mesa mailing list but for today I'll just
dance on fast-nude-horse-party :)

Have fun

Andreas

Re: [meta-raspberrypi] Has anybody run VC4 + X + recent meta/masters lately

[Andreas Müller]

On Thu, Mar 29, 2018 at 11:23 PM, Andreas Müller
<schnitzeltony@gmail.com> wrote:
> On Thu, Mar 29, 2018 at 11:05 PM, Trevor Woerner <twoerner@gmail.com> wrote:
>> I've seen the 'Modifier 0x0 vs. tiling(0x7000000000000001) mismatch' error
>> and blank screen hundreds of times while working on getting chromium-x11
>> accelerated. It would happen if chromium was trying to use the system
>> gl/gles libraries instead of the ones it builds.
> Then you should give that patch a try - change is in mesa-megadriver
> package (building images after mesa changes takes LONG...)
>
> Some appetizer: glmark on mesa 17.1.7 reports 110 / glmark on mesa
> 17.1.7 reports 145!
glmark-es2
>
> As said: will post this to mesa mailing list but for today I'll just
> dance on fast-nude-horse-party :)
>
> Have fun
>
> Andreas

Re: [meta-raspberrypi] Has anybody run VC4 + X + recent meta/masters lately

[Trevor Woerner]

On Thu 2018-03-29 @ 11:34:08 PM, Andreas Müller wrote:
> On Thu, Mar 29, 2018 at 11:23 PM, Andreas Müller
> <schnitzeltony@gmail.com> wrote:
> > On Thu, Mar 29, 2018 at 11:05 PM, Trevor Woerner <twoerner@gmail.com> wrote:
> >> I've seen the 'Modifier 0x0 vs. tiling(0x7000000000000001) mismatch' error
> >> and blank screen hundreds of times while working on getting chromium-x11
> >> accelerated. It would happen if chromium was trying to use the system
> >> gl/gles libraries instead of the ones it builds.
> > Then you should give that patch a try - change is in mesa-megadriver
> > package (building images after mesa changes takes LONG...)

The solution was to let the two gl libraries install without interfering with
each other (i.e. to separate locations). If I didn't install the ones chromium
built, it would try to use the system ones and fail. If I installed both and
it found its own, it would succeed. So I found a solution and didn't need to
dig into this 'modifier vs tiling' issue.

Having said that, I'm curious to try your patch on rpi3-64. I have never been
able to get vc4 working on x11 with a 64-bit build (it also gives a 'modifier
vs tiling' error).

> > Some appetizer: glmark on mesa 17.1.7 reports 110 / glmark on mesa
> > 17.1.7 reports 145!

cool!

Re: [meta-raspberrypi] Has anybody run VC4 + X + recent meta/masters lately

[Andreas Müller]

On Thu, Mar 29, 2018 at 11:46 PM, Trevor Woerner <twoerner@gmail.com> wrote:
> On Thu 2018-03-29 @ 11:34:08 PM, Andreas Müller wrote:
>> On Thu, Mar 29, 2018 at 11:23 PM, Andreas Müller
>> <schnitzeltony@gmail.com> wrote:
>> > On Thu, Mar 29, 2018 at 11:05 PM, Trevor Woerner <twoerner@gmail.com> wrote:
>> >> I've seen the 'Modifier 0x0 vs. tiling(0x7000000000000001) mismatch' error
>> >> and blank screen hundreds of times while working on getting chromium-x11
>> >> accelerated. It would happen if chromium was trying to use the system
>> >> gl/gles libraries instead of the ones it builds.
>> > Then you should give that patch a try - change is in mesa-megadriver
>> > package (building images after mesa changes takes LONG...)
>
> The solution was to let the two gl libraries install without interfering with
> each other (i.e. to separate locations). If I didn't install the ones chromium
> built, it would try to use the system ones and fail. If I installed both and
> it found its own, it would succeed. So I found a solution and didn't need to
> dig into this 'modifier vs tiling' issue.
>
> Having said that, I'm curious to try your patch on rpi3-64. I have never been
> able to get vc4 working on x11 with a 64-bit build (it also gives a 'modifier
> vs tiling' error).
>
>> > Some appetizer: glmark on mesa 17.1.7 reports 110 / glmark on mesa
>> > 17.1.7 reports 145!
>
> cool!
After party hangover: sddm and kde look horrible with this patch.
Should respect linear if requested explicitly - wonder if that slows
down horses...

Andreas

Re: [meta-raspberrypi] Has anybody run VC4 + X + recent meta/masters lately

[Trevor Woerner]

[-- Attachment #1: Type: text/plain, Size: 403 bytes --]

On Fri, Mar 30, 2018 at 6:45 AM, Andreas Müller <schnitzeltony@gmail.com>
wrote:

> After party hangover: sddm and kde look horrible with this patch.
> Should respect linear if requested explicitly - wonder if that slows
> down horses...
>

Out of curiosity, are you going to follow up on this? Maybe with the mesa
people?
When I encountered this issue, my google-foo didn't yield anything.

[-- Attachment #2: Type: text/html, Size: 818 bytes --]

Re: [meta-raspberrypi] Has anybody run VC4 + X + recent meta/masters lately

[Andreas Müller]

On Mon, Apr 2, 2018 at 5:10 AM, Trevor Woerner <twoerner@gmail.com> wrote:
> On Fri, Mar 30, 2018 at 6:45 AM, Andreas Müller <schnitzeltony@gmail.com>
> wrote:
>>
>> After party hangover: sddm and kde look horrible with this patch.
>> Should respect linear if requested explicitly - wonder if that slows
>> down horses...
>
>
> Out of curiosity, are you going to follow up on this? Maybe with the mesa
> people?
> When I encountered this issue, my google-foo didn't yield anything.
I did already [1].

My problem was that meta-raspi-light did not enable dri3 explicitly
any more. meta-raspi-light uses more PACKAGECONFIG defaults coming
from oe-core's mesa. There was a change in oe-core's mesa that enables
dri3 only if x11 AND vulcan are enabled - and I don't have vulcan in
DISTRO features (there will be no vulcan support for VC4). So my
builds disabled dri3.
After fixing my problem I've tried to turn the thread in the direction
of your chromium problem. The fact that I did not get further response
can either mean that Daniel is out or that my question was that stupid
that he is not willing to give further support (and I think this is
the case). Have not looked into that further but I think dri2/dri3 is
an either/or - there is no configuration supporting both.

[1] https://lists.freedesktop.org/archives/mesa-dev/2018-March/190645.html

Andreas