From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bart.vanassche@wdc.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Tejun Heo <tj@kernel.org>, Sagi Grimberg <sagi@grimberg.me>,
Israel Rukshin <israelr@mellanox.com>,
Max Gurtovoy <maxg@mellanox.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] blk-mq: Fix recently introduced races in the timeout handling code
Date: Mon, 9 Apr 2018 11:37:44 +0200 [thread overview]
Message-ID: <20180409093744.GC10405@lst.de> (raw)
In-Reply-To: <20180409052038.5391-1-bart.vanassche@wdc.com>
This looks sensible, but I'm worried about taking a whole spinlock
for every request completion, including irq disabling. However it seems
like your new updated pattern would fit use of cmpxchg() very nicely.
next prev parent reply other threads:[~2018-04-09 9:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-09 5:20 [PATCH] blk-mq: Fix recently introduced races in the timeout handling code Bart Van Assche
2018-04-09 8:37 ` Sagi Grimberg
2018-04-09 14:37 ` Bart Van Assche
2018-04-09 14:37 ` Bart Van Assche
2018-04-09 15:42 ` Israel Rukshin
2018-04-09 16:49 ` Tejun Heo
2018-04-09 9:37 ` Christoph Hellwig [this message]
2018-04-09 14:58 ` Bart Van Assche
2018-04-09 14:58 ` Bart Van Assche
2018-04-09 15:03 ` Jens Axboe
2018-04-09 16:47 ` Tejun Heo
2018-04-09 17:03 ` Bart Van Assche
2018-04-09 17:03 ` Bart Van Assche
2018-04-09 18:56 ` tj
2018-04-09 21:30 ` Bart Van Assche
2018-04-09 21:30 ` Bart Van Assche
2018-04-09 21:40 ` tj
-- strict thread matches above, loose matches on Subject: below --
2018-04-10 15:37 Alex G.
2018-04-10 15:37 ` Alex G.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180409093744.GC10405@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bart.vanassche@wdc.com \
--cc=israelr@mellanox.com \
--cc=linux-block@vger.kernel.org \
--cc=maxg@mellanox.com \
--cc=sagi@grimberg.me \
--cc=stable@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.