From: Vinod Koul <vinod.koul@intel.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Pierre-Yves MORDRET <pierre-yves.mordret@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
dmaengine@vger.kernel.org,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
M'boumba Cedric Madianga <cedric.madianga@gmail.com>,
Dan Williams <dan.j.williams@intel.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: [v2,2/2] dmaengine: stm32-mdma: Fix incomplete Hw descriptors allocator
Date: Fri, 13 Apr 2018 15:39:22 +0530 [thread overview]
Message-ID: <20180413100921.GM6014@localhost> (raw)
On Fri, Apr 13, 2018 at 10:39:48AM +0200, Geert Uytterhoeven wrote:
> Hi Vinod,
>
> On Fri, Apr 13, 2018 at 6:02 AM, Vinod Koul <vinod.koul@intel.com> wrote:
> > On Wed, Apr 11, 2018 at 04:44:39PM +0200, Pierre-Yves MORDRET wrote:
> >
> >> struct stm32_mdma_desc {
> >> struct virt_dma_desc vdesc;
> >> u32 ccr;
> >> - struct stm32_mdma_hwdesc *hwdesc;
> >> - dma_addr_t hwdesc_phys;
> >> bool cyclic;
> >> u32 count;
> >> + struct stm32_mdma_desc_node node[];
> >
> > some ppl use node[0] for this but i think either is fine..
>
> node[] is the correct one, node[0] may hide future bugs, cfr. commit
> a158531f3c92467d ("gpio: 74x164: Fix crash during .remove()")
Yeah but it this case it is the last element. But yes it helps to avoid such
mistakes in future..
WARNING: multiple messages have this Message-ID (diff)
From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/2] dmaengine: stm32-mdma: Fix incomplete Hw descriptors allocator
Date: Fri, 13 Apr 2018 15:39:22 +0530 [thread overview]
Message-ID: <20180413100921.GM6014@localhost> (raw)
In-Reply-To: <CAMuHMdWNyvveQ73SDrVy=EwkkO6Gd_4hmOkdstpcgzOL44a_mA@mail.gmail.com>
On Fri, Apr 13, 2018 at 10:39:48AM +0200, Geert Uytterhoeven wrote:
> Hi Vinod,
>
> On Fri, Apr 13, 2018 at 6:02 AM, Vinod Koul <vinod.koul@intel.com> wrote:
> > On Wed, Apr 11, 2018 at 04:44:39PM +0200, Pierre-Yves MORDRET wrote:
> >
> >> struct stm32_mdma_desc {
> >> struct virt_dma_desc vdesc;
> >> u32 ccr;
> >> - struct stm32_mdma_hwdesc *hwdesc;
> >> - dma_addr_t hwdesc_phys;
> >> bool cyclic;
> >> u32 count;
> >> + struct stm32_mdma_desc_node node[];
> >
> > some ppl use node[0] for this but i think either is fine..
>
> node[] is the correct one, node[0] may hide future bugs, cfr. commit
> a158531f3c92467d ("gpio: 74x164: Fix crash during .remove()")
Yeah but it this case it is the last element. But yes it helps to avoid such
mistakes in future..
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vinod.koul@intel.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Pierre-Yves MORDRET <pierre-yves.mordret@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
dmaengine@vger.kernel.org,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
"M'boumba Cedric Madianga" <cedric.madianga@gmail.com>,
Dan Williams <dan.j.williams@intel.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 2/2] dmaengine: stm32-mdma: Fix incomplete Hw descriptors allocator
Date: Fri, 13 Apr 2018 15:39:22 +0530 [thread overview]
Message-ID: <20180413100921.GM6014@localhost> (raw)
In-Reply-To: <CAMuHMdWNyvveQ73SDrVy=EwkkO6Gd_4hmOkdstpcgzOL44a_mA@mail.gmail.com>
On Fri, Apr 13, 2018 at 10:39:48AM +0200, Geert Uytterhoeven wrote:
> Hi Vinod,
>
> On Fri, Apr 13, 2018 at 6:02 AM, Vinod Koul <vinod.koul@intel.com> wrote:
> > On Wed, Apr 11, 2018 at 04:44:39PM +0200, Pierre-Yves MORDRET wrote:
> >
> >> struct stm32_mdma_desc {
> >> struct virt_dma_desc vdesc;
> >> u32 ccr;
> >> - struct stm32_mdma_hwdesc *hwdesc;
> >> - dma_addr_t hwdesc_phys;
> >> bool cyclic;
> >> u32 count;
> >> + struct stm32_mdma_desc_node node[];
> >
> > some ppl use node[0] for this but i think either is fine..
>
> node[] is the correct one, node[0] may hide future bugs, cfr. commit
> a158531f3c92467d ("gpio: 74x164: Fix crash during .remove()")
Yeah but it this case it is the last element. But yes it helps to avoid such
mistakes in future..
--
~Vinod
next reply other threads:[~2018-04-13 10:09 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-13 10:09 Vinod Koul [this message]
2018-04-13 10:09 ` [PATCH v2 2/2] dmaengine: stm32-mdma: Fix incomplete Hw descriptors allocator Vinod Koul
2018-04-13 10:09 ` Vinod Koul
-- strict thread matches above, loose matches on Subject: below --
2018-04-13 12:30 [v2,1/2] dmaengine: stm32-mdma: align TLEN and buffer length on burst Pierre Yves MORDRET
2018-04-13 12:30 ` [PATCH v2 1/2] " Pierre Yves MORDRET
2018-04-13 12:30 ` Pierre Yves MORDRET
2018-04-13 11:48 [v2,2/2] dmaengine: stm32-mdma: Fix incomplete Hw descriptors allocator Robin Murphy
2018-04-13 11:48 ` [PATCH v2 2/2] " Robin Murphy
2018-04-13 11:48 ` Robin Murphy
2018-04-13 11:09 [v2,1/2] dmaengine: stm32-mdma: align TLEN and buffer length on burst Robin Murphy
2018-04-13 11:09 ` [PATCH v2 1/2] " Robin Murphy
2018-04-13 11:09 ` Robin Murphy
2018-04-13 10:40 [v2,2/2] dmaengine: stm32-mdma: Fix incomplete Hw descriptors allocator Geert Uytterhoeven
2018-04-13 10:40 ` [PATCH v2 2/2] " Geert Uytterhoeven
2018-04-13 10:40 ` Geert Uytterhoeven
2018-04-13 9:45 [v2,1/2] dmaengine: stm32-mdma: align TLEN and buffer length on burst Pierre Yves MORDRET
2018-04-13 9:45 ` [PATCH v2 1/2] " Pierre Yves MORDRET
2018-04-13 9:45 ` Pierre Yves MORDRET
2018-04-13 8:39 [v2,2/2] dmaengine: stm32-mdma: Fix incomplete Hw descriptors allocator Geert Uytterhoeven
2018-04-13 8:39 ` [PATCH v2 2/2] " Geert Uytterhoeven
2018-04-13 8:39 ` Geert Uytterhoeven
2018-04-13 4:02 [v2,2/2] " Vinod Koul
2018-04-13 4:02 ` [PATCH v2 2/2] " Vinod Koul
2018-04-13 4:02 ` Vinod Koul
2018-04-11 15:14 [v2,1/2] dmaengine: stm32-mdma: align TLEN and buffer length on burst Robin Murphy
2018-04-11 15:14 ` [PATCH v2 1/2] " Robin Murphy
2018-04-11 15:14 ` Robin Murphy
2018-04-11 14:44 [v2,2/2] dmaengine: stm32-mdma: Fix incomplete Hw descriptors allocator Pierre Yves MORDRET
2018-04-11 14:44 ` [PATCH v2 2/2] " Pierre-Yves MORDRET
2018-04-11 14:44 ` Pierre-Yves MORDRET
2018-04-11 14:44 [v2,1/2] dmaengine: stm32-mdma: align TLEN and buffer length on burst Pierre Yves MORDRET
2018-04-11 14:44 ` [PATCH v2 1/2] " Pierre-Yves MORDRET
2018-04-11 14:44 ` Pierre-Yves MORDRET
2018-04-11 14:44 [PATCH v2 0/2] Append some fixes and improvements Pierre-Yves MORDRET
2018-04-11 14:44 ` Pierre-Yves MORDRET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180413100921.GM6014@localhost \
--to=vinod.koul@intel.com \
--cc=alexandre.torgue@st.com \
--cc=cedric.madianga@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=pierre-yves.mordret@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.