From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Xiong Zhou <xzhou@redhat.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-xfs <linux-xfs@vger.kernel.org>,
Eric Sandeen <sandeen@sandeen.net>,
fstests <fstests@vger.kernel.org>,
linux-nvdimm <linux-nvdimm@lists.01.org>
Subject: Re: ioctl FIBMAP for dax gone in v4.17-rc1
Date: Tue, 17 Apr 2018 09:57:56 -0700 [thread overview]
Message-ID: <20180417165756.GC24738@magnolia> (raw)
In-Reply-To: <CAPcyv4i05nP=wmOMwKFbdwqBrYXpcPBCmR4g2b4w8vOZaCBEnQ@mail.gmail.com>
On Tue, Apr 17, 2018 at 09:53:47AM -0700, Dan Williams wrote:
> On Tue, Apr 17, 2018 at 9:10 AM, Christoph Hellwig <hch@infradead.org> wrote:
> > On Tue, Apr 17, 2018 at 10:40:59PM +0800, Xiong Zhou wrote:
> >> We got these in v4.17-rc1:
> >> 6e2608d xfs, dax: introduce xfs_dax_aops
> >> fb094c9 ext2, dax: introduce ext2_dax_aops
> >> 5f0663b ext4, dax: introduce ext4_dax_aops
> >>
> >> And we don't have ->bmap call in these aops, which may lead
> >> to the ioctl call failure.
> >>
> >> Do we have any plan of adding/supporting it ?
> >>
> >> xfstests generic/223 covers this issue. If we are not going
> >> to support this call for dax, we need to fix the testcase.
> >
> > Not supporting ->bmap is a good thing as it is hightly dangerous.
>
> I take this to mean "don't fix, it is another casualty of dax being
> experimental and it won't be coming back". I can get on board with
> that.
>
> Otherwise, I was about to send a series adding bmap to {xfs,ext2,ext4}_dax_ops.
Frankly I'd rather see the swapfile code learn how to iomap and then we
can get rid of bmap in xfs entirely.
--D
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-xfs <linux-xfs@vger.kernel.org>,
linux-nvdimm <linux-nvdimm@lists.01.org>,
Eric Sandeen <sandeen@sandeen.net>,
fstests <fstests@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: ioctl FIBMAP for dax gone in v4.17-rc1
Date: Tue, 17 Apr 2018 09:57:56 -0700 [thread overview]
Message-ID: <20180417165756.GC24738@magnolia> (raw)
In-Reply-To: <CAPcyv4i05nP=wmOMwKFbdwqBrYXpcPBCmR4g2b4w8vOZaCBEnQ@mail.gmail.com>
On Tue, Apr 17, 2018 at 09:53:47AM -0700, Dan Williams wrote:
> On Tue, Apr 17, 2018 at 9:10 AM, Christoph Hellwig <hch@infradead.org> wrote:
> > On Tue, Apr 17, 2018 at 10:40:59PM +0800, Xiong Zhou wrote:
> >> We got these in v4.17-rc1:
> >> 6e2608d xfs, dax: introduce xfs_dax_aops
> >> fb094c9 ext2, dax: introduce ext2_dax_aops
> >> 5f0663b ext4, dax: introduce ext4_dax_aops
> >>
> >> And we don't have ->bmap call in these aops, which may lead
> >> to the ioctl call failure.
> >>
> >> Do we have any plan of adding/supporting it ?
> >>
> >> xfstests generic/223 covers this issue. If we are not going
> >> to support this call for dax, we need to fix the testcase.
> >
> > Not supporting ->bmap is a good thing as it is hightly dangerous.
>
> I take this to mean "don't fix, it is another casualty of dax being
> experimental and it won't be coming back". I can get on board with
> that.
>
> Otherwise, I was about to send a series adding bmap to {xfs,ext2,ext4}_dax_ops.
Frankly I'd rather see the swapfile code learn how to iomap and then we
can get rid of bmap in xfs entirely.
--D
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2018-04-17 16:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 14:40 ioctl FIBMAP for dax gone in v4.17-rc1 Xiong Zhou
2018-04-17 14:40 ` Xiong Zhou
2018-04-17 16:10 ` Christoph Hellwig
2018-04-17 16:10 ` Christoph Hellwig
2018-04-17 16:53 ` Dan Williams
2018-04-17 16:53 ` Dan Williams
2018-04-17 16:57 ` Darrick J. Wong [this message]
2018-04-17 16:57 ` Darrick J. Wong
2018-04-17 17:05 ` Dan Williams
2018-04-17 17:05 ` Dan Williams
2018-04-17 17:40 ` Andreas Dilger
2018-04-17 17:47 ` Dan Williams
2018-04-17 17:47 ` Dan Williams
2018-04-17 17:50 ` Darrick J. Wong
2018-04-17 17:50 ` Darrick J. Wong
2018-04-17 23:34 ` Theodore Y. Ts'o
2018-04-17 23:34 ` Theodore Y. Ts'o
2018-04-17 23:36 ` Dave Chinner
2018-04-17 23:36 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180417165756.GC24738@magnolia \
--to=darrick.wong@oracle.com \
--cc=dan.j.williams@intel.com \
--cc=fstests@vger.kernel.org \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
--cc=xzhou@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.